| Message ID | 20210311105551.18830-1-stefan.herbrechtsmeier-oss@weidmueller.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | mtd: spi-nor-ids: add dual and quad mode support to mx25l12805d | expand |
Hi Stefan, On 11/03/21 10:55AM, Stefan Herbrechtsmeier wrote: > From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com> > > The NOR flash MX25L12835F reuse the JEDEC ID of the MX25l12805D but > supports dual and quad mode. There is some discussion going on over at the Linux side [0] about these two flashes and how to properly support them. I suggest this you hold on to this patch until a proper solution is found and agreed upon for this. Or even better, you can help drive the solution forward on Linux as well. [0] https://lore.kernel.org/linux-mtd/CAEyMn7ZEp9f1SuE6umRDWkr8bVT5hdRi-4F3+G-GP9anuGG1Bw@mail.gmail.com/t/ > > Datasheet: https://www.macronix.com/Lists/Datasheet/Attachments/7321/MX25L12805D,%203V,%20128Mb,%20v1.2.pdf > Datasheet: https://www.macronix.com/Lists/Datasheet/Attachments/7397/MX25L12835F,%203V,%20128Mb,%20v1.6.pdf > > Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com> > > --- > > drivers/mtd/spi/spi-nor-ids.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c > index 2b57797954..f6de2fb1b8 100644 > --- a/drivers/mtd/spi/spi-nor-ids.c > +++ b/drivers/mtd/spi/spi-nor-ids.c > @@ -155,7 +155,7 @@ const struct flash_info spi_nor_ids[] = { > { INFO("mx25u1635e", 0xc22535, 0, 64 * 1024, 32, SECT_4K) }, > { INFO("mx25u3235f", 0xc22536, 0, 4 * 1024, 1024, SECT_4K) }, > { INFO("mx25u6435f", 0xc22537, 0, 64 * 1024, 128, SECT_4K) }, > - { INFO("mx25l12805d", 0xc22018, 0, 64 * 1024, 256, SECT_4K) }, > + { INFO("mx25l12805d", 0xc22018, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, > { INFO("mx25u12835f", 0xc22538, 0, 64 * 1024, 256, SECT_4K) }, > { INFO("mx25l12855e", 0xc22618, 0, 64 * 1024, 256, 0) }, > { INFO("mx25l25635e", 0xc22019, 0, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, > -- > 2.20.1 >
Hi Pratyush Yadav, Am 11.03.2021 um 13:15 schrieb Pratyush Yadav: > Hi Stefan, > > On 11/03/21 10:55AM, Stefan Herbrechtsmeier wrote: >> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com> >> >> The NOR flash MX25L12835F reuse the JEDEC ID of the MX25l12805D but >> supports dual and quad mode. > > There is some discussion going on over at the Linux side [0] about these > two flashes and how to properly support them. I suggest this you hold on > to this patch until a proper solution is found and agreed upon for this. > Or even better, you can help drive the solution forward on Linux as > well. Thanks for the link. > [0] https://lore.kernel.org/linux-mtd/CAEyMn7ZEp9f1SuE6umRDWkr8bVT5hdRi-4F3+G-GP9anuGG1Bw@mail.gmail.com/t/ > >> >> Datasheet: https://www.macronix.com/Lists/Datasheet/Attachments/7321/MX25L12805D,%203V,%20128Mb,%20v1.2.pdf >> Datasheet: https://www.macronix.com/Lists/Datasheet/Attachments/7397/MX25L12835F,%203V,%20128Mb,%20v1.6.pdf >> >> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com> >> >> --- >> >> drivers/mtd/spi/spi-nor-ids.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c >> index 2b57797954..f6de2fb1b8 100644 >> --- a/drivers/mtd/spi/spi-nor-ids.c >> +++ b/drivers/mtd/spi/spi-nor-ids.c >> @@ -155,7 +155,7 @@ const struct flash_info spi_nor_ids[] = { >> { INFO("mx25u1635e", 0xc22535, 0, 64 * 1024, 32, SECT_4K) }, >> { INFO("mx25u3235f", 0xc22536, 0, 4 * 1024, 1024, SECT_4K) }, >> { INFO("mx25u6435f", 0xc22537, 0, 64 * 1024, 128, SECT_4K) }, >> - { INFO("mx25l12805d", 0xc22018, 0, 64 * 1024, 256, SECT_4K) }, >> + { INFO("mx25l12805d", 0xc22018, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, >> { INFO("mx25u12835f", 0xc22538, 0, 64 * 1024, 256, SECT_4K) }, >> { INFO("mx25l12855e", 0xc22618, 0, 64 * 1024, 256, 0) }, >> { INFO("mx25l25635e", 0xc22019, 0, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, >> -- >> 2.20.1 >> >
diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c index 2b57797954..f6de2fb1b8 100644 --- a/drivers/mtd/spi/spi-nor-ids.c +++ b/drivers/mtd/spi/spi-nor-ids.c @@ -155,7 +155,7 @@ const struct flash_info spi_nor_ids[] = { { INFO("mx25u1635e", 0xc22535, 0, 64 * 1024, 32, SECT_4K) }, { INFO("mx25u3235f", 0xc22536, 0, 4 * 1024, 1024, SECT_4K) }, { INFO("mx25u6435f", 0xc22537, 0, 64 * 1024, 128, SECT_4K) }, - { INFO("mx25l12805d", 0xc22018, 0, 64 * 1024, 256, SECT_4K) }, + { INFO("mx25l12805d", 0xc22018, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { INFO("mx25u12835f", 0xc22538, 0, 64 * 1024, 256, SECT_4K) }, { INFO("mx25l12855e", 0xc22618, 0, 64 * 1024, 256, 0) }, { INFO("mx25l25635e", 0xc22019, 0, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },