From patchwork Fri Mar 5 20:12:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1448193 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=secospa.onmicrosoft.com header.i=@secospa.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-secospa-onmicrosoft-com header.b=6ZjRcEFS; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Dsf7C1cKLz9sVS for ; Sat, 6 Mar 2021 07:13:11 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6C17E8263A; Fri, 5 Mar 2021 21:12:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=secospa.onmicrosoft.com header.i=@secospa.onmicrosoft.com header.b="6ZjRcEFS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8B9CD82016; Fri, 5 Mar 2021 21:12:44 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.2 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062c.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::62c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EA4AD80F58 for ; Fri, 5 Mar 2021 21:12:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AplVnW5jS5SU31MVQoS2EZJ7JgxyXIyM36FocKLLm9OLppM1WHgNpGPDJboP4BXpmsA7LYbn5+CqzVlkEx//lpD0EmQoxknpnE6X75EmuntySZN1dGIQXRQOncayWyjKPLO5fdAVClinZJw1nqgrUusgA64OxuUtrilMFT2k2XHmmmafd+Z7mcLmYPtjQYPjlhXgOCS7w9vJ4HfSBV8w9K5E/1h3aAQ7VyfWKQEJSP0QSeUe8zYvqrYkrTJo2R2Uk0ndWFtXEc1UoMzQ+xr4rIpT13E8kyczUJHxPQGsd40anHpx0DaVXuG3rCZ+o0Mbpnq2AMGXLWg05hww7V5zNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8PZAS8COUKTr/a4r0uYMx+zHnrJoL3xA+bPVDA5kDcI=; b=F+RWhifUgHZVO9mhGkYIQaY/rljpmTAhPP8QNm/DJl5kVKQ8edJjkuDMKVMkn5lFYTHC0CN8dZU6Thx5dK5d2FEnt7KzfZKiMW/VS0mvFALWFDHfL3eKs2dPfadHCB5+Hg7rhKnhVl2jtPSyGQWYUja3OVzemhO9CGux8wQR9i1n2c8OrvezTL+V+BQzlvrkPs+ZajvrGheTEPazSDoLgtpZ8sAQeF4kcDFTjjYws9TZR535kfZeJmbvVKi3VZambAs5T/DnPM2HvTBu37w+t19d2hKuW5kIloNG9/U0d+ZD+L1HHsr6ft3ALCcyZhPKO6nZFbQC/XJZeJ6lzdgG+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secospa.onmicrosoft.com; s=selector2-secospa-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8PZAS8COUKTr/a4r0uYMx+zHnrJoL3xA+bPVDA5kDcI=; b=6ZjRcEFSnNUgaAtgwADDthSTckiMOGZW5yIVbHTR6NbMgPKPvpVGzMF+0mnsztCB3YEepPc39s1sTcMsA/eqc7GPnqCldAk3U1BbIylMpFKgohSyqI/mnftMHhHqEHZi5+xYlCQQB/WoTAQBddiLKBak0HKCIftR6KltP6o49Tk= Authentication-Results: chromium.org; dkim=none (message not signed) header.d=none;chromium.org; dmarc=none action=none header.from=seco.com; Received: from AM0PR03MB4514.eurprd03.prod.outlook.com (2603:10a6:208:d0::10) by AM0PR03MB4338.eurprd03.prod.outlook.com (2603:10a6:208:c3::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Fri, 5 Mar 2021 20:12:41 +0000 Received: from AM0PR03MB4514.eurprd03.prod.outlook.com ([fe80::439:40f3:673f:f32e]) by AM0PR03MB4514.eurprd03.prod.outlook.com ([fe80::439:40f3:673f:f32e%7]) with mapi id 15.20.3890.034; Fri, 5 Mar 2021 20:12:41 +0000 From: Sean Anderson To: Simon Glass , u-boot@lists.denx.de Cc: Sean Anderson , Heiko Schocher , Jean-Jacques Hiblot , Patrick Delaunay , Pratyush Yadav Subject: [PATCH v2 1/5] dm: gpio: Fix gpio_get_list_count failing with livetree Date: Fri, 5 Mar 2021 15:12:21 -0500 Message-Id: <20210305201225.3753841-2-sean.anderson@seco.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210305201225.3753841-1-sean.anderson@seco.com> References: <20210305201225.3753841-1-sean.anderson@seco.com> X-Originating-IP: [50.195.82.171] X-ClientProxiedBy: BL1PR13CA0258.namprd13.prod.outlook.com (2603:10b6:208:2ba::23) To AM0PR03MB4514.eurprd03.prod.outlook.com (2603:10a6:208:d0::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from plantagenet.inhand.com (50.195.82.171) by BL1PR13CA0258.namprd13.prod.outlook.com (2603:10b6:208:2ba::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.10 via Frontend Transport; Fri, 5 Mar 2021 20:12:39 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5a37aa62-f033-4b3a-be94-08d8e0130770 X-MS-TrafficTypeDiagnostic: AM0PR03MB4338: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:121; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GqznCV+BJ02Yt1Fw33hmVIY/rgO++pswrNYpwbKXoKYpjmOGaVcbpHNaqo+L0dIB1YCAg0GG1p1/3FI76hH1gsJotsz/iSkpZUIsVQTjXLczcymPWT6CWArw2Ccs44hpwb4uJSisH0VjEyNuMWEUuCkET+Uf8G1QeY/K32iBGBTLGewBZ3gWakx8O3bH2UExlggOVyoR1cS2Xm9x31GCT+LGU6CqeAT3W0doRNkGEqwfk0YCNcSX8C46oLkrW0f203Iu4+VbHTl8MtrreAtUJ9rwZcx9B+pMErDp47dqnQw+YFHI/WpStZJTbgBXTk9bPaQGnCl+kjN2KVdDpeqtOc0gO3g9283oru3K30Ivz/WqD66gVcYAsEgfd/I5l6s3WOoC1SeMii1atFuoLLxWXMfYwLePwZwTSyVl0G3566X9rfZ/v7I3shTcC6sJ06n9hyIwf96RO0gdItZYBmGwNhp7thInF0CyQ94r8HbG/YmtT3BESDqLEU9sthqlSzkdy3hHTMiEt8ZiVgKEkapUBQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR03MB4514.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(39840400004)(136003)(346002)(396003)(366004)(6512007)(6506007)(66946007)(5660300002)(66556008)(52116002)(8676002)(6666004)(2616005)(83380400001)(16526019)(186003)(36756003)(956004)(1076003)(66476007)(86362001)(44832011)(316002)(26005)(2906002)(4326008)(54906003)(6486002)(8936002)(478600001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: BM5HX9qcqUeTFFyCTT46IYgVpE0tM0Q2jEcFal/6Nbi3UXWPmp0S+efopwS0sRW+dpn2nBQf41oSEtTT0JgNrjg1TbtvNpQ6NopfDq0iQmP2OdhN/B8YBdw3IvT+cY10zfQuA7DXiN1Xfm/E9LQaFK3P1JUuuQHyqEdgJ88qA2DUPcl58tqai4Ndbj3BQsa/Bhna0V1ONgeRouxe6A2NZBEsf46wP0Xii65KymQafJhthhEdxiQQrADZsiX5Z0rRsu2LeN8R35MPuE1UsWzHsCZwxs7Xp67z3axMEBdfsgngTyBfcJs1wVaoGx5Pfxkem5PU5ZkSey3W/11EXj5dMBMiyF5fIXjm/rhXwxOEMUWYbP9YNo8NVc3N938nkb4o5h2uRJpRY9Dab6QGpHw66iDxrZnHfKH/u3+ksee4NyLj+1SN6u5DzGFxi4ASFNDoySnaPzhHkooo85/AxpEgqizyXZFUqtWdOAOt1mWG2ym5Fuf7mK8PiyMsGjqGAVaq5Ud9tMDpPd15YuPdcGMAb3P0fODGFjNl0kHN7iXMjXzGMXK5aoOpnw6YD/i3AXG8RrIFARdat6Atbxe8r4XvExUhJBCrqAl1TdocgvqCSEmeaH/EHywmTjeXv8G3GcXH3gCOvfKYWQ2LTzFIX/xTY3ThXoCb1M5LMQ+Pq4ZRb6fDzTeZR3uio2RbpQDYWL7gjNNpAWJdHYtMGY+SouOBy/XyiC0TtrhY3Gg9X970nsrygzUQC8jAffiAJ6tQwJap6+lo2LdAs9pCFSJpa9ZX9yIwpgWM2khGZ9o30V2c2EFUkP3FFbXy+I8Hfmca3lZU5maCqnnrj/GqZSZBo8JXK1N1h2gmuFpTBaGL6D/ZubobtsiLfLA4m9A4zkKVg7wQaSfUISqCpKDKfoQ+VzBDjFihelBtDAqTEybacCQ1m/q6w+tjJ5qg0aSHfZuwobLtuva57xUZmtTQ8EqN2fElt+nKf/yRbR5FWvetp1PjtWlq1lMuggiNQBl3+MpzS0wkzo28opaPFBHwvToxICLyi/QN98+9uQrnFTXWHkrkk5B8I0JAxsW3sdkdjaz5UPe8/jugkimt1bc2HpH5mFmIpVQNCCOpVBQ+p4J3tuuhKywGxt5n+oBSPZYCyYOld3KQEgPr4TF/a55KjnaE2riysIKsg97AVMQo4amJAxUeGCo1prJ0aQ2hrPLBPCF+OgwUoul0fusAdxz74Kicy/LsNb34LY0lRSbS+9G7AlF+35Fix6koLMiukake8yvWjLcheBcfLd0ghIiyD8RAo3EauDA0KYe7nnFVwIeWZWWyoMF9sZtF8iUB+gQiLhb7hGgH X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a37aa62-f033-4b3a-be94-08d8e0130770 X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB4514.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2021 20:12:40.9183 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vyodijvfc6xOOkAUsjXSueHRAfNYEhL+3CWzKk6H790xN6EO8q46P5GhwD4tVOSFvvcL9V7Wa0ZSzkUBE+xWIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4338 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean of_parse_phandle_with_args (called by dev_read_phandle_with_args) does not support getting the length of a phandle list by using the index -1. Instead, use dev_count_phandle_with_args which supports exactly this use-case. Fixes: 8558217153 ("gpio: Convert to use APIs which support live DT") Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- Changes in v2: - Change Fixes tag to the most recent commit touching these lines drivers/gpio/gpio-uclass.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-uclass.c b/drivers/gpio/gpio-uclass.c index 8dc647dc9f..8de6fe58a4 100644 --- a/drivers/gpio/gpio-uclass.c +++ b/drivers/gpio/gpio-uclass.c @@ -1214,8 +1214,8 @@ int gpio_get_list_count(struct udevice *dev, const char *list_name) { int ret; - ret = dev_read_phandle_with_args(dev, list_name, "#gpio-cells", 0, -1, - NULL); + ret = dev_count_phandle_with_args(dev, list_name, "#gpio-cells", + -ENOENT); if (ret) { debug("%s: Node '%s', property '%s', GPIO count failed: %d\n", __func__, dev->name, list_name, ret);