From patchwork Fri Feb 19 07:41:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Armstrong X-Patchwork-Id: 1442030 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=TTMTYOcX; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Dhk6T5qqkz9sRR for ; Fri, 19 Feb 2021 18:41:37 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1F64D826FB; Fri, 19 Feb 2021 08:41:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="TTMTYOcX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8410982767; Fri, 19 Feb 2021 08:41:31 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AF411826D4 for ; Fri, 19 Feb 2021 08:41:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=narmstrong@baylibre.com Received: by mail-wm1-x333.google.com with SMTP id x16so6044703wmk.3 for ; Thu, 18 Feb 2021 23:41:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hlotbfUt+I9XyLIJG71XU0aeJzz/JJhjKKNEoZp5x9o=; b=TTMTYOcXI0HwXq0RJI9+quu2hZ7r4N08t6YKsKqbq//DEsw7bllNK5i141yAOO2GgE dre3F+HyNvONc8mE/wrolm7iVQrMNwEhEFWjKrqLWO6YQcvAOs+2Y0jOECYADPOpZ4Jd V6UCl6sSnOp65miKXZmwlb0NdXLo3Sr9CDE8GhxiL0bKUVmWMBvlS2iC6vQQcsJMtwab 3wuYinAHg7CmBsxIMzmAfLFj8qO6pscIGZbXZnCWAV1FxTFcdS/t1VNcHx30S8oN7LVl e+29XAfwx0giPsq6PGE5vgSElCh5fxFgH3JHNe9hbrs49PyIV2RRObNJy/SHqaB5EJYw 8hZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hlotbfUt+I9XyLIJG71XU0aeJzz/JJhjKKNEoZp5x9o=; b=g5ybWps8hFCC9cItLSpEaeiuRM/25IFULRh0tZWGph4/LoB7oP7t082QUAAjDKZZ53 1TIz08kOKDjUtoSQoYgEmOzB1l+k/4bFKOj01lNV/lnzyoWSYeJ1OIaFTNYpZT3nH7wX igVNUYV1EBqfnE3Elenj6Iolj1xb20GmSSl4wHfVXxW4WOv3Y/+2FV0PFvhoaEtexy/K iY6wMGhzDDfbzjPNHLqF/mwnqimHuB6Yr49hix47qGg8THup4KLWHtXVBaBqBEfJJZb+ rQRo4EmggKOyJFwWsm8Y+2zzStVwQ20qHKnzpZdL8AWNe75+iK3WV9rEJPYQ+JTBOReo oVBw== X-Gm-Message-State: AOAM530Wi4qi9v8juV3vm7jm2Giuou4dPF4aiw1aCqUpvZZJXpjKv6qa jUxzvlyRxVwEBRmWcKZlwH1I6w== X-Google-Smtp-Source: ABdhPJzf/Ut9SRVQEDlM7ddLFUV5RlKQRhrH8aGthvyelQet3/o3eqZYcU+kn1tX4pANsrYfUtBJBA== X-Received: by 2002:a7b:c050:: with SMTP id u16mr4618611wmc.90.1613720488181; Thu, 18 Feb 2021 23:41:28 -0800 (PST) Received: from localhost.localdomain ([2a01:e0a:90c:e290:bf58:5468:5bfc:4d41]) by smtp.gmail.com with ESMTPSA id u142sm11195439wmu.3.2021.02.18.23.41.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 23:41:27 -0800 (PST) From: Neil Armstrong To: Simon Glass , xypron.glpk@gmx.de Cc: Neil Armstrong , m.szyprowski@samsung.com, u-boot@lists.denx.de, u-boot-amlogic@groups.io, philippe.reynes@softathome.com Subject: [PATCH] button: add udevice forward declaration Date: Fri, 19 Feb 2021 08:41:24 +0100 Message-Id: <20210219074124.1571269-1-narmstrong@baylibre.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean After 401d1c4f5d2d ("common: Drop asm/global_data.h from common header") build fails with : drivers/button/button-uclass.c:13:5: error: conflicting types for 'button_get_by_label' int button_get_by_label(const char *label, struct udevice **devp) ^~~~~~~~~~~~~~~~~~~ Adding struct udevice forward declaration in button.h solves the build error. Fixes: 401d1c4f5d2d ("common: Drop asm/global_data.h from common header") Suggested-by: Heinrich Schuchardt Signed-off-by: Neil Armstrong Reviewed-by: Simon Glass --- Hi, This is needed to fix build on vim3/vim3l after [1] is applied. [1] https://patchwork.ozlabs.org/project/uboot/cover/20210218103318.18915-1-m.szyprowski@samsung.com/ include/button.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/button.h b/include/button.h index 688b63b082..ee14fadf0c 100644 --- a/include/button.h +++ b/include/button.h @@ -6,6 +6,8 @@ #ifndef __BUTTON_H #define __BUTTON_H +struct udevice; + /** * struct button_uc_plat - Platform data the uclass stores about each device *