From patchwork Mon Feb 1 02:01:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1434007 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=OeZf69Xj; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DTWRM2lC0z9srY for ; Mon, 1 Feb 2021 13:02:23 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 265AF82675; Mon, 1 Feb 2021 03:02:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="OeZf69Xj"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EC3FF82690; Mon, 1 Feb 2021 03:02:14 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2C96282652 for ; Mon, 1 Feb 2021 03:02:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1612144931; bh=wi9UOOXt3kpylh5ZyeQwNIPfMO/mdRaiibFbOdTmml4=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=OeZf69XjTYS/+CxjaAuoBJqg+5vtiTx5A+VXc8ozCisX+UpJO8Kxlrpl03DCZWmYT ZgyMCArXmxA6b9tN91zrgXLf90VLZt50ExW0OEOy0xJ3YPirKcGu9MIWrjJm1EDAQL fh4JDfMnZEh+6UVzBKVQb9V6Nsb9/nNS3PzFdDTo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([62.143.246.89]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1M8hV5-1l1jiE1IJt-004mD3; Mon, 01 Feb 2021 03:02:11 +0100 From: Heinrich Schuchardt To: Simon Glass Cc: Etienne Carriere , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] firmware: smci: possible NULL dereference Date: Mon, 1 Feb 2021 03:01:54 +0100 Message-Id: <20210201020154.67751-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:HrujXEGuoq0ohBCUE14chSGMCOk6B5PsvnQ0FOHpGEAYv53oWli y8in/Xt3A+acO947M8U13PAyxK1XupjpfkZizUYhFHXwgyUjEpgOhG4tUHbwvWvaH9BtDsd kw6r4XGYqRUv+8+B5dIZ4Kpw9lDwduW9cZnN24XfBxu4Y0dIFHmRSh6SwqQWat9WYeWByC3 OBnm85AylNCrGVEPwGDBQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:c1bPAabaqhM=:QHYKbylE8RAQBWHM1o4Wxo n+uy1WfHd5IvxoTS+dEWj73DK4UaJbwELJQRtmVXcjb9nWL7ziZ8zcY1iG4hJ7uG4vzzrLd0o asapEMvJBKuIb1YnMxVrOGYefdk8EzWXru9AT9uIH4kLaTTARI+xC6gB5bCQkCL6xy5ms07iG ZHSjwno7dRvfFriXMKznxOnnvxqaMdugME+Zr3Mcyyyv1WADpMEVPna08Kcb5OB/Lhob3tmJh zb6YsRV2iq01D/+41TVtBwJ2BiNvKFht9eoyP2JvT/otnGuTNUxH19MmrmHlxZ5INOjco2VLs k8Wp2LzIwsomAupLlzJBO6pWOBYufhTwP0bTxVa55bWpVqQ4UWzQkQNwgGu2z+j8HP193w9lA +z2OWpLSjHUzAM7pBfnodVRaVxfHvnGDIgALK7noUfE8joa4VHR1hWz9dnsCcTs5mP/4RExQ1 twJgpPm6r9wvrKLLa2nHuHNSFeAVF0sHdlyLfnwJbgkqkx8tZBhdNjiKGR2ZWnTRVr+IonA5H 70QxZ4JjJxBWjKiOC7Gi3q7XhboPDbr14KLL1P37q/QO/yaaveAPzRjGNXKSaNLA3ZrOdnOT/ SSOS3mboXAG05d3J8bHtg78jtT2kds4OSmlcPJIPFYA2q5h66Hw7UyZI15CsU0egdMyPNYHwK Oa9BAHi3Bng5S+rWalQ1dM4/E7+WmP+v59ZnUJDT/EWCEhBCJSYSlAxZsxMUheFLgjXBNenMH 3PTFhwW/r5eKMPcyhJ9mKEIIwW+AdWjf9NpfQbl9zGFtixYQSdYg9X4kBw9L/erEoDAF70w8y /tixi+Hy/wf75qc3rzBI6vaEV4ZUfxaWY+yVVJv4pqh9gBy15NnpiGHoqjjoWfWwz2OM3vlAm B/5MGWGbQmpKnXOmHe2g== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean sandbox_scmi_devices_ctx() may return NULL. We should not dereference this value in sandbox_scmi_devices_remove(). The problem was indicated by 'gcc-11 -fanalyzer'. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass Reviewed-by: Simon Glass --- drivers/firmware/scmi/sandbox-scmi_devices.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.29.2 diff --git a/drivers/firmware/scmi/sandbox-scmi_devices.c b/drivers/firmware/scmi/sandbox-scmi_devices.c index 414da6f4df..1a6fafbf53 100644 --- a/drivers/firmware/scmi/sandbox-scmi_devices.c +++ b/drivers/firmware/scmi/sandbox-scmi_devices.c @@ -50,6 +50,9 @@ static int sandbox_scmi_devices_remove(struct udevice *dev) int ret = 0; size_t n; + if (!devices) + return 0; + for (n = 0; n < SCMI_TEST_DEVICES_RD_COUNT; n++) { int ret2 = reset_free(devices->reset + n);