From patchwork Sun Dec 27 09:50:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1420717 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=hYfcD5vJ; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4D3bXd1VNBz9sW8 for ; Sun, 27 Dec 2020 20:50:57 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1DFED82565; Sun, 27 Dec 2020 10:50:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="hYfcD5vJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0B7CA82570; Sun, 27 Dec 2020 10:50:49 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 81EDD824DE for ; Sun, 27 Dec 2020 10:50:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1609062645; bh=BUFS2XOohE1q2/tfu+FIGIHbbyeHrTnr5nGOFHY60g4=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=hYfcD5vJFyZXCE93BJV1r/t64MYjf+HA6PIW7NXQv2Y2HgLYYd5h/pbrYk2sTpeqi QkeVFj9hzTtnjgKC/Ss4Lg0R3WioayiAnQg5DvagRjqcQvVlpyzE/hWPwRubDtLjll uAIZncXQ1dUY0bayqAShAcg3XOkHMVxiF8RHgoZA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([62.143.246.89]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MD9T1-1kkyN21U2r-00960L; Sun, 27 Dec 2020 10:50:45 +0100 From: Heinrich Schuchardt To: Peng Fan Cc: u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] mmc: fsl_esdhc_spl: remove superfluous free() Date: Sun, 27 Dec 2020 10:50:26 +0100 Message-Id: <20201227095026.26501-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:SBIVa8TPaWgxT2B3MR2izfMcYfPgy63DbgQXbHprSkRL1IVxnH6 1px1OMULLxhZjsRb/U1BXZ+GO/Qdt+FMbRmRuUu7C9WzaS10e+NxbL9jvP2bEcbxvMx4IcQ mLbgHvqJWmKq0ISTyfuMFV6DWjp5okeEBwY1hUVw8bU87LI1DNrAEj0BQTmnzcT1H668qQO 4JWvXiqxOKqyqXDlqQTwg== X-UI-Out-Filterresults: notjunk:1;V03:K0:SMVJQEYC1mE=:eAgZ8AVSI4o54eVTO4zwu/ hM+0f3qSF+Yi15RlHwdSix58LS0yRrGQToKmVb4VEP8ie6lg1eIH9A6QZFN3H0jclEoc73X+G Wp916x5XyzF9aqfxh7Q4d9MkIZiN4AlqWeMFsfO1PIKlDXEa3AYWbLhE3Au3F7bDaMNZvy6Uu mFHk25a0IwTmy/zX7ZxnJhl+ULBNZEdK+QXX4xLSK8wl6qvkFDtoX4QZh7YUMtwtbzoLp9A5H 3Yqx/sM995GbIA47SU8meepPnZXDM7RqhrK5um5wsV/ABxuXFv4m9Wt9REtHORlhseIprxf3U TJmcvOEUyMM3x80bA/aQ1epB/Hpx6sYPTAVdV+LVMQ1U6DCgzsWPaxRkjV3+ufKzh9BUF151H VLjYfu0ouX8ErRtXitonWOnw6xeLytSsc/mmotH7bU97R4aoHkXw6IMURXpVilNBytZsS0xOX MBCI7/FVMk4kvXxMzMGE8iqyPvOpjttVqcrPGwQCI5n44HffxPTr+ABJFH//j9I6NOBLj10/C VLB0tBcPNY0B/FlYlc3O4ZmOs1EaFkUHCOQ5x13+rfD9uKRaMCPhpq7Kcqg2IpAdkvWd0JSf9 r0cMQtJNlrq/QrZaS5uwSIQXKlgH5+qA55m7+OvRfKp1G3ncO1N+7rRaFVh24j9Gt1Ut/I77z Z1wIOtsxeEB6zo0zULotozcnsZB+UqUsc6UDpOMfoawks44FOCpVMzk4JnStoErVdEgdVoa27 z+kuk09gNbJtC5hrDkzAX2xoyZCP4N4J6r5vaRheCo1J83OqWMguoqz72x+agYwREOTrwZYKK tk3jLa+9R0EYXYRUBtUxfP+Msfbj3tpxVhvNhnJxB+N6oSUJXXj+lUnN/NBK1b3g40PQOvosb iAWwYNeDvvcnPr/USBKQ== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean Freeing a buffer before calling hang() is superfluous. Removing the call reduces the SPL size. Signed-off-by: Heinrich Schuchardt Reviewed-by: Jaehoon Chung --- drivers/mmc/fsl_esdhc_spl.c | 3 --- 1 file changed, 3 deletions(-) -- 2.29.2 diff --git a/drivers/mmc/fsl_esdhc_spl.c b/drivers/mmc/fsl_esdhc_spl.c index afe55fad9d..bee76572ac 100644 --- a/drivers/mmc/fsl_esdhc_spl.c +++ b/drivers/mmc/fsl_esdhc_spl.c @@ -91,20 +91,17 @@ void __noreturn mmc_boot(void) CONFIG_CFG_DATA_SECTOR, 1, tmp_buf); if (err != 1) { puts("spl: mmc read failed!!\n"); - free(tmp_buf); hang(); } val = *(tmp_buf + MBRDBR_BOOT_SIG_55); if (0x55 != val) { puts("spl: mmc signature is not valid!!\n"); - free(tmp_buf); hang(); } val = *(tmp_buf + MBRDBR_BOOT_SIG_AA); if (0xAA != val) { puts("spl: mmc signature is not valid!!\n"); - free(tmp_buf); hang(); }