| Message ID | 20201105002906.109548-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [1/1] test: test/lib/test_print.c depends on CONSOLE_RECORD | expand |
Hi Heinrich, On Wed, 4 Nov 2020 at 17:29, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > The tests in test/lib/test_print.c fail without CONFIG_CONSOLE_RECORD=y. > > Add a build dependency. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > test/lib/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org> But this is a strange thing to depend on. I wonder if we should add a Kconfig for this test? I haven't done it so far as I was worried about a proliferation of Kconfigs. > > diff --git a/test/lib/Makefile b/test/lib/Makefile > index 98a9abf40e..97c11e35a8 100644 > --- a/test/lib/Makefile > +++ b/test/lib/Makefile > @@ -7,7 +7,7 @@ obj-$(CONFIG_EFI_LOADER) += efi_device_path.o > obj-$(CONFIG_EFI_SECURE_BOOT) += efi_image_region.o > obj-y += hexdump.o > obj-y += lmb.o > -obj-y += test_print.o > +obj-$(CONFIG_CONSOLE_RECORD) += test_print.o > obj-$(CONFIG_SSCANF) += sscanf.o > obj-y += string.o > obj-$(CONFIG_ERRNO_STR) += test_errno_str.o > -- > 2.28.0 >
On Thu, Nov 05, 2020 at 01:29:06AM +0100, Heinrich Schuchardt wrote: > The tests in test/lib/test_print.c fail without CONFIG_CONSOLE_RECORD=y. > > Add a build dependency. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/test/lib/Makefile b/test/lib/Makefile index 98a9abf40e..97c11e35a8 100644 --- a/test/lib/Makefile +++ b/test/lib/Makefile @@ -7,7 +7,7 @@ obj-$(CONFIG_EFI_LOADER) += efi_device_path.o obj-$(CONFIG_EFI_SECURE_BOOT) += efi_image_region.o obj-y += hexdump.o obj-y += lmb.o -obj-y += test_print.o +obj-$(CONFIG_CONSOLE_RECORD) += test_print.o obj-$(CONFIG_SSCANF) += sscanf.o obj-y += string.o obj-$(CONFIG_ERRNO_STR) += test_errno_str.o
The tests in test/lib/test_print.c fail without CONFIG_CONSOLE_RECORD=y. Add a build dependency. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- test/lib/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.28.0