diff mbox series

[1/1] cmd: CMD_CPU depends on CPU

Message ID 20201104232911.72901-1-xypron.glpk@gmx.de
State Accepted
Commit 622178d923d5e5767d33df242a09bc7dae500976
Delegated to: Tom Rini
Headers show
Series [1/1] cmd: CMD_CPU depends on CPU | expand

Commit Message

Heinrich Schuchardt Nov. 4, 2020, 11:29 p.m. UTC
Compiling with CONFIG_CMD_CPU=y and CONFIG_CPU=n fails with:

aarch64-linux-gnu-ld.bfd: cmd/built-in.o: in function `print_cpu_list':
/home/user/u-boot/cmd/cpu.c:34: undefined reference to `cpu_get_desc'
aarch64-linux-gnu-ld.bfd:
/home/user/u-boot/cmd/cpu.c:39: undefined reference to `cpu_get_info'
Segmentation fault (core dumped)
make: *** [Makefile:1757: u-boot] Error 139
make: *** Deleting file 'u-boot'

See error report in https://stackoverflow.com/questions/64678347.

Add the missing build dependency.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

--
2.28.0

Comments

Simon Glass Nov. 11, 2020, 2:32 p.m. UTC | #1
On Wed, 4 Nov 2020 at 16:29, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> Compiling with CONFIG_CMD_CPU=y and CONFIG_CPU=n fails with:
>
> aarch64-linux-gnu-ld.bfd: cmd/built-in.o: in function `print_cpu_list':
> /home/user/u-boot/cmd/cpu.c:34: undefined reference to `cpu_get_desc'
> aarch64-linux-gnu-ld.bfd:
> /home/user/u-boot/cmd/cpu.c:39: undefined reference to `cpu_get_info'
> Segmentation fault (core dumped)
> make: *** [Makefile:1757: u-boot] Error 139
> make: *** Deleting file 'u-boot'
>
> See error report in https://stackoverflow.com/questions/64678347.
>
> Add the missing build dependency.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  cmd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini Jan. 18, 2021, 12:59 p.m. UTC | #2
On Thu, Nov 05, 2020 at 12:29:11AM +0100, Heinrich Schuchardt wrote:

> Compiling with CONFIG_CMD_CPU=y and CONFIG_CPU=n fails with:
> 
> aarch64-linux-gnu-ld.bfd: cmd/built-in.o: in function `print_cpu_list':
> /home/user/u-boot/cmd/cpu.c:34: undefined reference to `cpu_get_desc'
> aarch64-linux-gnu-ld.bfd:
> /home/user/u-boot/cmd/cpu.c:39: undefined reference to `cpu_get_info'
> Segmentation fault (core dumped)
> make: *** [Makefile:1757: u-boot] Error 139
> make: *** Deleting file 'u-boot'
> 
> See error report in https://stackoverflow.com/questions/64678347.
> 
> Add the missing build dependency.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 1595de999b..efc8721b9d 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -113,6 +113,7 @@  config CMD_CONSOLE

 config CMD_CPU
 	bool "cpu"
+	depends on CPU
 	help
 	  Print information about available CPUs. This normally shows the
 	  number of CPUs, type (e.g. manufacturer, architecture, product or