diff mbox series

[1/2] lib: print_freq() should output kHz not KHz

Message ID 20201008202324.51012-2-xypron.glpk@gmx.de
State Superseded, archived
Delegated to: Tom Rini
Headers show
Series lib: print_freq() should output kHz not KHz | expand

Commit Message

Heinrich Schuchardt Oct. 8, 2020, 8:23 p.m. UTC
In the International System of Units (SI) the prefix kilo is abbreviated as
'k' not 'K'. 'K' is the symbol for Kelvin.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 include/display_options.h | 2 +-
 lib/display_options.c     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--
2.28.0

Comments

Stefan Roese Oct. 9, 2020, 4:12 a.m. UTC | #1
On 08.10.20 22:23, Heinrich Schuchardt wrote:
> In the International System of Units (SI) the prefix kilo is abbreviated as
> 'k' not 'K'. 'K' is the symbol for Kelvin.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   include/display_options.h | 2 +-
>   lib/display_options.c     | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/display_options.h b/include/display_options.h
> index a0dabca2b8..049688e39e 100644
> --- a/include/display_options.h
> +++ b/include/display_options.h
> @@ -24,7 +24,7 @@ void print_size(uint64_t size, const char *suffix);
>   /**
>    * print_freq() - Print a frequency with a suffix
>    *
> - * Print frequencies as "x.xx GHz", "xxx KHz", etc as needed; allow for
> + * Print frequencies as "x.xx GHz", "xxx kHz", etc as needed; allow for
>    * optional trailing string (like "\n")
>    *
>    * @freq:	Frequency to print in Hz
> diff --git a/lib/display_options.c b/lib/display_options.c
> index ea9977cc18..b2025eeb5c 100644
> --- a/lib/display_options.c
> +++ b/lib/display_options.c
> @@ -54,7 +54,7 @@ void print_freq(uint64_t freq, const char *s)
>   {
>   	unsigned long m = 0;
>   	uint32_t f;
> -	static const char names[] = {'G', 'M', 'K'};
> +	static const char names[] = {'G', 'M', 'k'};
>   	unsigned long d = 1e9;
>   	char c = 0;
>   	unsigned int i;
> --
> 2.28.0
> 


Viele Grüße,
Stefan
Tom Rini Oct. 23, 2020, 12:29 a.m. UTC | #2
On Thu, Oct 08, 2020 at 10:23:23PM +0200, Heinrich Schuchardt wrote:

> In the International System of Units (SI) the prefix kilo is abbreviated as
> 'k' not 'K'. 'K' is the symbol for Kelvin.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Stefan Roese <sr@denx.de>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/include/display_options.h b/include/display_options.h
index a0dabca2b8..049688e39e 100644
--- a/include/display_options.h
+++ b/include/display_options.h
@@ -24,7 +24,7 @@  void print_size(uint64_t size, const char *suffix);
 /**
  * print_freq() - Print a frequency with a suffix
  *
- * Print frequencies as "x.xx GHz", "xxx KHz", etc as needed; allow for
+ * Print frequencies as "x.xx GHz", "xxx kHz", etc as needed; allow for
  * optional trailing string (like "\n")
  *
  * @freq:	Frequency to print in Hz
diff --git a/lib/display_options.c b/lib/display_options.c
index ea9977cc18..b2025eeb5c 100644
--- a/lib/display_options.c
+++ b/lib/display_options.c
@@ -54,7 +54,7 @@  void print_freq(uint64_t freq, const char *s)
 {
 	unsigned long m = 0;
 	uint32_t f;
-	static const char names[] = {'G', 'M', 'K'};
+	static const char names[] = {'G', 'M', 'k'};
 	unsigned long d = 1e9;
 	char c = 0;
 	unsigned int i;