From patchwork Thu Oct 8 18:53:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1378831 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=Ayzca+NR; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4C6gMj3kvHz9sTK for ; Fri, 9 Oct 2020 05:53:37 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2CE8281BD2; Thu, 8 Oct 2020 20:53:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="Ayzca+NR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 42DE582313; Thu, 8 Oct 2020 20:53:28 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EB847801D8 for ; Thu, 8 Oct 2020 20:53:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1602183198; bh=HyT+UlkW0+oqvcrsZKunTD+uVIPJyKjM7RMyE1zBHmE=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=Ayzca+NR+EFj7ZAVxg2YfzwIDlDQnQuuTkOgWqx+PD00svlCaJWQAaqeUj1Ord3bs 4M3Hu0NMulnBZgBBTJSHCJaI9SaMv74rH3HhrJ3uIV4tfQ/TD5J7HaSNFE5by7A/cq 0Y787w8kANzgV4cEV3xSaSG1WSQrZAxECWdA0n2o= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([178.202.41.107]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MWzjt-1jtFPb285p-00XKNG; Thu, 08 Oct 2020 20:53:18 +0200 From: Heinrich Schuchardt To: Tom Rini Cc: Simon Glass , AKASHI Takahiro , Heiko Stuebner , Jan Kiszka , Daniele Alessandrelli , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] lib: rsa: superfluous initialization in rsa_verify() Date: Thu, 8 Oct 2020 20:53:13 +0200 Message-Id: <20201008185313.6833-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:azLfU0qYHIrvoW6vv3MfwIJGdZ3UXKlBmqndgv0cQJ5kJboRn+4 wnIw+Oh+rl03wWWa/ftgrVlRP5RnN0YHPKi6qZt11U1nOnSqCOB5d8n1VywLZZkDeEcuhA0 yDEk+JYUsnp2N6bTMgjxhEPgwMKi1KfEOJqOYWXZhri07bH+A0+QEqWv3I1Pe0JGVObPny2 OxzpBBtlJAO8hXaXDm75g== X-UI-Out-Filterresults: notjunk:1;V03:K0:GiCx1Epn2bE=:QBEnwNfKw0V4u9y6vOeaWv Ob88eHgFgqaPN3q24SfkpCI/wYDHCeONmdFlWXQjgDxldlkO8Q7mR0vjbbUZOk1wp0wm9zZbg u/NZbyHRAmQsnbUbo13DRA7noG9s6XvfjH+7nmM8UZaXNzLaF0e2eXqYNPWvYjyPIzgFTuvcy 5dxwHWT1LRf0W7lXbqUUejMUyHG/s32ohExuQnl/9qQPl+GSbVFKObqx/3IfN4vmN7Gbc3k6O hzfyWAXBrOxShCPN5WaWCvvoG5V8Jes1lyUPXfPSOCm8e3fudm5PhNQLl1l2vOR5/At8riHF5 vaFLKwC+YFr7GjcQWMyB1Ym1DUx9jMNloZ7dCHmJID9KP77TdV2dcGTbanSDS2cvNbVcUfpM7 5spkK1meDif6zLKSWbLubB/zbRYotMiqdXB1xaYgGY7DPOI6TS0miV0uiWEL65ESPLMTZEemI chTagHiLU3DH3AHDRRb9Ja2v/q7Kbr2RsCRf/1Msux2vjoH3yvsBCQFvjT6ogAVsobpupk9hI OvzG318seCm+RKInnozySdE/hEQwKCjkahy1q5YWwULFtus4TUB5LKaVMCx+tCw+VTZpg8jom foj8x6u8WP0xvsxJ0KmTxxHw0aq86bfrHWoYStgUfPmpaF7y6GQ7r+eeT7J2P4e8d3aVPj6si QDmgAO5qdz+M/bn9RQirPVgcaA/xxkMln/Q0nSkU0z2xOkaHGh6xjfIYFo9XjgDV9uUt5He7A IsUwQMqIz8A5itrRzTmJOzP1U9TeBXzoYgSIYX2fGPlj86T7qUUqGAtSdIcPwiioCc4J9I0e7 KCgBvl4KuglyvZ8nnnNNrKJbtJKio9U28CvD1JKP+3NIeR8lE3Z8w5lywQRjp6rnYZWsDhpqP 8zIqmNsx9ImGGvrjqNZFbdhCLmlO95ZxjGvKR0EcjYT5mex6l4kBeie1rXvkTrOzwydorra/G KlVwG02spD9e4IUAegwv8THWsaePOvy75l77z30AtJKGQm3gEZPJEYRcmMNDJKaq6ArhTrvV8 Er/ZtMZsv1dkJI2sMvqrFaHJQuIg0PeCklIv7vIzuFrXC0S1P4V3QSbnmY99/YlmZdEiXRm9X b+DzmZEN4IIXcTj3D8eGZ3rISCeV1PIXNgdHZsAQPqD+vWDS0zUtR3i2JObaA8vJg26Lz2+kM jE4gBAnTV1E8iuy/MAv3NQd9UgwYrFWI4MNQc/Nhc3rcGAKln/5XEZbeLV0YvU6nnvIWRU1hf dpHtyCAgR5Oxp29RBH3bZMOSfJWl8PFFvz7xXIQ== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean Remove initialization of ret with unused value. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- lib/rsa/rsa-verify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.28.0 diff --git a/lib/rsa/rsa-verify.c b/lib/rsa/rsa-verify.c index 2057f6819d..be55a4376f 100644 --- a/lib/rsa/rsa-verify.c +++ b/lib/rsa/rsa-verify.c @@ -540,7 +540,7 @@ int rsa_verify(struct image_sign_info *info, { /* Reserve memory for maximum checksum-length */ uint8_t hash[info->crypto->key_len]; - int ret = -EACCES; + int ret; /* * Verify that the checksum-length does not exceed the