| Message ID | 20200917112308.7736-2-vigneshr@ti.com |
|---|---|
| State | Accepted |
| Commit | 8995a86cd6fa6e189c03a638da4a8ef9755d3738 |
| Delegated to: | Stefan Roese |
| Headers | show |
| Series | mtd: cfi_mtd: Add DMA support for reads | expand |
On 17.09.20 13:23, Vignesh Raghavendra wrote: > Caller would need gracefully handle failures of dma_get_device(), > therefore reduce pr_err() to pr_debug() when DMA device is not found. > > Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan > --- > drivers/dma/dma-uclass.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/dma-uclass.c b/drivers/dma/dma-uclass.c > index 8cbb364042..50403148d6 100644 > --- a/drivers/dma/dma-uclass.c > +++ b/drivers/dma/dma-uclass.c > @@ -219,8 +219,8 @@ int dma_get_device(u32 transfer_type, struct udevice **devp) > } > > if (!dev) { > - pr_err("No DMA device found that supports %x type\n", > - transfer_type); > + pr_debug("No DMA device found that supports %x type\n", > + transfer_type); > return -EPROTONOSUPPORT; > } > > Viele Grüße, Stefan
On 17.09.20 13:23, Vignesh Raghavendra wrote: > Caller would need gracefully handle failures of dma_get_device(), > therefore reduce pr_err() to pr_debug() when DMA device is not found. > > Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> Applied to u-boot-cfi-flash/master Thanks, Stefan > --- > drivers/dma/dma-uclass.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/dma-uclass.c b/drivers/dma/dma-uclass.c > index 8cbb364042..50403148d6 100644 > --- a/drivers/dma/dma-uclass.c > +++ b/drivers/dma/dma-uclass.c > @@ -219,8 +219,8 @@ int dma_get_device(u32 transfer_type, struct udevice **devp) > } > > if (!dev) { > - pr_err("No DMA device found that supports %x type\n", > - transfer_type); > + pr_debug("No DMA device found that supports %x type\n", > + transfer_type); > return -EPROTONOSUPPORT; > } > > Viele Grüße, Stefan
diff --git a/drivers/dma/dma-uclass.c b/drivers/dma/dma-uclass.c index 8cbb364042..50403148d6 100644 --- a/drivers/dma/dma-uclass.c +++ b/drivers/dma/dma-uclass.c @@ -219,8 +219,8 @@ int dma_get_device(u32 transfer_type, struct udevice **devp) } if (!dev) { - pr_err("No DMA device found that supports %x type\n", - transfer_type); + pr_debug("No DMA device found that supports %x type\n", + transfer_type); return -EPROTONOSUPPORT; }
Caller would need gracefully handle failures of dma_get_device(), therefore reduce pr_err() to pr_debug() when DMA device is not found. Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> --- drivers/dma/dma-uclass.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)