From patchwork Mon Sep 14 09:00:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1363440 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=NFa8P4vu; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BqgLc2Xw5z9sT6 for ; Mon, 14 Sep 2020 19:00:37 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1573481281; Mon, 14 Sep 2020 11:00:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="NFa8P4vu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F298581996; Mon, 14 Sep 2020 11:00:29 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 38189808B2 for ; Mon, 14 Sep 2020 11:00:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1600074024; bh=hk2QmWUieVx1oi8R3R9kLC4gfNwnD4AxOKEFjvDiE7c=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=NFa8P4vugY3CLMtL6vHgPoT45kG/Vjrf8ME7bAsfas+djGZ+S6RELR5RgPzKNPUEF bH0yMoiNJPDS6vmAP/MwXuv5J8c0pknaQi4jyWJf4mP9PDts0TG/bek+DctRUIObcP Tx0/EJ1iJThRuz2oo9yHTgZSUXH3D0FPlXtdTaKs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([178.202.41.107]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mnaof-1kyTXm3cbl-00jXNo; Mon, 14 Sep 2020 11:00:23 +0200 From: Heinrich Schuchardt To: Joe Hershberger Cc: u-boot@lists.denx.de, Heinrich Schuchardt , Simon Glass Subject: [PATCH 1/1] net: use log_err() for 'No ethernet found' message Date: Mon, 14 Sep 2020 11:00:18 +0200 Message-Id: <20200914090018.162698-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:lI8Q98lcMo3u8ed9839b86L10z6xoEBJTnnsJ238bmH1yiJLGct uATDd6j3NUJ+tVsuUw6aW5XCNgYe7pi+B0f0Q41x1w2xHrQUhGJAQVhyP1vZlf5E5nl3zFm eYezZgyfFX0Iq/Kh+bgcka2Se7JgOVOub3LnmugkaLdTf/gWCa5hZeqic3NMZD/bEU5uuBj 9KqnJY+SDqhMCwl7kcltQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:Qx1ALLoXH7w=:6QsGZ4ISfaWE+7m+Cd6PPm aCbhR5R5wImEKDNVg1lGkZ199yO7xFdYcd1iZpHMDa3xZUnKdF+nip+/V0Dnkqpe2BocyMHq5 7knDv7WpngC4+XEcew5hdXdS+ZXO5GjaxY9DL2WVjqI89krhivE1YT6uvX3gli/Ketbex/pU2 9EYb5caf4dHtlUZX8VUM1PSILXIQABWUxgqpFHoL77ypRXcINCa62UJNH/Xs/trZR4NSCbN3s D+K+0KtaYYDecezTZDLaYdjOqQ+BbG1y+AOVpOim/uz4G6jxJr7RVNPTMpAAWGGFPuq6Msfvn 6xerlDczxkt5Be9jhq3Y4svsFgiica2PymRZ09M5zxH1WZ7C+SPbmpT+I5qzjoE5zh48HR76g 7TkM25VRtNovvjWTS4QC7bHmyNpmUE4a0sqiHvKs0FJUBIpKMF2jLxuZH7xqEr19cY4DbkUjb +Ep7+xJ4M6RLxwzV+QDQwOVQOOzd2IVNulRvbIjS0rVUZioa9c96gCSYwof8EVNKcsZFIopb1 7zO4fTP4lXnSKgdhjtIZEAqlyAryweW9u7eBxP9i/84qzcCzI5DnMJinCUHPysGhVzpv0zW9s ux1EkFGbzdiGKw6exl0GZIN3SFqNV7rsWAmY2f2Rqz5CfkQbMxs7LFKaTJRnjM2FSQKvB1oaS /GvXsp+Aei0nQvW2q/ipErtk8vZHmzVIEnsT2xMSVLQXsgSIcdkgLZB0Mi8iiichhopVLnA8j be0Ngisf8piggw8OrxLzTWCCA+bIrZ8rr+uzwJL0W2vBwWiciWJxEKZQqN+rMxCd4Bg2/xvsU GUmyNcCgfy59uMH/0Xy/zSRkulsyAtGrryuHqkb9vMs+TO+ZmR3++m+N25nlZytr3MTPBxy10 VTvil8hLRFtP6XXrBnvL5i0k4zz79gWzK7NHPxSwq4+2i7sBXphoenZETrSpEdhgqL/R4Be5h OHzBGsb6Bmn22RccnY5uaU4el51BO6lUvWdG3Dj8Ov34095W7L37ARq4A1WiL/dQAwlxlevXB YCefDNIRshKcGHFopOuLBiiiIHVpIuXC6dmUKkocj63ZmjeT2sVbcb+i9DEpvjRi7CazdDGPt glRfPrciqY20uCug52o1FJO4cVlaVBVyGHpsfd5OkOlYOvOwogColZHPvg9Co6j8Hmq62B66e D1wjXVfyv5r8allJNEEvGZF/P9DWuecr3wkuONtidjjZDPyAV6nmMl88GCXFi1ebPhrwaHi4K xIs3nxHDdt7iKFuyx4sjN8hQtEkAM3YSqJ575cQ== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean Write the 'No ethernet found' message via the log drivers. This allows suppressing it during output via the syslog driver. This fixes the problem reported in: [PATCH 0/4] log: Fix the syslog spam when running tests https://lists.denx.de/pipermail/u-boot/2020-September/426343.html Reported-by: Simon Glass Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- net/eth-uclass.c | 6 +++--- net/eth_legacy.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) -- 2.28.0 diff --git a/net/eth-uclass.c b/net/eth-uclass.c index 0d9b75a9a2..396418eb39 100644 --- a/net/eth-uclass.c +++ b/net/eth-uclass.c @@ -273,7 +273,7 @@ int eth_init(void) if (!current) { current = eth_get_dev(); if (!current) { - printf("No ethernet found.\n"); + log_err("No ethernet found.\n"); return -ENODEV; } } @@ -414,7 +414,7 @@ int eth_initialize(void) */ uclass_first_device_check(UCLASS_ETH, &dev); if (!dev) { - printf("No ethernet found.\n"); + log_err("No ethernet found.\n"); bootstage_error(BOOTSTAGE_ID_NET_ETH_START); } else { char *ethprime = env_get("ethprime"); @@ -449,7 +449,7 @@ int eth_initialize(void) } while (dev); if (!num_devices) - printf("No ethernet found.\n"); + log_err("No ethernet found.\n"); putc('\n'); } diff --git a/net/eth_legacy.c b/net/eth_legacy.c index 992d1880bf..6e0c058761 100644 --- a/net/eth_legacy.c +++ b/net/eth_legacy.c @@ -261,7 +261,7 @@ int eth_initialize(void) } if (!eth_devices) { - puts("No ethernet found.\n"); + log_err("No ethernet found.\n"); bootstage_error(BOOTSTAGE_ID_NET_ETH_START); } else { struct eth_device *dev = eth_devices; @@ -319,7 +319,7 @@ int eth_init(void) struct eth_device *old_current; if (!eth_current) { - puts("No ethernet found.\n"); + log_err("No ethernet found.\n"); return -ENODEV; }