From patchwork Thu Aug 20 18:29:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1348552 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=horrWH0x; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BXY9D4052z9sPB for ; Fri, 21 Aug 2020 04:30:08 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2BF5F8236B; Thu, 20 Aug 2020 20:30:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="horrWH0x"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A725D8236C; Thu, 20 Aug 2020 20:29:59 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3778C82365 for ; Thu, 20 Aug 2020 20:29:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1597948193; bh=HyT+UlkW0+oqvcrsZKunTD+uVIPJyKjM7RMyE1zBHmE=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=horrWH0xmN/KD7zIrtE58trX9fRqrjeAOKarPFJiSzmAATYf8e6apiRg7IRLh5nRe iOs9afw8Hi+r+Na+8gSgkn0zGJh77t8PX1HDamxfShH+E2wTt2RXWqn0kqUSOi6Akp rtsKd44yYkATq6XrdAI/x4fOCo4xu0b2IH2YWna8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([178.202.41.107]) by mail.gmx.com (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MPXd2-1kLQWo3mF8-00Mes2; Thu, 20 Aug 2020 20:29:53 +0200 From: Heinrich Schuchardt To: Tom Rini Cc: Simon Glass , Heiko Stuebner , AKASHI Takahiro , Daniele Alessandrelli , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] lib: rsa: superfluous initialization in rsa_verify() Date: Thu, 20 Aug 2020 20:29:47 +0200 Message-Id: <20200820182947.15970-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:hx+TiG/AUPjXMRlCYBiXnRp1LIhj9cNrogJIj9cqy+GORVTJg0H YbbNltcIY7wXDfYj3SH45BmqaWUV53XygbWfiWmUcD96LBQq2dSRlEEgWIMIYOPJbo/yZWX O+Hx+T9Bw+5QYFCu5yaNNoQKUwpMg/Jt8N4OgP+Qco91gQGBcj4z2zxmNg7c/Nnaw1DZfVy LqUCCpLHky5+mqXBzsqcQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:WT7ESNlKmnk=:e0ximLj3q51jI5RFF/vfwa Mfuifx+Qxk+mm2QpNfJVoh+7HpiNROAoIEz26fsjGocdQWPYWpgW6gBj3BoGYYv0VJ35OgqUm uq8KhhDB3B0U9pt2BORDn++g2l4oomI5vunZvT8H0vKGdBDuHIBZF5adleg+DRt5HVGx1gM+T /qPThkkrA8voMnXOucIcphspb7TTfdVw42G98doA9NS0sASjJDQAoWGkQWtapn1wcS+NijOYL yZS4HG0xXUqh8moilUW7yPenVqsWp30NNq70NNrxSCRBCfMejgJLPsJoXzYBEIHSiQGfvCdKg Qxz/99jhlngDS46ofIHqUoFYF8GQOCT61DRLz0XbdvaeRaA7BMab2JqzHKR4xcxXTLTmLatYW WZ63qJbZbjg+FhEFKg/ektqdp5nXvqbUITm17t1uqsEcTLMLndjKfwMidQyiGt876xRTvpE3z LmwVK3Z122bu7EGpliKzdFy6av1tONvk6VCUrCWH4X06yVKXJ7z5aokRq4xN78/2URWDop41a Tic0aeZo/k9sIzmVBRhBoUCr3Uxi9WE83TcASZ82BgXIQbaCHQfMm1314mHBhVMQu5KJXBjNg 7hS1+q4PUtvWvfSnFJ0zt3mfybyaoXH2Z3BEFkV8PtgPYJU3cfvKDVqjgaXNlpdp4/CHpUMoU 2dbixqjUcIV9qOxdrdoR6/5u5zfLOsou1QN4AW3DZUMXqdl4TCgpL9K5SM521IwwjqfePteG/ yAj0F+rMo9dN5Jl5LJP55fd0R4czrsLLDk2ifXwukY476yderpTNT/x4rtLR98acYDCvSJXNY vigxp0CMC9+Kbb5dnbfE0wz27wqRMqCf0OS/oz5Bz9FzTtcXYRuWX5lcxy57uSTXzAKYSjSWX NDjlibFGEAiVnEVteYdHusnnheiIYHI58Ah8W9NXKTYy3NZpUk4mX51yw3nLHd6E3GkIUfYbT Ja1/x/tIfL0UeCSXpmiEh19TBKqlGjBC0cj6JnwwgFJnOMzuVaUqW4iDpspIVkk2hLgsOU6+l DTLjZnCPKNxxY0zDcnXmlP7h8I+Hi0apY8EZDxKpdlZK/9a5qhTRAG1lLtfSQ95VGVTlze8YA 44w9X5WFTxtGE6R+McS3iqNG42AXzKDOmywppXR0m2GQguxMotqguUDzbZRnEufoQZfgI+Ocr rqhlUcSoQL8sdOc9Hw65lFiifRX88FH7BZFFxUiRpizhrGL1WyF3MVCITL6cZsEwGiI77im2V 3ZSOlQBpdn0IXszw2f1n+BN/aVpNMeENe1uQong== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean Remove initialization of ret with unused value. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- lib/rsa/rsa-verify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.28.0 diff --git a/lib/rsa/rsa-verify.c b/lib/rsa/rsa-verify.c index 2057f6819d..be55a4376f 100644 --- a/lib/rsa/rsa-verify.c +++ b/lib/rsa/rsa-verify.c @@ -540,7 +540,7 @@ int rsa_verify(struct image_sign_info *info, { /* Reserve memory for maximum checksum-length */ uint8_t hash[info->crypto->key_len]; - int ret = -EACCES; + int ret; /* * Verify that the checksum-length does not exceed the