From patchwork Thu Aug 20 17:57:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1348540 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=Qi2qIpEy; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BXXSB03mZz9sRK for ; Fri, 21 Aug 2020 03:58:01 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 17C228236B; Thu, 20 Aug 2020 19:57:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="Qi2qIpEy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CA3998236C; Thu, 20 Aug 2020 19:57:56 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 73EFA82365 for ; Thu, 20 Aug 2020 19:57:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1597946271; bh=QHHu+NbQMIT7JfFbRGqDb/ROc0l094nLcJe7H5Db4+E=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=Qi2qIpEyxm4uCBndMpyP6tOXpWN4lS/8FO20Atsv0cgPd7rDPSJ4q5ABWZuYsAYFv +HF46s+MRof70exZpGt+hdVE+0jvZq725BxKG5kMTWGs0DHGA1epVWZMuZNvQLBbNB gK+DMtzpXgH72FWpVONFFS2B1RH3JuHorETvaxDs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([178.202.41.107]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mdvqg-1kgEcz2J1C-00b1RW; Thu, 20 Aug 2020 19:57:51 +0200 From: Heinrich Schuchardt To: Tom Rini Cc: Simon Glass , Rasmus Villemoes , Marek Vasut , Sean Anderson , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] lib/hashtable: remove superfluous check Date: Thu, 20 Aug 2020 19:57:45 +0200 Message-Id: <20200820175745.10582-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:5xznUsIsCK/OierwN5fHJgkxmQJs9AO/tXrZIFscjC96P2CDIYA 6nmns0GcZlGHWK5xUIfJZ/11VVWVaNtsfESgihFAPyRsM/KgbVTwuuZNzwAZTenKJ0HBkyU gvObssByCUlg6dOH+invvxi/k+tz7Q2/in1VIRYtx5ugd5INaHhEjddR5WUBiK+njfocWi1 WyoXCh3vfXToWmcxz8Yrg== X-UI-Out-Filterresults: notjunk:1;V03:K0:2g/epAOQG8g=:JhmbL3gx3lUwMHB5d73KeN ewSx2ITqnu/g2MBslomyzht4VQ/txrvMksq8JzceATEEXgnSoaTo83/dowzbd7d321odbsdtY cenSgg4PO3uI6kukwI/f+rAusbR+UEljj++NDfIq9reJIbuqPzYDuZpQau/CJHC95ZXXyDRZu a6DtFxQzMAD1e8l4ZRwcdgttm2pyKCXrCJzUNCK4dNdpXZe3p2xI3TK5LwIzbMNfqApdN4xU3 JNBAeSx25znXjBszP6aS77dbqXai6Hf1E6jXPFYTEf9cIQJgPiLLVNkUSh35bPQuZocoh3EWt 2gmP/q+7jGuZBmW6Tcvz3ps8ZI2zukz2pyiLTqbBGQTNwuvuSpnCQtEEwX3hTvqkH0bveZWon mDCxm6IDinqM/61R0C2ONHxCh/6cB6SOxsmXc+uBv8il/gFZhof+VQQcoOjQDK116MS60W+DX XmYQQZrOwa5MwoZEyOo22yqioS9+SY3wjoyqs2WOd4UEFZsiVbibRKSsJENDWW9LdfABIN74W W3hGBWCVTt0CWe8dljDjJ10FYlOR5AobNrSOlQrLPFKWYcHNTrjtKWpjFLFdho4E05eNJokjM 55E1ONg2XYNN0/nqXgTUG1LDpySOniXjNv+pxRsXDbdDnnTvnt9/NjKUg60LuBP+aNOk4Rydf aKGwB8JhBRAnISrBosyiWbA0mCQ57q4HF3sewpTZrsN8p5cV2+NUrVcQGpDsd940VgRoiVmFn ZhHGboLlosGh7DgF+wrB5YrwBCyLj6T2EH/O7wvgkVtXEp5X8urn78Q8xIAn+dKJ8XJifgctJ oWZ6LW6RT2Nu7r1Y/z0Ju+HeRBopzZfFJkgqLaIewIhR9tbg0uMzlICckf9PqszoTb4SL+rSc NISskiGRCjMlO/ql8BEZImxjkJdZxSnN3XG/0ZgZxb8BGutc/z3kE3dQ+NAUo1twzfpG3ZOKV s7xLE9gHPDgVD0oISTE17u51HNpv5kpLIVcXtFoUV7z3vwhhmTT7C3S6S6u61ypu9jhhrqUvk 1B6471sit+akaqv9yzfDLtfOg3zLUW2/QRr+aQ44GouIZ9Y2HKzW/8DnCrBOZqmdqppEuYfjy wIgSXXEbBdrEXdLCJ99R29VN4O4hH/iknor1y3raUq41YOQkpYJu4uumJq3TGss0wsd7BwcRf JjJx7y5pskF92JSuK2rhqyTIE2n22WaQkq9XmcEEjhz1nGViXBJIW4YAncZF48vdeinChOh/X gTMDxaTyxGwyjGWwr0CK6PnK5Ai2LskQrGh2MGw== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean We assign first_deleted = 0. There is no need to check its value without any further assignment in between. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- indicated by cppcheck --- lib/hashtable.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.28.0 diff --git a/lib/hashtable.c b/lib/hashtable.c index 4a8c50b4b8..7c08f5c805 100644 --- a/lib/hashtable.c +++ b/lib/hashtable.c @@ -324,8 +324,7 @@ int hsearch_r(struct env_entry item, enum env_action action, */ unsigned hval2; - if (htab->table[idx].used == USED_DELETED - && !first_deleted) + if (htab->table[idx].used == USED_DELETED) first_deleted = idx; ret = _compare_and_overwrite_entry(item, action, retval, htab,