diff mbox series

configs: odroid-c2: enable HDMI output

Message ID 20200722150404.2834-1-linux.amoon@gmail.com
State Superseded, archived
Delegated to: Neil Armstrong
Headers show
Series configs: odroid-c2: enable HDMI output | expand

Commit Message

Anand Moon July 22, 2020, 3:04 p.m. UTC
Enable options to permit HDMI output on Odroid-C2 GXBB boards.
Enable VPU Power Domain.
Enable ADC and USB_KERBOARD.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 configs/odroid-c2_defconfig | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Neil Armstrong July 23, 2020, 7:43 a.m. UTC | #1
The subject should be: "configs: odroid-c2: update for HDMI output, ADC & USB keyboard"

Can you resend ?

On 22/07/2020 17:04, Anand Moon wrote:
> Enable options to permit HDMI output on Odroid-C2 GXBB boards.
> Enable VPU Power Domain.
> Enable ADC and USB_KERBOARD.
> 
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
>  configs/odroid-c2_defconfig | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/configs/odroid-c2_defconfig b/configs/odroid-c2_defconfig
> index f62e83a345..c80719abd6 100644
> --- a/configs/odroid-c2_defconfig
> +++ b/configs/odroid-c2_defconfig
> @@ -15,6 +15,7 @@ CONFIG_MISC_INIT_R=y
>  # CONFIG_DISPLAY_CPUINFO is not set
>  # CONFIG_CMD_BDI is not set
>  # CONFIG_CMD_IMI is not set
> +CONFIG_CMD_ADC=y
>  CONFIG_CMD_GPIO=y
>  CONFIG_CMD_I2C=y
>  # CONFIG_CMD_LOADS is not set
> @@ -26,6 +27,7 @@ CONFIG_OF_CONTROL=y
>  CONFIG_DEFAULT_DEVICE_TREE="meson-gxbb-odroidc2"
>  CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>  CONFIG_NET_RANDOM_ETHADDR=y
> +CONFIG_SARADC_MESON=y
>  CONFIG_DM_I2C=y
>  CONFIG_SYS_I2C_MESON=y
>  CONFIG_DM_MMC=y
> @@ -38,6 +40,8 @@ CONFIG_MESON_GXBB_USB_PHY=y
>  CONFIG_PINCTRL=y
>  CONFIG_PINCTRL_MESON_GXBB=y
>  CONFIG_DM_REGULATOR=y
> +CONFIG_POWER_DOMAIN=y
> +CONFIG_MESON_GX_VPU_POWER_DOMAIN=y
>  CONFIG_DM_REGULATOR_FIXED=y
>  CONFIG_DM_REGULATOR_GPIO=y
>  CONFIG_DM_RESET=y
> @@ -47,5 +51,12 @@ CONFIG_MESON_SERIAL=y
>  CONFIG_USB=y
>  CONFIG_DM_USB=y
>  CONFIG_USB_DWC2=y
> +CONFIG_USB_KEYBOARD=y
> +CONFIG_DM_VIDEO=y
> +# CONFIG_VIDEO_BPP8 is not set
> +# CONFIG_VIDEO_BPP16 is not set
> +CONFIG_SYS_WHITE_ON_BLACK=y
> +CONFIG_VIDEO_MESON=y
> +CONFIG_VIDEO_DT_SIMPLEFB=y
>  CONFIG_OF_LIBFDT_OVERLAY=y
>  CONFIG_SMBIOS_MANUFACTURER="Hardkernel Co., Ltd."
> 

With the new subject:
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

Thanks,
Neil
Anand Moon July 23, 2020, 7:58 a.m. UTC | #2
Hi Neil,

On Thu, 23 Jul 2020 at 13:14, Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> The subject should be: "configs: odroid-c2: update for HDMI output, ADC & USB keyboard"
>
> Can you resend ?
>
> On 22/07/2020 17:04, Anand Moon wrote:
> > Enable options to permit HDMI output on Odroid-C2 GXBB boards.
> > Enable VPU Power Domain.
> > Enable ADC and USB_KERBOARD.
> >
> > Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> > ---
> >  configs/odroid-c2_defconfig | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/configs/odroid-c2_defconfig b/configs/odroid-c2_defconfig
> > index f62e83a345..c80719abd6 100644
> > --- a/configs/odroid-c2_defconfig
> > +++ b/configs/odroid-c2_defconfig
> > @@ -15,6 +15,7 @@ CONFIG_MISC_INIT_R=y
> >  # CONFIG_DISPLAY_CPUINFO is not set
> >  # CONFIG_CMD_BDI is not set
> >  # CONFIG_CMD_IMI is not set
> > +CONFIG_CMD_ADC=y
> >  CONFIG_CMD_GPIO=y
> >  CONFIG_CMD_I2C=y
> >  # CONFIG_CMD_LOADS is not set
> > @@ -26,6 +27,7 @@ CONFIG_OF_CONTROL=y
> >  CONFIG_DEFAULT_DEVICE_TREE="meson-gxbb-odroidc2"
> >  CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> >  CONFIG_NET_RANDOM_ETHADDR=y
> > +CONFIG_SARADC_MESON=y
> >  CONFIG_DM_I2C=y
> >  CONFIG_SYS_I2C_MESON=y
> >  CONFIG_DM_MMC=y
> > @@ -38,6 +40,8 @@ CONFIG_MESON_GXBB_USB_PHY=y
> >  CONFIG_PINCTRL=y
> >  CONFIG_PINCTRL_MESON_GXBB=y
> >  CONFIG_DM_REGULATOR=y
> > +CONFIG_POWER_DOMAIN=y
> > +CONFIG_MESON_GX_VPU_POWER_DOMAIN=y
> >  CONFIG_DM_REGULATOR_FIXED=y
> >  CONFIG_DM_REGULATOR_GPIO=y
> >  CONFIG_DM_RESET=y
> > @@ -47,5 +51,12 @@ CONFIG_MESON_SERIAL=y
> >  CONFIG_USB=y
> >  CONFIG_DM_USB=y
> >  CONFIG_USB_DWC2=y
> > +CONFIG_USB_KEYBOARD=y
> > +CONFIG_DM_VIDEO=y
> > +# CONFIG_VIDEO_BPP8 is not set
> > +# CONFIG_VIDEO_BPP16 is not set
> > +CONFIG_SYS_WHITE_ON_BLACK=y
> > +CONFIG_VIDEO_MESON=y
> > +CONFIG_VIDEO_DT_SIMPLEFB=y
> >  CONFIG_OF_LIBFDT_OVERLAY=y
> >  CONFIG_SMBIOS_MANUFACTURER="Hardkernel Co., Ltd."
> >
>
> With the new subject:
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>
> Thanks,
> Neil

Thanks for your review comments.
Ok I will resend with a new subject.

-Anand
diff mbox series

Patch

diff --git a/configs/odroid-c2_defconfig b/configs/odroid-c2_defconfig
index f62e83a345..c80719abd6 100644
--- a/configs/odroid-c2_defconfig
+++ b/configs/odroid-c2_defconfig
@@ -15,6 +15,7 @@  CONFIG_MISC_INIT_R=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_CMD_BDI is not set
 # CONFIG_CMD_IMI is not set
+CONFIG_CMD_ADC=y
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
 # CONFIG_CMD_LOADS is not set
@@ -26,6 +27,7 @@  CONFIG_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="meson-gxbb-odroidc2"
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_SARADC_MESON=y
 CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_MESON=y
 CONFIG_DM_MMC=y
@@ -38,6 +40,8 @@  CONFIG_MESON_GXBB_USB_PHY=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_MESON_GXBB=y
 CONFIG_DM_REGULATOR=y
+CONFIG_POWER_DOMAIN=y
+CONFIG_MESON_GX_VPU_POWER_DOMAIN=y
 CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_DM_REGULATOR_GPIO=y
 CONFIG_DM_RESET=y
@@ -47,5 +51,12 @@  CONFIG_MESON_SERIAL=y
 CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_DWC2=y
+CONFIG_USB_KEYBOARD=y
+CONFIG_DM_VIDEO=y
+# CONFIG_VIDEO_BPP8 is not set
+# CONFIG_VIDEO_BPP16 is not set
+CONFIG_SYS_WHITE_ON_BLACK=y
+CONFIG_VIDEO_MESON=y
+CONFIG_VIDEO_DT_SIMPLEFB=y
 CONFIG_OF_LIBFDT_OVERLAY=y
 CONFIG_SMBIOS_MANUFACTURER="Hardkernel Co., Ltd."