From patchwork Mon May 25 11:39:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sylwester Nawrocki X-Patchwork-Id: 1297301 X-Patchwork-Delegate: matthias.bgg@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256 header.s=mail20170921 header.b=J3sWpItF; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49VwBW5Bcfz9sSg for ; Mon, 25 May 2020 21:40:19 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D4F29819AF; Mon, 25 May 2020 13:40:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="J3sWpItF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EDDA581784; Mon, 25 May 2020 13:40:14 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B262F813C6 for ; Mon, 25 May 2020 13:40:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=s.nawrocki@samsung.com Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200525114011euoutp01cb7c3d3fabbb175aefeebf5f53c76f6b~SQpGQxVv11437514375euoutp01M for ; Mon, 25 May 2020 11:40:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200525114011euoutp01cb7c3d3fabbb175aefeebf5f53c76f6b~SQpGQxVv11437514375euoutp01M DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1590406811; bh=y/xHx6cn6ZNuvX3V5jxpugf8Q65fZIBo5wp4jEitdVo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J3sWpItFOx9VTDLrMYIPILDWMGpPAayKCfZh9R1ifbTTY8vXV1B1g4PUsMp84y2HR 0Y/KYFh17U9sWNonHJZzNU/tKUFhsO+sX24e0xWEFPcCGnluQwseoinNvmz+hdKyTi U61rzLfvO3JWw+BHOF0nKV1QY14mk2mN+IB7qGVI= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200525114010eucas1p1ada0741eb7e953bac68b9e8052a1e4ab~SQpF5Wz0m2811028110eucas1p1T; Mon, 25 May 2020 11:40:10 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id F2.BB.60679.A9EABCE5; Mon, 25 May 2020 12:40:10 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200525114010eucas1p138f9b8607f616720fd3b482dcb820dcb~SQpFguGWy0866408664eucas1p1U; Mon, 25 May 2020 11:40:10 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200525114010eusmtrp1f7d7536a293a4cf008495106bb1e1728~SQpFgBoHR1781117811eusmtrp1Q; Mon, 25 May 2020 11:40:10 +0000 (GMT) X-AuditID: cbfec7f4-0cbff7000001ed07-a8-5ecbae9aa433 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id F8.9B.08375.A9EABCE5; Mon, 25 May 2020 12:40:10 +0100 (BST) Received: from AMDC3061.digital.local (unknown [106.120.51.75]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200525114010eusmtip192f88702394a7e8b0b2ca6f668052819~SQpFA8Vyy2560125601eusmtip14; Mon, 25 May 2020 11:40:10 +0000 (GMT) From: Sylwester Nawrocki To: u-boot@lists.denx.de, mbrugger@suse.com Cc: marex@denx.de, bmeng.cn@gmail.com, james.quinlan@broadcom.com, sjg@chromium.org, nsaenzjulienne@suse.de, jh80.chung@samsung.com, m.szyprowski@samsung.com, b.zolnierkie@samsung.com, Sylwester Nawrocki Subject: [PATCH v4 1/9] usb: xhci: Add missing cache flush in the scratchpad array initialization Date: Mon, 25 May 2020 13:39:51 +0200 Message-Id: <20200525113959.11886-2-s.nawrocki@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200525113959.11886-1-s.nawrocki@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSbUhTYRjl9X7sat24TckXE4xViFZ+E1eU0Ii6/QhEIyhoNvXqJJ2yqWUS TaOlpps5w1opJoQ1NTPH0plhM9McSinGZptaSR9rCyMNnFF5vav+nec857zneR5eAhE2YUFE rqyIlcskeSLcDzU+X5nYo7tvEUcNte+lu693YfS1mnR6wKXBaatHhdGdzxwC2qUqB3SLdgGj jbo2nB5yXcboHwYjoN0DVYKkDYxubhxnbipfoUyzbhRl+nQOATNu7wWM2qAHTJdhGmV6LGUp xAm/xCw2L7eElUfuO+Undei/gMIG37Pf7gz6KMG4oBr4EpCKg50LLUg18COE1F0AbYYKb7EE YJ/tEuBUQuo7gOqOC9WAWHe86/Fq2gBcdGjwfwbb3DTOGXAqGtYOq9fNAdQuaOsw+nAihHIC +GFxAOMa/lQm9Eypce5VlNoJPVXhHE1SCdBZVQn48UJg+4NBhMO+VCIcezq7ngypVgGcbHuB 8KID0No9j/HYHzpHDN7dgqFFW4PyhosA1vS/EfBFHYBzIy3eiARon/CsT4FQYbDLFMnTydAx N4zyK2+CVvdmjkbWYL2xEeFpElaqhLx6B1zVN/rwOAheWfiN8piBX+0WlD+QBsBu/WOkDoTo /oe1AKAHgWyxIj+HVcTI2DMRCkm+oliWE5FZkP8QrH0ay6+RpV5g+plhBhQBRBtJusMiFmKS EkVpvhlAAhEFkKpDaxSZJSk9x8oL0uXFeazCDLYSqCiQjG39fFJI5UiK2NMsW8jK/3Z9CN8g JUg13QpunRp1O83io45sMvaqcv9MYvakJ+pIllValtbU1yqtL1a+z3xkCytPu2FzJ8Wdt5Ls mLF7dVtaiuGgqaj2aExu6PLr2eZPFa6ManFMpMbuJncXLR9Oh1qxfObJ7YaIxJeWpr7ct9v7 P8bHHwt1zQ+kriCjW5JVQfeOa0WoQiqJDkfkCskfL1ngvTADAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDLMWRmVeSWpSXmKPExsVy+t/xu7qz1p2OM9jySN5i44z1rBZTe+It 9r7pZ7O48auN1WLtkbvsFm/aGhktFkx+wmqxbdZyNovDb9pZLb5t2cZo8XZvJ7sDt8es+2fZ PGY3XGTxmDfrBIvHzll32T3O3tnB6NG3ZRWjx/otV1k8Np+uDuCI0rMpyi8tSVXIyC8usVWK NrQw0jO0tNAzMrHUMzQ2j7UyMlXSt7NJSc3JLEst0rdL0Mu4u+o1Y8EUzoqPSw8wNTCeZe9i 5OCQEDCReLSZuYuRi0NIYCmjxLNH65gh4lIS81uUuhg5gUxhiT/Xutggaj4xStxo3cMMkmAT MJToPdrHCGKLCOhKNPasYwEpYhb4wiix6cBiNpBBwgKJEjMf6oOYLAKqEr86tUDKeQWsJV51 djBCzJeXWL3hANhITgEbiVMH74HZQkA1M2c9Y5zAyLeAkWEVo0hqaXFuem6xoV5xYm5xaV66 XnJ+7iZGYMhvO/Zz8w7GSxuDDzEKcDAq8fBarDkdJ8SaWFZcmXuIUYKDWUmEt80dKMSbklhZ lVqUH19UmpNafIjRFOimicxSosn5wHjMK4k3NDU0t7A0NDc2NzazUBLn7RA4GCMkkJ5Ykpqd mlqQWgTTx8TBKdXAaJp/dobwlV2dHP3+wZvFuhsrNQN2TA9kKnm1R2Q+17/u6Ru3duZUCd4T Wjgzwv6RQa7MhUmcXmbOh3zOWH5YtSGo7jrHgZTT789r/5km0ii6tNn2X+O92L4vd9/UOd6w afa4smph8B+5Zennj/lr2ucy62h9kKl6vnp9kF/3lbRgnwZuoUktSizFGYmGWsxFxYkAW2eo 9o8CAAA= X-CMS-MailID: 20200525114010eucas1p138f9b8607f616720fd3b482dcb820dcb X-Msg-Generator: CA X-RootMTR: 20200525114010eucas1p138f9b8607f616720fd3b482dcb820dcb X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200525114010eucas1p138f9b8607f616720fd3b482dcb820dcb References: <20200525113959.11886-1-s.nawrocki@samsung.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean In current code there is no cache flush after initializing the scratchpad buffer array with the scratchpad buffer pointers. This leads to a failure of the "slot enable" command on the rpi4 board (Broadcom STB PCIe controller + VL805 USB hub) - the very first TRB transfer on the command ring fails and there is a timeout while waiting for the command completion event. After adding the missing cache flush everything seems to be working as expected. Signed-off-by: Sylwester Nawrocki Reviewed-by: Bin Meng Reviewed-by: Nicolas Saenz Julienne --- Changes since v1: - none. --- drivers/usb/host/xhci-mem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index 93450ee..729bdc3 100644 --- a/drivers/usb/host/xhci-mem.c +++ b/drivers/usb/host/xhci-mem.c @@ -393,6 +393,9 @@ static int xhci_scratchpad_alloc(struct xhci_ctrl *ctrl) scratchpad->sp_array[i] = cpu_to_le64(ptr); } + xhci_flush_cache((uintptr_t)scratchpad->sp_array, + sizeof(u64) * num_sp); + return 0; fail_sp3: