From patchwork Fri Apr 24 16:50:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sylwester Nawrocki X-Patchwork-Id: 1276512 X-Patchwork-Delegate: matthias.bgg@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256 header.s=mail20170921 header.b=G//3ix6O; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4980ZY5V1Vz9sSJ for ; Sat, 25 Apr 2020 02:52:05 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5D4FB8172F; Fri, 24 Apr 2020 18:52:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="G//3ix6O"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C4A8A818E7; Fri, 24 Apr 2020 18:52:00 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3157F817EA for ; Fri, 24 Apr 2020 18:51:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=s.nawrocki@samsung.com Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200424165156euoutp011100996defd948fec6f13dcca2939d82~Iz5cImax10083400834euoutp01o for ; Fri, 24 Apr 2020 16:51:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200424165156euoutp011100996defd948fec6f13dcca2939d82~Iz5cImax10083400834euoutp01o DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1587747116; bh=PZjUSXMFsjUIDr9T3+bgSZvwBGf6jEpoO1qISP/S9ao=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G//3ix6ONV1IzLc5O4We6C+RTEDKHuUGROHqUFdPrxFG1Ndpfcbv19nhbznhN+YY8 rg39G54XzxEmgSRtx3qMep4FHca15iMNSFcVr1g2XyjpeZtCIiROO4vjhraOtrxjT7 QSL15RBd/dtJ07YjCtzsiVA7gR/oyY1Gnzf2YoaA= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200424165155eucas1p22ba309ee23c55412113889ad5bee9a92~Iz5bpvISr0368203682eucas1p28; Fri, 24 Apr 2020 16:51:55 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 87.D5.61286.B2913AE5; Fri, 24 Apr 2020 17:51:55 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200424165155eucas1p10c63e5efe95bf1dc4a430442fcb23178~Iz5bPnvce0227802278eucas1p10; Fri, 24 Apr 2020 16:51:55 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200424165155eusmtrp1963a65075ea0316a2bdf59b56cdd90bc~Iz5bPATqm1224212242eusmtrp1C; Fri, 24 Apr 2020 16:51:55 +0000 (GMT) X-AuditID: cbfec7f2-ef1ff7000001ef66-c2-5ea3192b4cd9 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 7D.3F.08375.B2913AE5; Fri, 24 Apr 2020 17:51:55 +0100 (BST) Received: from AMDC3061.digital.local (unknown [106.120.51.75]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200424165154eusmtip2ef9135f012e59c9b80286a33e0d443b7~Iz5amuA6m1247612476eusmtip2V; Fri, 24 Apr 2020 16:51:54 +0000 (GMT) From: Sylwester Nawrocki To: u-boot@lists.denx.de, mbrugger@suse.com, marex@denx.de, bmeng.cn@gmail.com Cc: sjg@chromium.org, nsaenzjulienne@suse.de, jh80.chung@samsung.com, m.szyprowski@samsung.com, b.zolnierkie@samsung.com, Sylwester Nawrocki Subject: [PATCH v1 01/10] usb: xhci: Add missing cache flush in the scratchpad array initialization Date: Fri, 24 Apr 2020 18:50:03 +0200 Message-Id: <20200424165012.31915-2-s.nawrocki@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200424165012.31915-1-s.nawrocki@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGKsWRmVeSWpSXmKPExsWy7djPc7rakovjDDrnqVhsnLGe1WJqT7zF jV9trBZrj9xlt3jT1shosWDyE1aLbbOWs1kcftPOavFtyzZGi7d7O9kduDxmN1xk8Zg36wSL x85Zd9k9zt7ZwejRt2UVo8f6LVdZPDafrg5gj+KySUnNySxLLdK3S+DKODjvIHvBdY6KRQu2 sDQwTmPvYuTkkBAwkbh9ZwtbFyMXh5DACkaJlskdUM4XRolDu38yQTifGSVmX7vNBNNy/eZ3 FojEckaJrZPOM8G1vGzaAjaYTcBQovdoHyOILSIQIHHt5zRGkCJmgZWMEt/6zoElhAVSJR4/ vAdmswioSszqm84GYvMKWEv8eLIXap28xOoNB5hBbE4BG4nGs6/AVksITGaXmH7oHytEkYvE hWudLBC2sMSr41ug3pOROD25B6qhmVGiZ/dtdghnAqPE/eMLGCGqrCXunPsFtJoD6D5NifW7 9CHCjhIXNs1kBwlLCPBJ3HgrCBJmBjInbZvODBHmlehoE4KoVpH4vWo61M1SEt1P/kOd4yFx 48FeVkgI9TNKnG9+yDqBUX4WwrIFjIyrGMVTS4tz01OLDfNSy/WKE3OLS/PS9ZLzczcxAlPL 6X/HP+1g/Hop6RCjAAejEg9vxJFFcUKsiWXFlbmHGCU4mJVEeGNKgEK8KYmVValF+fFFpTmp xYcYpTlYlMR5jRe9jBUSSE8sSc1OTS1ILYLJMnFwSjUwFtpVZM17VclaksruJCB49eqSaykH tp23CVz3zu7bhggV1fNHD0xPKAwX3OjvJ3zZrTA9elH62/o/DD22Bc5HyiaLK96LCjbKjn/+ RSvfcZ1CytJGkyOWVy3Z7f93B17q/FXeoq6mUGjO8kmd+/2u0wqu6UfX9ga49vbeK5URfGOz 0ugJ40UlluKMREMt5qLiRACo4SvBKQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCLMWRmVeSWpSXmKPExsVy+t/xe7rakovjDG5s5bLYOGM9q8XUnniL G7/aWC3WHrnLbvGmrZHRYsHkJ6wW22YtZ7M4/Kad1eLblm2MFm/3drI7cHnMbrjI4jFv1gkW j52z7rJ7nL2zg9Gjb8sqRo/1W66yeGw+XR3AHqVnU5RfWpKqkJFfXGKrFG1oYaRnaGmhZ2Ri qWdobB5rZWSqpG9nk5Kak1mWWqRvl6CXcXDeQfaC6xwVixZsYWlgnMbexcjJISFgInH95ncW EFtIYCmjxOIztV2MHEBxKYn5LUoQJcISf651sXUxcgGVfGKUmHHvOTNIgk3AUKL3aB8jiC0i ECLx4ugVJpAiZoH1jBIbbsxkA0kICyRL/Pi5mQnEZhFQlZjVNx0szitgLfHjyV4miA3yEqs3 HAAbyilgI9F49hXUQdYS22Y+Z5nAyLeAkWEVo0hqaXFuem6xoV5xYm5xaV66XnJ+7iZGYIhv O/Zz8w7GSxuDDzEKcDAq8fBGHFkUJ8SaWFZcmXuIUYKDWUmEN6YEKMSbklhZlVqUH19UmpNa fIjRFOioicxSosn5wPjLK4k3NDU0t7A0NDc2NzazUBLn7RA4GCMkkJ5YkpqdmlqQWgTTx8TB KdXAqPav4WPwngPfMipspTa5a1VvnJ9xTcogrq2k/ujfrqCiSIaNk923zO/4v2T37r9PtVM3 e3B0TJ2wav97wW9zH85IenH+puCu3TpTnton8qokLjJXeCIgspX3fv5e3/SGowaeXZGNHf1N Mt+i/fb8/FfXuWzq12YRJv20vXOKj07Yd3PWh4kzIpVYijMSDbWYi4oTAeczg0CHAgAA X-CMS-MailID: 20200424165155eucas1p10c63e5efe95bf1dc4a430442fcb23178 X-Msg-Generator: CA X-RootMTR: 20200424165155eucas1p10c63e5efe95bf1dc4a430442fcb23178 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200424165155eucas1p10c63e5efe95bf1dc4a430442fcb23178 References: <20200424165012.31915-1-s.nawrocki@samsung.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean In current code there is no cache flush after initializing the scratchpad buffer array with the scratchpad buffer pointers. This leads to a failure of the "slot enable" command on the rpi4 board (Broadcom STB PCIe controller + VL805 USB hub) - the very first TRB transfer on the command ring fails and there is a timeout while waiting for the command completion event. After adding the missing cache flush everything seems to be working as expected. Reviewed-by: Bin Meng Signed-off-by: Sylwester Nawrocki Reviewed-by: Nicolas Saenz Julienne --- Changes since RFC: - none. --- drivers/usb/host/xhci-mem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index 93450ee..729bdc3 100644 --- a/drivers/usb/host/xhci-mem.c +++ b/drivers/usb/host/xhci-mem.c @@ -393,6 +393,9 @@ static int xhci_scratchpad_alloc(struct xhci_ctrl *ctrl) scratchpad->sp_array[i] = cpu_to_le64(ptr); } + xhci_flush_cache((uintptr_t)scratchpad->sp_array, + sizeof(u64) * num_sp); + return 0; fail_sp3: