| Message ID | 20200420141341.26514-1-rasmus.villemoes@prevas.dk |
|---|---|
| State | Accepted |
| Commit | cffedec2e8f7f11fbe31f4706a222d279cf19c1d |
| Delegated to: | Tom Rini |
| Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=prevas.dk Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=prevas.dk header.i=@prevas.dk header.a=rsa-sha256 header.s=selector1 header.b=PgX0e7WU; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 495TGb4XJnz9s71 for <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2020 00:14:31 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 632D781CD2; Mon, 20 Apr 2020 16:14:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=prevas.dk header.i=@prevas.dk header.b="PgX0e7WU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CF04481CD6; Mon, 20 Apr 2020 16:14:25 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20727.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::727]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 173F481CD2 for <u-boot@lists.denx.de>; Mon, 20 Apr 2020 16:14:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FTFBhcFNLPQjHRmvqct6J3wKLDNEV4nlwr8C/yI/G40VKVakF+iLuVaLxmYjgO4VCuXsrSJaHMzRMR5ttG+jWiLmmtTfeZORHYQtgLSVrBCB+EsV0MnT4LTruMMua8j6MaRHnOd06CIisyMhNj3pyUGK/xiIvhukrwhIzdLNp6AEIc2NaI+kkttEtyD8tMapOdQ5N9O/+wm6feZlJnoHkgayWv7SHfPrszGJ5dtsIhlASjM97oDZJfop7d6kyDunUcYBbMW8zF0QYXRjuRTE2cGMgQs44l0EDu/TanrOwq/dB92T1ouigbcWqCK7ZrMTHrcmFEccu7+KfMRbalYRyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OuRP58Nfbpwer5AZBirvEBU9C01pMzL6R44LdU3pgJk=; b=RLLILJwRWAkNyKbU0k50YNeLMzkqZTxLe72BzgnR4SXvmwDk8cpNilNdoXAnTOqVLO02CxVWx/ss8zGocSg3DM+qY3dvYUPaLInOElsRLKCZK8Q4cGcL92h7C10h01azdHRanK7zSSp+EgoUeQu+hh/xfc+v+n7cEgWW47gJuhpyIc96g0J2z1b/+DEV8nrOWtJU7u0aQ3ZC+7R+4gCM+ulFTjTkZSgMdnRxCpCceymYtrdoubakVbMhd2XNdGieRFpa6uG4L7Ou0EwsXzZ6ceCC0s0EbTNCshw1TBr3i+zy4VJ/mdWXwyuRPfx92jKvo2rq+NnV31qWS16OinNv6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk; dkim=pass header.d=prevas.dk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OuRP58Nfbpwer5AZBirvEBU9C01pMzL6R44LdU3pgJk=; b=PgX0e7WUKbEFOJvMq2+MaL/8M5HrJVOzlnuwf5RNu8s6oNbk0X4qxMNh/3+ERTTZ2m0ss3D/TaSYkhL3afV7iwJILUUZRjiRqrgMWK9IBbR15rIDNEZe6UBAqNbtDHUoDf8XwOT6vuwok99NvUSbFrXYSb2pLY3YzK7QaFkXa0A= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=rasmus.villemoes@prevas.dk; Received: from VI1PR10MB2765.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:803:e1::21) by VI1PR10MB2208.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:803:84::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25; Mon, 20 Apr 2020 14:14:19 +0000 Received: from VI1PR10MB2765.EURPRD10.PROD.OUTLOOK.COM ([fe80::f0ac:4e97:2536:faa]) by VI1PR10MB2765.EURPRD10.PROD.OUTLOOK.COM ([fe80::f0ac:4e97:2536:faa%7]) with mapi id 15.20.2921.030; Mon, 20 Apr 2020 14:14:19 +0000 From: Rasmus Villemoes <rasmus.villemoes@prevas.dk> To: u-boot@lists.denx.de Cc: Tom Rini <trini@konsulko.com>, Jagan Teki <jagan@amarulasolutions.com>, Rasmus Villemoes <rasmus.villemoes@prevas.dk> Subject: [PATCH] spi: mpc8xxx_spi: fix missing dev_err definition Date: Mon, 20 Apr 2020 16:13:41 +0200 Message-Id: <20200420141341.26514-1-rasmus.villemoes@prevas.dk> X-Mailer: git-send-email 2.23.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6PR02CA0023.eurprd02.prod.outlook.com (2603:10a6:20b:6e::36) To VI1PR10MB2765.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:803:e1::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from prevas-ravi.prevas.se (5.186.116.45) by AM6PR02CA0023.eurprd02.prod.outlook.com (2603:10a6:20b:6e::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Mon, 20 Apr 2020 14:14:19 +0000 X-Mailer: git-send-email 2.23.0 X-Originating-IP: [5.186.116.45] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 71408fa4-f852-4a12-dd90-08d7e5351de5 X-MS-TrafficTypeDiagnostic: VI1PR10MB2208: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: <VI1PR10MB2208408F731FA949546DCF5193D40@VI1PR10MB2208.EURPRD10.PROD.OUTLOOK.COM> X-MS-Oob-TLC-OOBClassifiers: OLM:949; X-Forefront-PRVS: 03793408BA X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR10MB2765.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(376002)(136003)(396003)(366004)(346002)(39850400004)(54906003)(52116002)(44832011)(66946007)(66556008)(478600001)(66476007)(4326008)(6486002)(6916009)(5660300002)(2906002)(1076003)(6506007)(956004)(316002)(86362001)(16526019)(2616005)(6512007)(8976002)(186003)(36756003)(6666004)(8936002)(81156014)(26005)(8676002)(107886003); DIR:OUT; SFP:1102; Received-SPF: None (protection.outlook.com: prevas.dk does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B+pnpAZTMNK+RhUP5n6J5na1rXqeV32324idYcq6mfRVrcyoJEc2hlAXZh8o0C9NDVcVil6j2tLX1EQUm3juTvtujySsp8DjtbzqUBDtaKca0F2c7nCT4LGItF7yMsujwzfegxXpclivkwvl6jqTqcl97qfWRldLsBMe65zQCT6cqsi8bTu081nXOfaNf8ZTJbZZawgKHcVFf69hcsdck6A4tZ6175f2KrcUB4Nxsx7JqrpjJZTXvzXJ/iISCY8koFxas++Z1G0dgIhlU2EsiCjQ1xWuTA4nbox2efI1Ureyz+i0rpbiSl2HALhNzn05hcFUYKYK7lSKo8I+6hJna676BBkcIPDdP7QNXjGhPE9T2GO9Yvuw6k65BDdqvMNHqzDRcH/Ivdb5O5qX4TiXAUS1L+EkYJy8giql/ci4DwvY3ypEk/l+7tFQGuf3PRFN X-MS-Exchange-AntiSpam-MessageData: 6mNr11oUWeGIUYU1rUej35GlF7NcwYH/AgVCNbY9vj3v5z6nv4NhQJ9EMqeEgwuZ/SSA81w9HTPCdkva5ZSKz4ouSR7of6lhDGaPnunM81HFRVTe0uLuhEnYRck/9BngjwUV4mScydgDmbRDmNVixg== X-OriginatorOrg: prevas.dk X-MS-Exchange-CrossTenant-Network-Message-Id: 71408fa4-f852-4a12-dd90-08d7e5351de5 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2020 14:14:19.6464 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AHhEhjp+DgGi5z2akmLey16AfN+IAJ0fuckVefaGGALdc5scN886vjMgskGjoDwFEU9VEbVIj7chfmMRdm+Ux5fpvxzMgHtvCzKrIKlYLN4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB2208 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <https://lists.denx.de/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <https://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <https://lists.denx.de/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean |
| Series |
spi: mpc8xxx_spi: fix missing dev_err definition
|
expand
|
On Mon, Apr 20, 2020 at 04:13:41PM +0200, Rasmus Villemoes wrote: > The build currently fails with > > drivers/spi/mpc8xxx_spi.c:64:3: warning: implicit declaration of function ‘dev_err’ [-Wimplicit-function-declaration] > ... > drivers/spi/built-in.o: In function `mpc8xxx_spi_set_speed': > drivers/spi/mpc8xxx_spi.c:227: undefined reference to `dev_err' > > Fixes: 4856cc7a97 (mpc8xxx_spi: implement real ->set_speed) > Fixes: 1a7b462dee (mpc8xxx_spi: put max_cs to use) > Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk> Applied to u-boot/master, thanks!
diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c index 1bde31ad34..e48debb045 100644 --- a/drivers/spi/mpc8xxx_spi.c +++ b/drivers/spi/mpc8xxx_spi.c @@ -12,6 +12,7 @@ #include <spi.h> #include <asm/mpc8xxx_spi.h> #include <asm-generic/gpio.h> +#include <dm/device_compat.h> enum { SPI_EV_NE = BIT(31 - 22), /* Receiver Not Empty */
The build currently fails with drivers/spi/mpc8xxx_spi.c:64:3: warning: implicit declaration of function ‘dev_err’ [-Wimplicit-function-declaration] ... drivers/spi/built-in.o: In function `mpc8xxx_spi_set_speed': drivers/spi/mpc8xxx_spi.c:227: undefined reference to `dev_err' Fixes: 4856cc7a97 (mpc8xxx_spi: implement real ->set_speed) Fixes: 1a7b462dee (mpc8xxx_spi: put max_cs to use) Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk> --- Those patches got into -rc5, but I hadn't noticed commit 336d4615f8fa (dm: core: Create a new header file for 'compat' features) from -rc2. Sorry about this. Probably no buildbot caught it before release because no in-tree defconfig sets CONFIG_MPC8XXX_SPI=y. drivers/spi/mpc8xxx_spi.c | 1 + 1 file changed, 1 insertion(+)