From patchwork Mon Mar 16 21:23:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 1255845 X-Patchwork-Delegate: wd@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=prevas.dk Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=prevas.dk header.i=@prevas.dk header.a=rsa-sha256 header.s=selector1 header.b=WL65/j/v; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48h8SW3kPCz9sPR for ; Tue, 17 Mar 2020 08:24:11 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7354C818DA; Mon, 16 Mar 2020 22:23:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=prevas.dk header.i=@prevas.dk header.b="WL65/j/v"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 524F9818DA; Mon, 16 Mar 2020 22:23:56 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2072f.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1b::72f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0F3C581827 for ; Mon, 16 Mar 2020 22:23:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T9XUlUBlIIluC05PXdNJb45zB0ezftEz4kNLncYJyKUXhZZGT+Ux6G5xWC+nQhXFsH+EvpjVwEdoNR1SGngJz1NED3dgxwhW+SeodeWhzC9YZmhsW3tkzVNRzAxbGBGEtG20VeJJ1aQDEd4DVdhjbaBTOKvi13kufrXP3jfTWfoEQ0LrPSL7tcxoVRlhhX8WAS3qJil8Y1jpbOYxiiEZbg/QHgWzY7J8pAS0mKxh5EEg3qhaxhkbY0xE4qbt1+jnIbD+1/1RLLO1hJpx6Ut9YOPao2xj0LksqvB2ziJ+ovcxE2gNpCIjoDHo6VWqjuEfwZTGA41A381u/bPoKRcl9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DrEeEWMg8bMsiTTL/hsEfSK7FqkJhEkBQv41U6CmJ/s=; b=dUePInot+eq2Ce3xBYVGKFMvgBHASL57SVDwEBft2v3Qk4xXZ5U/0neIjyOmZxujEbJbsKJP/T7/xLbZsvlwQWKn7nk2maq9yc1U5Xq+gQsBhVzJWoqJHIGnmQ1MDBSznBWSmRoQZqOmbpQUQsZqRvd3YqBge4GCV7yzup/rtsE8XM7qqdTMW9iemQlRLQbIPiZVztZR/q7+rP7cJ8FKTzUXIDCW49nBQHgEMuABgdmlwIdpFHf99nn7/WSU2ojzO9eEGAXOqgNsp6ONAFaEYdSfNI7Zugjwz8oCu9XORQFpDlY6qyuSpJfL8h/1+q42l99tWkCZ3pR3JfAORprNTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk; dkim=pass header.d=prevas.dk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DrEeEWMg8bMsiTTL/hsEfSK7FqkJhEkBQv41U6CmJ/s=; b=WL65/j/vu98hrMvpgJi41/x6euy2pEGaoWR7H8ZnVtwEmEhD3n+TlVIpFV3RXI+xDUdEdgjPYgr3UWQOmlYGFBoTnw0jHTq5ju5WdRauWRmKLDKXRdqWwX8JdjwKO9CD2LYBvPsLzZ8b2qSeRRi8i3XIMcVi1S2QQLFuiJGm5UQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=rasmus.villemoes@prevas.dk; Received: from VI1PR10MB2765.EURPRD10.PROD.OUTLOOK.COM (20.178.126.85) by VI1PR10MB1614.EURPRD10.PROD.OUTLOOK.COM (10.165.194.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.22; Mon, 16 Mar 2020 21:23:49 +0000 Received: from VI1PR10MB2765.EURPRD10.PROD.OUTLOOK.COM ([fe80::e58f:1097:b71d:32c7]) by VI1PR10MB2765.EURPRD10.PROD.OUTLOOK.COM ([fe80::e58f:1097:b71d:32c7%5]) with mapi id 15.20.2814.021; Mon, 16 Mar 2020 21:23:49 +0000 From: Rasmus Villemoes To: u-boot@lists.denx.de Cc: Wolfgang Denk , Simon Glass , Christophe Leroy , Rasmus Villemoes Subject: [PATCH] powerpc: remove WATCHDOG_RESET call from wait_ticks() Date: Mon, 16 Mar 2020 22:23:37 +0100 Message-Id: <20200316212337.30204-1-rasmus.villemoes@prevas.dk> X-Mailer: git-send-email 2.23.0 X-ClientProxiedBy: AM5PR06CA0005.eurprd06.prod.outlook.com (2603:10a6:206:2::18) To VI1PR10MB2765.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:803:e1::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from prevas-ravi.prevas.se (5.186.114.43) by AM5PR06CA0005.eurprd06.prod.outlook.com (2603:10a6:206:2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.18 via Frontend Transport; Mon, 16 Mar 2020 21:23:48 +0000 X-Mailer: git-send-email 2.23.0 X-Originating-IP: [5.186.114.43] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4761fd66-5501-4388-371e-08d7c9f05175 X-MS-TrafficTypeDiagnostic: VI1PR10MB1614: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-Forefront-PRVS: 03449D5DD1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(376002)(366004)(346002)(136003)(396003)(39850400004)(199004)(6486002)(6916009)(26005)(16526019)(186003)(43170500002)(6512007)(316002)(86362001)(5660300002)(478600001)(6666004)(54906003)(36756003)(4326008)(1076003)(956004)(66556008)(66476007)(2906002)(81156014)(66946007)(2616005)(81166006)(52116002)(6506007)(107886003)(8676002)(8936002)(44832011)(8976002); DIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR10MB1614; H:VI1PR10MB2765.EURPRD10.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; Received-SPF: None (protection.outlook.com: prevas.dk does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0lhPzYMay02p3zPpldLqz9ZjrQ0dkFFR+2dqhcZ2xMiByaiwFbAZGmuvz8klhy3b1CIo0fFY+2OqRCi+8MFzl4glt29EgzXNzySlBNO/w5vqpeL8IO4VUA0shrQ6GALcCM3xZ9W3wlRN9bhQT6TtA61LuVsoxsqOvsL/I567Xy5Jab4fOe0f2I4fm2mWuRpVCorWTSYW5SxguoKbeITPFr277Y3PA0lYid3ZnWK520CeB+s04/6nF4w7PwcxGE7nUWnrL+FW52CLnFvhcxgKpFjGJSyZJkP1R/3N1/rgkKSfmjlxBrs4lVP7pSlpT0KTFer9/rcp4hee/FFkfZuVgrDlXoaItThJXc58xeLBFbmhTqZdWx5QmATri4C+uFxOVUVXtcO0ZHKNKCbh08cXAHWen7uiJvTy18UPq7/DaS4fkfvoRaayzRtP+0OX7O+V7rjySAxe1kovBhr13GOhy6y6GySMG6qZCTAsOwrwew3TcHKrLqexgCEPeou5ExHU X-MS-Exchange-AntiSpam-MessageData: Q9+poK8ZsgzubnR5JpPemW/Jz6IgMx6GsPXzFyUHdxzbAZN5eEao2UNUIcz2Scu+qRjryISKNpK6wo9HvcrC0BJYfkRZbj8M9OYMUNt1kyGy8VHEG68WSlLv3jzQ1bhb5mo3L+6MzekVkFr1w8BHIw== X-OriginatorOrg: prevas.dk X-MS-Exchange-CrossTenant-Network-Message-Id: 4761fd66-5501-4388-371e-08d7c9f05175 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2020 21:23:49.4353 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RzhyNYdBEYGY2YIVzCqBv7mMOd6fsul3tokx4nJDy2Nqy2XXXzVc+fEoR5p0OF7PaZh7BZtQHl6mLVL2jqkIVBayaPpkLbqpcQM0U2E8lAk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB1614 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean wait_ticks() is only used by the ppc-specific __udelay() function. Having the powerpc version of __udelay implicitly call WATCHDOG_RESET() is inconsistent with other architectures' (and the generic __udelay() in lib/time.c) implementations. It also means a driver cannot use __udelay() as the raw primitive it is supposed to be - e.g. a watchdog driver that needs to do a short delay between two operations needed to perform a ping sequence. There are not that many __udelay() calls, so I doubt this causes a regression for anyone. Callers of udelay() are not affected, since udelay() itself does one WATCHDOG_RESET() per __udelay() call. Signed-off-by: Rasmus Villemoes --- arch/powerpc/lib/ticks.S | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/lib/ticks.S b/arch/powerpc/lib/ticks.S index c487f938fa..f4410bbc3a 100644 --- a/arch/powerpc/lib/ticks.S +++ b/arch/powerpc/lib/ticks.S @@ -42,7 +42,6 @@ wait_ticks: addc r14, r4, r14 /* Compute end time lower */ addze r15, r3 /* and end time upper */ - WATCHDOG_RESET /* Trigger watchdog, if needed */ 1: bl get_ticks /* Get current time */ subfc r4, r4, r14 /* Subtract current time from end time */ subfe. r3, r3, r15