From patchwork Fri Nov 29 19:29:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugeniu Rosca X-Patchwork-Id: 1202576 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=de.adit-jv.com Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 47Pl365vcbz9sPJ for ; Sat, 30 Nov 2019 06:30:26 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 53643C21DED; Fri, 29 Nov 2019 19:30:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id D0C6BC21DFD; Fri, 29 Nov 2019 19:30:19 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 20953C22066; Fri, 29 Nov 2019 19:30:15 +0000 (UTC) Received: from smtp1.de.adit-jv.com (smtp1.de.adit-jv.com [93.241.18.167]) by lists.denx.de (Postfix) with ESMTPS id E9124C22113 for ; Fri, 29 Nov 2019 19:30:14 +0000 (UTC) Received: from localhost (smtp1.de.adit-jv.com [127.0.0.1]) by smtp1.de.adit-jv.com (Postfix) with ESMTP id CDCBA3C0579; Fri, 29 Nov 2019 20:30:14 +0100 (CET) Received: from smtp1.de.adit-jv.com ([127.0.0.1]) by localhost (smtp1.de.adit-jv.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5B0MT1TKXKAf; Fri, 29 Nov 2019 20:30:08 +0100 (CET) Received: from HI2EXCH01.adit-jv.com (hi2exch01.adit-jv.com [10.72.92.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp1.de.adit-jv.com (Postfix) with ESMTPS id E6A723C00BE; Fri, 29 Nov 2019 20:30:08 +0100 (CET) Received: from vmlxhi-102.adit-jv.com (10.72.93.184) by HI2EXCH01.adit-jv.com (10.72.92.24) with Microsoft SMTP Server (TLS) id 14.3.468.0; Fri, 29 Nov 2019 20:30:08 +0100 From: Eugeniu Rosca To: , Tom Rini , Simon Glass , Sam Protsenko , Igor Opaniuk Date: Fri, 29 Nov 2019 20:29:16 +0100 Message-ID: <20191129192919.27715-2-erosca@de.adit-jv.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191129192919.27715-1-erosca@de.adit-jv.com> References: <20191129192919.27715-1-erosca@de.adit-jv.com> MIME-Version: 1.0 X-Originating-IP: [10.72.93.184] Cc: Roman Stratiienko , Eugeniu Rosca , Eugeniu Rosca Subject: [U-Boot] [PATCH 1/4] cmd: dtimg: Report invalid index argument X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Being user-friendly is paramount to make any product likeable and easy to use. Hence, instead of [1], print [2]. [1] dtimg start 0x48000000 not-a-number myvar Error: Wrong index [2] dtimg start 0x48000000 not-a-number myvar Error: Wrong index 'not-a-number' Signed-off-by: Eugeniu Rosca Reviewed-by: Sam Protsenko --- cmd/dtimg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/dtimg.c b/cmd/dtimg.c index 6c5d53cc6808..2317c859953d 100644 --- a/cmd/dtimg.c +++ b/cmd/dtimg.c @@ -63,7 +63,7 @@ static int dtimg_get_fdt(int argc, char * const argv[], enum cmd_dtimg_info cmd) index = simple_strtoul(argv[2], &endp, 0); if (*endp != '\0') { - printf("Error: Wrong index\n"); + printf("Error: Wrong index '%s'\n", argv[2]); return CMD_RET_FAILURE; }