From patchwork Thu Nov 28 13:56:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Opaniuk X-Patchwork-Id: 1202072 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="rLc5SLqx"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 47NzhM4kbsz9sP6 for ; Fri, 29 Nov 2019 00:56:35 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 55CE8C22096; Thu, 28 Nov 2019 13:56:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 8C7E2C21ECA; Thu, 28 Nov 2019 13:56:27 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 3910EC21ECA; Thu, 28 Nov 2019 13:56:25 +0000 (UTC) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by lists.denx.de (Postfix) with ESMTPS id BACE8C21C29 for ; Thu, 28 Nov 2019 13:56:24 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id b11so11014963wmj.4 for ; Thu, 28 Nov 2019 05:56:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=SN9pB3z94RHxINt2PC8GaDi0SH6gmnXypADz4US4ZW0=; b=rLc5SLqxn3oIWX4blmReKszMXxiVhLtLGUwboDCIUZ5Pdw/8htUMX+u/YQx8KzCjn7 rg+VVUs/z81ySgGrMMMSWWUYd6w2+ydwIjPmnU5xBwi9TuVpp5jf+4Dkj59nP7L17aSa dbttgu4NG3Xu8G0xTdMBK+aMiR5ZmPAW4Ye5evE+ufa0dsHWZvoc9/O2LMiPqqWY12a8 cPhhVeWMxwJD2YD1CBFQ0VkrADM0SEgbFgXKK/Z5s6di58f2hxUUnhFUkP6HpHFzsKmS iLj6k1V5HXPbXe37OlRO5Ro2hmiDZQIdmziUUX6lON6lv7nzF40JX04dXWM/WPpXASHQ rnJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=SN9pB3z94RHxINt2PC8GaDi0SH6gmnXypADz4US4ZW0=; b=heTDi5KV5seQUhhLWtN1BY8XeRLmQwDIYiIPOOeYEYQ/N19lAojyuW7upxo1FV5kHN zejD2EKOCKKjKvv1/MBMGfucqGdCAOTLlpZBOgi2A7BwUBY+FEV2vT+te0FurMHe9LH6 DRv4Reo2R8vY1Q7rDx+dz3u5o0dxWYbe6De5MeyQqqF/dvDpwujewfA5knft84cMGD+0 0v/N9gsmKQ2EJrYEsu/emppgX7RTHT3vpUSNklOt6/8sndZ45OAXgNBcTMaXJBGLGIjU AorEyAsBzt8GidvsNCkmJi57uTcdpMtsWICR6ZEx33GCl0hoik58Y92/YUanRXraGh5l nhuQ== X-Gm-Message-State: APjAAAURB2es4w5rFClwhNZ4Hyi/CIovbda8qYULinIJIUpJnwXuO/TA IBOfqT6jJMu/IdiqFfIoXcueI/UV9fo= X-Google-Smtp-Source: APXvYqyN8j5R8+dlLUvr0/EKFBt2eZMEQh22UyYva4qBkH9O/jDoIZW2BPk7npITQhxo1eg1IiSQzA== X-Received: by 2002:a1c:7419:: with SMTP id p25mr9987332wmc.111.1574949383929; Thu, 28 Nov 2019 05:56:23 -0800 (PST) Received: from localhost ([194.105.145.90]) by smtp.gmail.com with ESMTPSA id m15sm23453702wrq.97.2019.11.28.05.56.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Nov 2019 05:56:23 -0800 (PST) From: Igor Opaniuk To: u-boot@lists.denx.de Date: Thu, 28 Nov 2019 15:56:19 +0200 Message-Id: <20191128135621.12719-1-igor.opaniuk@gmail.com> X-Mailer: git-send-email 2.17.1 Cc: "NXP i.MX U-Boot Team" , Marcel Ziswiler , Igor Opaniuk , Max Krummenacher Subject: [U-Boot] [PATCH v2 1/3] mach-imx: bootaux: print stack pointer and reset vector X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Igor Opaniuk 1. Change information printed about loaded M4 binary, print the stack pointer and reset vector addressed. 2. Add sanity check for the address provided as param. Signed-off-by: Igor Opaniuk Reviewed-by: Oleksandr Suvorov --- arch/arm/mach-imx/imx_bootaux.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/imx_bootaux.c b/arch/arm/mach-imx/imx_bootaux.c index 3d9422d5a2..ee786f7d06 100644 --- a/arch/arm/mach-imx/imx_bootaux.c +++ b/arch/arm/mach-imx/imx_bootaux.c @@ -20,6 +20,9 @@ int arch_auxiliary_core_up(u32 core_id, ulong boot_private_data) stack = *(u32 *)boot_private_data; pc = *(u32 *)(boot_private_data + 4); + printf("## Starting auxiliary core stack = 0x%08lX, pc = 0x%08lX...\n", + stack, pc); + /* Set the stack and pc to M4 bootROM */ writel(stack, M4_BOOTROM_BASE_ADDR); writel(pc, M4_BOOTROM_BASE_ADDR + 4); @@ -80,7 +83,8 @@ static int do_bootaux(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) addr = simple_strtoul(argv[1], NULL, 16); - printf("## Starting auxiliary core at 0x%08lX ...\n", addr); + if (!addr) + return CMD_RET_FAILURE; ret = arch_auxiliary_core_up(0, addr); if (ret)