Message ID | 20191117184736.507812-1-anarsoul@gmail.com |
---|---|
State | Accepted |
Commit | e82692ab325088fe78beba727862c377ced0fc8b |
Delegated to: | Kever Yang |
Headers | show |
Series | [U-Boot] power: fan53555: fix fan53555_regulator_set_value | expand |
On 2019/11/18 上午2:47, Vasily Khoruzhick wrote: > fan53555_regulator_set_value() passes its own dev to pmic_clrsetbits() > instead of its parent (pmic). As result u-boot crashes when you try to > set voltage on fan53555 regulator > > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> Reviewed-by: Kever Yang <kever.yang@rock-chips.com> Thanks, - Kever > --- > drivers/power/regulator/fan53555.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/regulator/fan53555.c b/drivers/power/regulator/fan53555.c > index 9c48b26216..24a9b67586 100644 > --- a/drivers/power/regulator/fan53555.c > +++ b/drivers/power/regulator/fan53555.c > @@ -159,7 +159,7 @@ static int fan53555_regulator_set_value(struct udevice *dev, int uV) > debug("%s: uV=%d; writing volume %d: %02x\n", > __func__, uV, pdata->vol_reg, vol); > > - return pmic_clrsetbits(dev, pdata->vol_reg, GENMASK(6, 0), vol); > + return pmic_clrsetbits(dev->parent, pdata->vol_reg, GENMASK(6, 0), vol); > } > > static int fan53555_voltages_setup(struct udevice *dev)
diff --git a/drivers/power/regulator/fan53555.c b/drivers/power/regulator/fan53555.c index 9c48b26216..24a9b67586 100644 --- a/drivers/power/regulator/fan53555.c +++ b/drivers/power/regulator/fan53555.c @@ -159,7 +159,7 @@ static int fan53555_regulator_set_value(struct udevice *dev, int uV) debug("%s: uV=%d; writing volume %d: %02x\n", __func__, uV, pdata->vol_reg, vol); - return pmic_clrsetbits(dev, pdata->vol_reg, GENMASK(6, 0), vol); + return pmic_clrsetbits(dev->parent, pdata->vol_reg, GENMASK(6, 0), vol); } static int fan53555_voltages_setup(struct udevice *dev)
fan53555_regulator_set_value() passes its own dev to pmic_clrsetbits() instead of its parent (pmic). As result u-boot crashes when you try to set voltage on fan53555 regulator Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> --- drivers/power/regulator/fan53555.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)