From patchwork Tue Nov 5 04:05:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Priyanka Jain X-Patchwork-Id: 1189300 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="FooGBfhS"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 476bfx2dLWz9sNT for ; Tue, 5 Nov 2019 15:05:27 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 3C1A0C21DA6; Tue, 5 Nov 2019 04:05:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id B7DEEC21C2C; Tue, 5 Nov 2019 04:05:16 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 7FE9CC21C2C; Tue, 5 Nov 2019 04:05:15 +0000 (UTC) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30060.outbound.protection.outlook.com [40.107.3.60]) by lists.denx.de (Postfix) with ESMTPS id 042C6C21BE5 for ; Tue, 5 Nov 2019 04:05:15 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jYsM5UYuOQl1jnPZEslJmNb137/8/A+QF5FzrhT7xb5iSJAqlAbZ9l3QoumZANDJj8bueePv/hDzof4rXdi/vH3CdZK9GzP3iyIKZRo3wJflg176/hEz4eX3++Ja1pibWCHQH8oRWTYghPRTbscC2QK8se4+owun70yR9eKSkUBMo97UWrEg1NKwWuGw3Va1wV+FfH9cZMLmtEAbwh2BIQcL1pA1PTOMKguimSIHSXo2H7pO51+VYWtrXgEDKrzWJYK5KdCbL9x79oGsnwgzu3QIsrIW3xKNjqMl3z4QKdrWvGHL2LfrZSzDiapL/YTaaGK+ZrWZV/QqaY7TkAxlvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f4Xd7HJ7eIfdHCC7OoZ8qjHmlEcIV0zU28RtDr+Yq5w=; b=j1yDEGwulbyu3+6OUZ/Gu9WPMPgjyGd3aDeH99yVv69xSvunkXH/zmipscBdmGeTj7C2pl2o6V+iFVqfzu7TGzVo/GLpeSH4j7uwK/QkRh+9murpG9VgrA05YPyGcSAJ//OT5RmuLX6HvYk9DKW1gJLpOmRyU1z+ElXo9w4a/TTf22phbqp/Yae7QExZKZr728aV427uFWeWoTQr4k64OVsp4LFZeGvMiLUYiRdd4C0m8ily7nECs/kwoAnmRkXuaveBqzkP8AYi+cIzYUe8+vel9OZGJhvAcvvJgNBe51XV8QfBeYC/BNsX3a5v/00X5hHtgcqDELqTvdj720rycg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f4Xd7HJ7eIfdHCC7OoZ8qjHmlEcIV0zU28RtDr+Yq5w=; b=FooGBfhSWb7ewIk7PbfwCZEj2N58qI5wkJsoIG3/ulc3ur1Q6N07PfhrEkx12Ratr2JI/lv45bbXg23eJsVLJQZkVfmy0ANbn+8Bll58nIebfEU+S170i0/dNmW4KyT3pZuuQ+669rJloxib56MRRuacvXeNLfWK0LzXSKUbjNk= Received: from VE1PR04MB6494.eurprd04.prod.outlook.com (20.179.235.143) by VE1PR04MB6653.eurprd04.prod.outlook.com (20.179.234.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Tue, 5 Nov 2019 04:05:11 +0000 Received: from VE1PR04MB6494.eurprd04.prod.outlook.com ([fe80::24f5:c56a:7fc5:761e]) by VE1PR04MB6494.eurprd04.prod.outlook.com ([fe80::24f5:c56a:7fc5:761e%7]) with mapi id 15.20.2408.024; Tue, 5 Nov 2019 04:05:11 +0000 From: Priyanka Jain To: "u-boot@lists.denx.de" , "joe.hershberger@ni.com" Thread-Topic: [PATCH] net/phy: Fix phy_connect() for phy addr 0 Thread-Index: AQHVk444lc/KbRrfRUiq036MeSRO6w== Date: Tue, 5 Nov 2019 04:05:11 +0000 Message-ID: <20191105040439.23450-1-priyanka.jain@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SG2PR06CA0135.apcprd06.prod.outlook.com (2603:1096:1:1f::13) To VE1PR04MB6494.eurprd04.prod.outlook.com (2603:10a6:803:127::15) authentication-results: spf=none (sender IP is ) smtp.mailfrom=priyanka.jain@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [14.142.151.118] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4021b647-4d88-4ac4-a945-08d761a55aa4 x-ms-traffictypediagnostic: VE1PR04MB6653:|VE1PR04MB6653: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1850; x-forefront-prvs: 0212BDE3BE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(376002)(396003)(346002)(366004)(136003)(199004)(189003)(99286004)(66476007)(64756008)(6512007)(86362001)(486006)(386003)(71200400001)(44832011)(6436002)(71190400001)(305945005)(4744005)(6506007)(36756003)(66556008)(66946007)(478600001)(26005)(7736002)(2906002)(4326008)(2616005)(2501003)(81156014)(8676002)(14454004)(50226002)(81166006)(14444005)(55236004)(476003)(1076003)(110136005)(25786009)(186003)(66446008)(316002)(8936002)(102836004)(6486002)(52116002)(66066001)(256004)(3846002)(5660300002)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6653; H:VE1PR04MB6494.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WVXkam+vPso2VhwH/gd5rZyGjbzjyJkhWIOOxU4yji6Qqtc+hU/b4ajGuREIPsYsJ6X5awwq/vhnQlyDQ2IrbFWtMDdK7Dehyzdj3AaSJjyETd5AzIakAONX0h3a7NKQUGWSCORcM9IoNOpfABidVxQJqEN2mVLRFyToi+RTju+7QnCpGeov5XOaHnZe2bqGuetUOs4fsuPl3Pxo1eodKFwdKuIA0ly6S9HhKjivgU+cWDVALDheh8R8yMaiTx1oSA8JFPBMiCt9wJA8it5wTkilUsQ9rPa6mb8vd/u07q6wSoTjhv2Bq3+LGP6hjAyOTx9oROZZQ2EUEhZ5zAMkYBjftOEVsa5smungxiSbfW3LEp5r1GkhfmgMuNqm2TVHSu9IgbDAo9FaRa54FaePGufUSogZm6jG/PuvSKUyTwCpCzk4tjmh+3Ea7MgoiyQ+ MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4021b647-4d88-4ac4-a945-08d761a55aa4 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2019 04:05:11.8560 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eOBYxqeSb2iToD9ry81N6A3mscvre0xx5x05uxFKr+NxPlDiDdePi9cuq2YRCxCXMFA4JIYY3JfR5WHtDplpYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6653 Subject: [U-Boot] [PATCH] net/phy: Fix phy_connect() for phy addr 0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Fix 'mask' calculation in phy_connect() for phy addr '0'. 'mask' is getting set to '0xffffffff' for phy addr '0' in phy_connect() whereas expected value is '0'. Signed-off-by: Priyanka Jain Reported-by: tetsu-aoki via github Acked-by: Joe Hershberger --- drivers/net/phy/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index ae37dd6c1e..419e6869c0 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -952,7 +952,7 @@ struct phy_device *phy_connect(struct mii_dev *bus, int addr, #endif { struct phy_device *phydev = NULL; - uint mask = (addr > 0) ? (1 << addr) : 0xffffffff; + uint mask = (addr >= 0) ? (1 << addr) : 0xffffffff; #ifdef CONFIG_PHY_FIXED phydev = phy_connect_fixed(bus, dev, interface);