From patchwork Tue Oct 29 21:07:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suneel Garapati X-Patchwork-Id: 1186301 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qfwE4d3R"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 472kqD3rCkz9sQr for ; Wed, 30 Oct 2019 08:14:16 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 165C2C21CB1; Tue, 29 Oct 2019 21:09:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id D3254C21DF9; Tue, 29 Oct 2019 21:08:43 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 0872EC21DEC; Tue, 29 Oct 2019 21:08:36 +0000 (UTC) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by lists.denx.de (Postfix) with ESMTPS id 4E6FAC21DA2 for ; Tue, 29 Oct 2019 21:08:31 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id 15so10497845pgt.7 for ; Tue, 29 Oct 2019 14:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+j73sBgppsuyXW86wihch/hKx0IR7F6V2LeMdcV9TLg=; b=qfwE4d3RYq0xqbL6DBhwSLEsMtW6PY8jagNcHRfi57cBjpg5diUNL4FoqTnq4MeUTi GkSSDH5RUEerNyCcjEhnJctlw6aMVLI81jADtNpmz45YgIGGRm1AaAgfB757vzm0JJKI WFKrKvqEGSI8hLG57NBBMkG7Nh+j5oTeDD017Njn0dnpSOi1g7p4rc4c8sJl6Mtf0dDu oq6yzQdoRWe93KVjEef8DY1cGyu/rf9oWqPBGzKZc69ktBKIARYJZHhkx+dm9zmBeifg eKfmZnHjmYOIxf7Eb00ni9kjEOA0uKNLcAsiG7A6ERYWY+EsYBUrc4yre5ucZS2DPojC iDiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+j73sBgppsuyXW86wihch/hKx0IR7F6V2LeMdcV9TLg=; b=G4+fDrjiYa9UBoPHL1Vr1+ukQ1ct1EEvTRcssACgN0hRdwiACFPGQKUWfBQIktcyRS BgGbJjwbrqVeArPx6+zaptsY9hY4hZnOPMNesX91WRPGwcfM8q0pKPutN5Eokz4h8rsC NBawfS9cNMLdSTOuyvCuMEdavjVAiNkuK2+Mz0EjEv4PwdV+/9P5Zr8OX0SgM2IRSSXe 9fbFzRErs3OhkdeIswaX/MrMMbq7eBE1hz2wz3NLimpO7QuuRES0KdwB0gEi/8nf7D1O dcCfIm2RnOShZUkvCBGRUwTf/JOxy88gEj2s0LjC3ZnhcydU6H7naPjLfm2cYYLbxc2y NRAg== X-Gm-Message-State: APjAAAXvapDuM64En4pj6i+fUu/jeBCBAND2gpn7fXWfCO548QQkM7Ov 5MVjRwuzyuQZMrRtUmHYEyrnhyAE X-Google-Smtp-Source: APXvYqy2b2myAw+i6SP0z/6kz+krVc0WA9JnKu81rlbybpxEzwm/mRJ/yxOx1GtpgwkhdZBVSjBgGQ== X-Received: by 2002:a62:7a8a:: with SMTP id v132mr29699292pfc.228.1572383309760; Tue, 29 Oct 2019 14:08:29 -0700 (PDT) Received: from suneel.hsd1.ca.comcast.net ([2601:641:4000:c9c0:7044:5eef:7096:2413]) by smtp.gmail.com with ESMTPSA id q3sm131160pgj.54.2019.10.29.14.08.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2019 14:08:29 -0700 (PDT) From: Suneel Garapati To: u-boot Date: Tue, 29 Oct 2019 14:07:57 -0700 Message-Id: <20191029210821.1954-6-suneelglinux@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191029210821.1954-1-suneelglinux@gmail.com> References: <20191029210821.1954-1-suneelglinux@gmail.com> MIME-Version: 1.0 Cc: Tom Rini , Matthias Brugger , Joe Hershberger , Prasun Kapoor , Maen Suleiman , Chandrakala Chavva , Zi Shen Lim , Stefan Roese , Chris Packham Subject: [U-Boot] [RFC PATCH 05/29] drivers: pci-uclass: make DT subnode parse optional X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Suneel Garapati Parse subnode DT properties only if parent node is valid. Otherwise, assert is triggered on ofnode_valid in ofnode_first_subnode from dev_for_each_subnode. Signed-off-by: Suneel Garapati Reviewed-by: Simon Glass --- drivers/pci/pci-uclass.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c index 848ac5a65e..007b7472c6 100644 --- a/drivers/pci/pci-uclass.c +++ b/drivers/pci/pci-uclass.c @@ -675,7 +675,8 @@ static int pci_find_and_bind_driver(struct udevice *parent, find_id->vendor, find_id->device); /* Determine optional OF node */ - pci_dev_find_ofnode(parent, bdf, &node); + if (ofnode_valid(dev_ofnode(parent))) + pci_dev_find_ofnode(parent, bdf, &node); start = ll_entry_start(struct pci_driver_entry, pci_driver_entry); n_ents = ll_entry_count(struct pci_driver_entry, pci_driver_entry);