From patchwork Tue Oct 29 21:08:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suneel Garapati X-Patchwork-Id: 1186296 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="i/Ywku34"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 472kny69VQz9sCJ for ; Wed, 30 Oct 2019 08:13:10 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 51A5CC21C27; Tue, 29 Oct 2019 21:10:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 8D306C21E35; Tue, 29 Oct 2019 21:08:56 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 595EEC21E38; Tue, 29 Oct 2019 21:08:46 +0000 (UTC) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by lists.denx.de (Postfix) with ESMTPS id EB699C21DE8 for ; Tue, 29 Oct 2019 21:08:39 +0000 (UTC) Received: by mail-pl1-f172.google.com with SMTP id q21so8275468plr.13 for ; Tue, 29 Oct 2019 14:08:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PkCjb6OkWiCYRDnC7adJS82xPrx//im7jtComXXWxQY=; b=i/Ywku34tmCHX+v3/DqWGupWJ6gxltsWZCrPAuhU1ncNo1dxODMKwb9zESglhGUSgW OHPJpSgj7vRYqtu4yt+U+sbV6irL7nzWL6SZv9cAbVPKDV4ogki9uWm0EjVFBANRf50y biMl1O/fCgIWen0gqNdVlvszDNGnqx1+nKjYXHvPpy8D+wtulCRot/93dJfvRqAi4NeR h4ZwP612RmHcWcruP6gxlJza18i/T/wl3c1Zr/nAybUVqTCrgbQr3g7cY9NiT70ocw8M Fec+DHWeeENKEWRrAHEMNvReHALD4LpdbJYb4+I+iY3P+gKQacRdPMW1HxKsPBfh6jIb XORA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PkCjb6OkWiCYRDnC7adJS82xPrx//im7jtComXXWxQY=; b=nNtjHrBftgk7ufJTMv3f689SVJyKu206LMAHRFDFULZergp/q947Tt6XcryU8u9VTC VmuZOq+K12AhCTLN+KdIxnTjwMT5V7xswhiTVgBFg8FRC+xjEabRs8rUj4sWy+0RpNNA atg/v+wgB89Ql6Xq29kdLLrhxyDNeywfRKdlxIvIha4u8mtJqqhLK0xAbj5D1KZ1E2r0 JncjuoPmKi2MuT3ZP2pSIgXjbdYTV5bKFspsE638fXhjVzl1AEaQ4yk9hCZEwE9DOOZK gTt0pD2rE8mLCLxIuYI5QHFaL42swEadj49d2hJ4QB+6FzZgiuNbtbTqn+Wyw2UfmmlW ejrg== X-Gm-Message-State: APjAAAXeRNXVPTxuikT+X9WBT/vqVKC3MlHL/nx57999ucsTEao5saE3 Ruwe3K8VmKc+TC1zY3EHu+avVg2Z X-Google-Smtp-Source: APXvYqxARZ2G+4d6JpnGC/D0tJOxWJ4e+z+LuL1qblxSzf7ofb3Q/dreyWGPG6wypOaAfW6Q22D05Q== X-Received: by 2002:a17:902:1:: with SMTP id 1mr722316pla.338.1572383318270; Tue, 29 Oct 2019 14:08:38 -0700 (PDT) Received: from suneel.hsd1.ca.comcast.net ([2601:641:4000:c9c0:7044:5eef:7096:2413]) by smtp.gmail.com with ESMTPSA id q3sm131160pgj.54.2019.10.29.14.08.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2019 14:08:37 -0700 (PDT) From: Suneel Garapati To: u-boot Date: Tue, 29 Oct 2019 14:08:04 -0700 Message-Id: <20191029210821.1954-13-suneelglinux@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191029210821.1954-1-suneelglinux@gmail.com> References: <20191029210821.1954-1-suneelglinux@gmail.com> MIME-Version: 1.0 Cc: Tom Rini , Matthias Brugger , Joe Hershberger , Prasun Kapoor , Maen Suleiman , Chandrakala Chavva , Zi Shen Lim , Stefan Roese , Chris Packham Subject: [U-Boot] [RFC PATCH 12/29] drivers: rtc: ds1337: add driver model support X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Suneel Garapati Add DM support to dallas 1337 RTC driver. Signed-off-by: Suneel Garapati Reviewed-by: Simon Glass --- drivers/rtc/Kconfig | 7 ++ drivers/rtc/ds1337.c | 170 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 177 insertions(+) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 8778cc7b26..c31c6a3368 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -54,6 +54,13 @@ config RTC_DS1307 Support for Dallas Semiconductor (now Maxim) DS1307 and DS1338/9 and compatible Real Time Clock devices. +config RTC_DS1337 + bool "Enable DS1337 driver" + depends on DM_RTC + help + Support for Dallas Semiconductor (now Maxim) DS1337/39 and DS1388 and + compatible Real Time Clock devices. + config RTC_ISL1208 bool "Enable ISL1208 driver" depends on DM_RTC diff --git a/drivers/rtc/ds1337.c b/drivers/rtc/ds1337.c index 9b31048e97..a1c63ffa08 100644 --- a/drivers/rtc/ds1337.c +++ b/drivers/rtc/ds1337.c @@ -1,8 +1,11 @@ // SPDX-License-Identifier: GPL-2.0+ /* + * Copyright (C) 2018 Marvell International Ltd. + * * (C) Copyright 2001-2008 * Wolfgang Denk, DENX Software Engineering, wd@denx.de. * Keith Outwater, keith_outwater@mvis.com` + * */ /* @@ -14,6 +17,10 @@ #include #include #include +#include +#include + +DECLARE_GLOBAL_DATA_PTR; /* * RTC register addresses @@ -59,6 +66,167 @@ #define RTC_STAT_BIT_A2F 0x2 /* Alarm 2 flag */ #define RTC_STAT_BIT_OSF 0x80 /* Oscillator stop flag */ +#ifdef CONFIG_DM_RTC + +/* + * Helper functions + */ +static uchar dm_rtc_read(struct udevice *dev, uchar reg) +{ + return dm_i2c_reg_read(dev, reg); +} + +static void dm_rtc_write(struct udevice *dev, uchar reg, uchar val) +{ + dm_i2c_reg_write(dev, reg, val); +} + +static int ds1337_rtc_get(struct udevice *dev, struct rtc_time *tmp) +{ + int rel = 0; + uchar sec, min, hour, mday, wday, mon_cent, year, control, status; + + control = dm_rtc_read(dev, RTC_CTL_REG_ADDR); + status = dm_rtc_read(dev, RTC_STAT_REG_ADDR); + sec = dm_rtc_read(dev, RTC_SEC_REG_ADDR); + min = dm_rtc_read(dev, RTC_MIN_REG_ADDR); + hour = dm_rtc_read(dev, RTC_HR_REG_ADDR); + wday = dm_rtc_read(dev, RTC_DAY_REG_ADDR); + mday = dm_rtc_read(dev, RTC_DATE_REG_ADDR); + mon_cent = dm_rtc_read(dev, RTC_MON_REG_ADDR); + year = dm_rtc_read(dev, RTC_YR_REG_ADDR); + + /* No century bit, assume year 2000 */ +#ifdef CONFIG_RTC_DS1388 + mon_cent |= 0x80; +#endif + + debug("Get RTC year: %02x mon/cent: %02x mday: %02x wday: %02x", + year, mon_cent, mday, wday); + debug(" hr: %02x min: %02x sec: %02x control: %02x status: %02x\n", + hour, min, sec, control, status); + + if (status & RTC_STAT_BIT_OSF) { + printf("### Warning: RTC oscillator has stopped\n"); + /* clear the OSF flag */ + dm_rtc_write(dev, RTC_STAT_REG_ADDR, + dm_rtc_read(dev, RTC_STAT_REG_ADDR) & + ~RTC_STAT_BIT_OSF); + rel = -1; + } + + tmp->tm_sec = bcd2bin(sec & 0x7F); + tmp->tm_min = bcd2bin(min & 0x7F); + tmp->tm_hour = bcd2bin(hour & 0x3F); + tmp->tm_mday = bcd2bin(mday & 0x3F); + tmp->tm_mon = bcd2bin(mon_cent & 0x1F); + tmp->tm_year = bcd2bin(year) + ((mon_cent & 0x80) ? 2100 : 2000); + tmp->tm_wday = bcd2bin((wday - 1) & 0x07); + tmp->tm_yday = 0; + tmp->tm_isdst = 0; + + debug("Get DATE: %4d-%02d-%02d (wday=%d) TIME: %2d:%02d:%02d\n", + tmp->tm_year, tmp->tm_mon, tmp->tm_mday, tmp->tm_wday, + tmp->tm_hour, tmp->tm_min, tmp->tm_sec); + + return rel; +} + +static int ds1337_rtc_set(struct udevice *dev, const struct rtc_time *tmp) +{ + uchar century; + + debug("Set DATE: %4d-%02d-%02d (wday=%d) TIME: %2d:%02d:%02d\n", + tmp->tm_year, tmp->tm_mon, tmp->tm_mday, tmp->tm_wday, + tmp->tm_hour, tmp->tm_min, tmp->tm_sec); + + if (tmp->tm_year < 2000 || tmp->tm_year > 2199) + return -1; + + dm_rtc_write(dev, RTC_YR_REG_ADDR, bin2bcd(tmp->tm_year % 100)); + + /* Assume 20YY as base, to fix mismatch with linux */ + century = (tmp->tm_year >= 2100) ? 0x80 : 0; + dm_rtc_write(dev, RTC_MON_REG_ADDR, bin2bcd(tmp->tm_mon) | century); + + dm_rtc_write(dev, RTC_DAY_REG_ADDR, bin2bcd(tmp->tm_wday + 1)); + dm_rtc_write(dev, RTC_DATE_REG_ADDR, bin2bcd(tmp->tm_mday)); + dm_rtc_write(dev, RTC_HR_REG_ADDR, bin2bcd(tmp->tm_hour)); + dm_rtc_write(dev, RTC_MIN_REG_ADDR, bin2bcd(tmp->tm_min)); + dm_rtc_write(dev, RTC_SEC_REG_ADDR, bin2bcd(tmp->tm_sec)); + + return 0; +} + +/* + * Reset the RTC. We also enable the oscillator output on the + * SQW/INTB* pin and program it for 32,768 Hz output. Note that + * according to the datasheet, turning on the square wave output + * increases the current drain on the backup battery from about + * 600 nA to 2uA. Define CONFIG_RTC_DS1337_NOOSC if you wish to turn + * off the OSC output. + */ +static int ds1337_rtc_reset(struct udevice *dev) +{ + uchar resetval = RTC_CTL_BIT_RS1 | RTC_CTL_BIT_RS2; /* Default DS1337 */ + +#ifdef CONFIG_RTC_DS1337_NOOSC + resetval |= RTC_CTL_BIT_INTCN; +#elif defined CONFIG_RTC_DS1388 + resetval = 0x0; +#endif + dm_rtc_write(dev, RTC_CTL_REG_ADDR, resetval); + +#ifdef CONFIG_DS1339_TCR_VAL + dm_rtc_write(dev, RTC_TC_REG_ADDR, CONFIG_SYS_DS1339_TCR_VAL); +#endif +#ifdef CONFIG_DS1388_TCR_VAL + dm_rtc_write(dev, RTC_TC_REG_ADDR, CONFIG_SYS_DS1388_TCR_VAL); +#endif + return 0; +} + +static int ds1337_rtc_read8(struct udevice *dev, unsigned int reg) +{ + return dm_rtc_read(dev, reg); +} + +static int ds1337_rtc_write8(struct udevice *dev, unsigned int reg, int val) +{ + dm_rtc_write(dev, reg, val); + + return 0; +} + +static int ds1337_rtc_probe(struct udevice *dev) +{ + ds1337_rtc_reset(dev); + + return 0; +} + +static const struct rtc_ops ds1337_rtc_ops = { + .get = ds1337_rtc_get, + .set = ds1337_rtc_set, + .reset = ds1337_rtc_reset, + .read8 = ds1337_rtc_read8, + .write8 = ds1337_rtc_write8, +}; + +static const struct udevice_id ds1337_rtc_ids[] = { + { .compatible = "dallas,ds1337" }, + { } +}; + +U_BOOT_DRIVER(ds1337_rtc) = { + .name = "rtc-ds1337", + .id = UCLASS_RTC, + .of_match = ds1337_rtc_ids, + .probe = ds1337_rtc_probe, + .ops = &ds1337_rtc_ops, +}; + +#else /* !CONFIG_DM_RTC */ static uchar rtc_read (uchar reg); static void rtc_write (uchar reg, uchar val); @@ -188,3 +356,5 @@ static void rtc_write (uchar reg, uchar val) { i2c_reg_write (CONFIG_SYS_I2C_RTC_ADDR, reg, val); } + +#endif /* !CONFIG_DM_RTC */