| Message ID | 20190926003031.4051-1-troy.kisky@boundarydevices.com |
|---|---|
| State | Rejected |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [U-Boot,1/1] ARM: i.MX6: TARGET_NITROGEN6X: add 'select MX6QDL' | expand |
On 9/25/2019 5:30 PM, Troy Kisky wrote: > This fixes commit <91435cd40d30> "ARM: i.MX6: exclude the ARM errata > from i.MX6 UP system" > > for nitrogen6x. The above commit removed the errata for the board > since MX6Q/MXDL/MX6S is selected via CONFIG_SYS_EXTRA_OPTIONS > > This restores the errata configs. > > Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com> > > --- > Note: > marsboard, mx6qarm2, seem to have same problem. > --- > arch/arm/mach-imx/mx6/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-imx/mx6/Kconfig b/arch/arm/mach-imx/mx6/Kconfig > index 01f0121beb..2c2edaa093 100644 > --- a/arch/arm/mach-imx/mx6/Kconfig > +++ b/arch/arm/mach-imx/mx6/Kconfig > @@ -412,6 +412,7 @@ config TARGET_NITROGEN6X > imply USB_ETHER_MCS7830 > imply USB_ETHER_SMSC95XX > imply USB_HOST_ETHER > + select MX6QDL > > config TARGET_OPOS6ULDEV > bool "Armadeus OPOS6ULDev board" > Maybe the more correct fix is to allow MX6Q/MX6DL/MX6S to be selected in the defconfig (add a text string in the Kconfig). That way MX6S boards won't have unneeded errata applied. Thoughts? Troy
On 26/09/19 18:18, Troy Kisky wrote: > On 9/25/2019 5:30 PM, Troy Kisky wrote: >> This fixes commit <91435cd40d30> "ARM: i.MX6: exclude the ARM errata >> from i.MX6 UP system" >> >> for nitrogen6x. The above commit removed the errata for the board >> since MX6Q/MXDL/MX6S is selected via CONFIG_SYS_EXTRA_OPTIONS >> >> This restores the errata configs. >> >> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com> >> >> --- >> Note: >> marsboard, mx6qarm2, seem to have same problem. >> --- >> arch/arm/mach-imx/mx6/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/mach-imx/mx6/Kconfig b/arch/arm/mach-imx/mx6/Kconfig >> index 01f0121beb..2c2edaa093 100644 >> --- a/arch/arm/mach-imx/mx6/Kconfig >> +++ b/arch/arm/mach-imx/mx6/Kconfig >> @@ -412,6 +412,7 @@ config TARGET_NITROGEN6X >> imply USB_ETHER_MCS7830 >> imply USB_ETHER_SMSC95XX >> imply USB_HOST_ETHER >> + select MX6QDL >> >> config TARGET_OPOS6ULDEV >> bool "Armadeus OPOS6ULDev board" >> > > > Maybe the more correct fix is to allow MX6Q/MX6DL/MX6S to be selected in the defconfig (add a text > string in the Kconfig). That way MX6S boards won't have unneeded errata applied. Not sure. This is really that cannot be configured. If a board has just a i.MX6DL, well, it should not simply configured via menuconfig. It is bound with the hardware. By the way, this simple patch breaks all nitrogen boards, I have to reject it. Regards, Stefano > > Thoughts? > > Troy >
On 11/3/2019 6:44 AM, Stefano Babic wrote: > On 26/09/19 18:18, Troy Kisky wrote: >> On 9/25/2019 5:30 PM, Troy Kisky wrote: >>> This fixes commit <91435cd40d30> "ARM: i.MX6: exclude the ARM errata >>> from i.MX6 UP system" >>> >>> for nitrogen6x. The above commit removed the errata for the board >>> since MX6Q/MXDL/MX6S is selected via CONFIG_SYS_EXTRA_OPTIONS >>> >>> This restores the errata configs. >>> >>> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com> >>> >>> --- >>> Note: >>> marsboard, mx6qarm2, seem to have same problem. >>> --- >>> arch/arm/mach-imx/mx6/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm/mach-imx/mx6/Kconfig b/arch/arm/mach-imx/mx6/Kconfig >>> index 01f0121beb..2c2edaa093 100644 >>> --- a/arch/arm/mach-imx/mx6/Kconfig >>> +++ b/arch/arm/mach-imx/mx6/Kconfig >>> @@ -412,6 +412,7 @@ config TARGET_NITROGEN6X >>> imply USB_ETHER_MCS7830 >>> imply USB_ETHER_SMSC95XX >>> imply USB_HOST_ETHER >>> + select MX6QDL >>> >>> config TARGET_OPOS6ULDEV >>> bool "Armadeus OPOS6ULDev board" >>> >> >> >> Maybe the more correct fix is to allow MX6Q/MX6DL/MX6S to be selected in the defconfig (add a text >> string in the Kconfig). That way MX6S boards won't have unneeded errata applied. > > Not sure. This is really that cannot be configured. If a board has just > a i.MX6DL, well, it should not simply configured via menuconfig. It is > bound with the hardware. > > By the way, this simple patch breaks all nitrogen boards, I have to > reject it. Oops! sorry about that. I'll send a V2. > > Regards, > Stefano >> >> Thoughts? >> >> Troy >> > >
diff --git a/arch/arm/mach-imx/mx6/Kconfig b/arch/arm/mach-imx/mx6/Kconfig index 01f0121beb..2c2edaa093 100644 --- a/arch/arm/mach-imx/mx6/Kconfig +++ b/arch/arm/mach-imx/mx6/Kconfig @@ -412,6 +412,7 @@ config TARGET_NITROGEN6X imply USB_ETHER_MCS7830 imply USB_ETHER_SMSC95XX imply USB_HOST_ETHER + select MX6QDL config TARGET_OPOS6ULDEV bool "Armadeus OPOS6ULDev board"
This fixes commit <91435cd40d30> "ARM: i.MX6: exclude the ARM errata from i.MX6 UP system" for nitrogen6x. The above commit removed the errata for the board since MX6Q/MXDL/MX6S is selected via CONFIG_SYS_EXTRA_OPTIONS This restores the errata configs. Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com> --- Note: marsboard, mx6qarm2, seem to have same problem. --- arch/arm/mach-imx/mx6/Kconfig | 1 + 1 file changed, 1 insertion(+)