diff mbox series

[U-Boot] cmd: mdio/mii: add Kconfig help and allow break dependency

Message ID 20190913152502.23140-1-rfried.dev@gmail.com
State Accepted
Commit 7d9701db40895ff5271220ae852d3631b4500219
Delegated to: Joe Hershberger
Headers show
Series [U-Boot] cmd: mdio/mii: add Kconfig help and allow break dependency | expand

Commit Message

Ramon Fried Sept. 13, 2019, 3:25 p.m. UTC 
* Add Kconfig help describing the purpose of each command.
* Add CONFIG_CMD_MDIO so it could be selected individually, as
  it doesn't depend on the mii command.
* Add Kconfig imply to mii to automatically select the mdio
  command.

Signed-off-by: Ramon Fried <rfried.dev@gmail.com>
---
 cmd/Kconfig  | 18 ++++++++++++++++--
 cmd/Makefile |  4 +---
 2 files changed, 17 insertions(+), 5 deletions(-)

Comments

Joe Hershberger Sept. 13, 2019, 8:09 p.m. UTC | #1 
On Fri, Sep 13, 2019 at 10:28 AM Ramon Fried <rfried.dev@gmail.com> wrote:
>
> * Add Kconfig help describing the purpose of each command.
> * Add CONFIG_CMD_MDIO so it could be selected individually, as
>   it doesn't depend on the mii command.
> * Add Kconfig imply to mii to automatically select the mdio
>   command.
>
> Signed-off-by: Ramon Fried <rfried.dev@gmail.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
diff mbox series

Patch

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 98647f58b7..cfb3b58119 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1410,8 +1410,22 @@  config CMD_NFS
 
 config CMD_MII
 	bool "mii"
-	help
-	  Enable MII utility commands.
+	imply CMD_MDIO
+	help
+	  If set, allows 802.3(clause 22) MII Management functions interface access
+	  The management interface specified in Clause 22 provides
+	  a simple, two signal, serial interface to connect a
+	  Station Management entity and a managed PHY for providing access
+	  to management parameters and services.
+	  The interface is referred to as the MII management interface.
+
+config CMD_MDIO
+	bool "mdio"
+	depends on PHYLIB
+	help
+	  If set, allows Enable 802.3(clause 45) MDIO interface registers access
+	  The MDIO interface is orthogonal to the MII interface and extends
+	  it by adding access to more registers through indirect addressing.
 
 config CMD_PING
 	bool "ping"
diff --git a/cmd/Makefile b/cmd/Makefile
index ac843b4b16..384ddb8eaf 100644
--- a/cmd/Makefile
+++ b/cmd/Makefile
@@ -89,9 +89,7 @@  obj-$(CONFIG_CMD_MEMORY) += mem.o
 obj-$(CONFIG_CMD_IO) += io.o
 obj-$(CONFIG_CMD_MFSL) += mfsl.o
 obj-$(CONFIG_CMD_MII) += mii.o
-ifdef CONFIG_PHYLIB
-obj-$(CONFIG_CMD_MII) += mdio.o
-endif
+obj-$(CONFIG_CMD_MDIO) += mdio.o
 obj-$(CONFIG_CMD_MISC) += misc.o
 obj-$(CONFIG_CMD_MMC) += mmc.o
 obj-$(CONFIG_MP) += mp.o