| Message ID | 20190902211852.7900-1-ricardo@foundries.io |
|---|---|
| State | Accepted |
| Commit | 01fc7e7b879189b4ccb07fe616189ce171f38516 |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [U-Boot] spl: imx: only use HAB if spl fit signature is not enabled | expand |
> Subject: [PATCH] spl: imx: only use HAB if spl fit signature is not enabled > > There is no need to use HAB for FIT signature validation when > SPL_FIT_SIGNATURE is also enabled, as that will be validated via the normal > U-Boot signed FIT image flow. > > This allows having SPL validated by HAB and the payloads to follow being > validated with FIT signatures only. > > Signed-off-by: Ricardo Salveti <ricardo@foundries.io> > --- > arch/arm/mach-imx/spl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/mach-imx/spl.c b/arch/arm/mach-imx/spl.c index > 1f230aca33..a98fab8f1c 100644 > --- a/arch/arm/mach-imx/spl.c > +++ b/arch/arm/mach-imx/spl.c > @@ -261,6 +261,7 @@ __weak void __noreturn > jump_to_image_no_args(struct spl_image_info *spl_image) > } > } > > +#if !defined(CONFIG_SPL_FIT_SIGNATURE) > ulong board_spl_fit_size_align(ulong size) { > /* > @@ -285,6 +286,7 @@ void board_spl_fit_post_load(ulong load_addr, size_t > length) > hang(); > } > } > +#endif > > #endif Reviewed-by: Peng Fan <peng.fan@nxp.com> > > -- > 2.23.0
diff --git a/arch/arm/mach-imx/spl.c b/arch/arm/mach-imx/spl.c index 1f230aca33..a98fab8f1c 100644 --- a/arch/arm/mach-imx/spl.c +++ b/arch/arm/mach-imx/spl.c @@ -261,6 +261,7 @@ __weak void __noreturn jump_to_image_no_args(struct spl_image_info *spl_image) } } +#if !defined(CONFIG_SPL_FIT_SIGNATURE) ulong board_spl_fit_size_align(ulong size) { /* @@ -285,6 +286,7 @@ void board_spl_fit_post_load(ulong load_addr, size_t length) hang(); } } +#endif #endif
There is no need to use HAB for FIT signature validation when SPL_FIT_SIGNATURE is also enabled, as that will be validated via the normal U-Boot signed FIT image flow. This allows having SPL validated by HAB and the payloads to follow being validated with FIT signatures only. Signed-off-by: Ricardo Salveti <ricardo@foundries.io> --- arch/arm/mach-imx/spl.c | 2 ++ 1 file changed, 2 insertions(+)