From patchwork Tue Aug 6 15:08:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Wunderlich X-Patchwork-Id: 1142831 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=public-files.de Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="VQ9HAIPe"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 462yk808gXz9s3Z for ; Wed, 7 Aug 2019 01:10:23 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 8A63EC21E07; Tue, 6 Aug 2019 15:09:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 1082BC21E1A; Tue, 6 Aug 2019 15:09:23 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id E2EDBC21DA6; Tue, 6 Aug 2019 15:09:21 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by lists.denx.de (Postfix) with ESMTPS id 69DA3C21DA6 for ; Tue, 6 Aug 2019 15:09:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1565104150; bh=7bUzHwqMVLepKto/4yYbHA2y6a2MB1auAf2MQlDP3cA=; h=X-UI-Sender-Class:From:To:Subject:Date:In-Reply-To:References; b=VQ9HAIPe7yagwfBDuoWOSsvsa+3THBdsyVvU4I/A9aY5yvxFlRy459NnWbXI67fCz WND3zjGo4m+mOvd6Knl5SYJehkarVxlN7akIpvEd12PRugZy+hwAG3+SP0PvFMsmwy 0YKH8aygl6zKhiuCYnp+6PbFVVdNjSDYjRVQA7sA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([217.61.153.94]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MoO24-1if5Li34W0-00okye; Tue, 06 Aug 2019 17:09:10 +0200 From: Frank Wunderlich To: Albert Aribaud , Ryder Lee , Weijie Gao , GSS_MTK_Uboot_upstream , Frank Wunderlich , Simon Glass , Mark Lee , Oleksandr Rybalko , Christian Gmeiner , Tuomas Tynkkynen , Prabhakar Kushwaha , Hou Zhiqiang , Marek Vasut , Stefan Roese , Bin Meng , Bao Xiaowei , Jean-Jacques Hiblot , Neil Armstrong , Ramon Fried , Daniel Schwierzeck , u-boot@lists.denx.de Date: Tue, 6 Aug 2019 17:08:52 +0200 Message-Id: <20190806150852.5527-9-frank-w@public-files.de> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190806150852.5527-1-frank-w@public-files.de> References: <20190806150852.5527-1-frank-w@public-files.de> X-Provags-ID: V03:K1:wre2rZ4lhVmEzPZptc7J3b7jUDApWe4bYaV+egtyPfKRfAVX1cS GuwXpUNPo6bjbm8OL70bn3D4hFMPfjqyqL5JW65X0ohKc/q4pBEuKDUivnIjIoRHaOX/bqg f0Pvheb2xPaAUV4VFe6xAV7vr0C5K80KZblHypokHFffXtR5LnY4gGzkBGUefTb92k5O5yj BNXWyKxAeRQNKpIoFl+4A== X-UI-Out-Filterresults: notjunk:1; V03:K0:+cAmSK81ito=:o/bwFThX3aaiHUe3gnC0Ec A2sVvMAMxjK0gaD5Slz31bx7NIF35J/5zvAs24tv8zMGTUlSJyg2vUnY+VEL163rvC5QbK8Sw F9CMcCfanGKTrKmifv0sUix98f+GgWLJFIf86bJBUcOGJZQgBvJjeRjb7Sv4LmzgIx7GBw7gY gjleWFR6ugK0jpI+uww2rAz2twiI7Rve2BsA7qqOElmDgO9Sxx7zAf7M8RN+sWGDbwbXUUd3z epeSiFxyfPX6/GhGvx4UExjDjs7KkkKtNO2z6f791QWtVGuxJf8Y94z7G3bhqvQwpSf3pAWPQ 75519WwUCM3C3HPCrGN5jeI8wOaBhppYx9fEiVuoqEIVepXE+BMsmJLoPWgMdaLvbLLtrgnec Lr3x0cdQp21lrMmCv+6WPYigeH2gTy+V0HrNzz9fplxs0ckFKObKdc469MkCGtmgBRonsdmZb Y+3iHe9luEcMCvcy39G905H3+Fv+9gdfkCMP9T4oCvs3zNn1hUNfwZrxCC2RJruu4o/54uawx +Aj6Tx9GGh3YFsDnmHrbUjvWTzJPuqUsfOClGbJTUE/B5VxBIw8zSq+mrWCPAdLSTPYtNeU4b iL6sKjKXPE3HDnP1vWSA3VW/cDEZWoQ5fRW8EGQeUElgT7NcO8g13ATHX0Mx29UQnhvqYpCyc Z1oToiiKXK8QENnesrrEVCWmqzbX6le6//D1NSevS7ydr+l+M2j2PTosnNCRCvDxfJprroX+V D4NA320zfRt7UQQ8uz9EP2ZHRbfSb8mozMMWjNV6bX/i+tIb36jA2lTdnC+yd/ls7Z/2/EbpD cqA5FljHti4TmiEq1eSWmtuJYvMZwG5vn53xFxVYwn+q4v4mrdt3imD9vKtu3QjyF9jBjAt25 rM9HlfwsZ2oho5h/UQKJkAritQmARk8IqTzAL8A8Cm9UXGtqswqBDewKNczEzjuJ78CnBU7nd 9scUYhAty5j1Y0nxdEdIlm3B6FmYGvqJC8hkqvKvfiBnPy3mWyywN+eSzdu97IL4XO8LeDzs1 pxIOaALsjr0DJEygiZ5c+irhznz4WDhm1zcsXZBeoKYuWwblRB2eWotoxzOjWotVWwTs4dlwZ tXkphWA+ePydauA5Pacq3bkL8LESCWjMQqvTHYZLmEasjG7BknJmBEW0Q== Subject: [U-Boot] [PATCH v3 8/8] ata: ahci: Don't forget to clear upper address regs. X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Oleksandr Rybalko In 32bits mode upper bits need to be set to 0, otherwise controller will try to DMA into not existing memory and stops with error. changes since v2: none Tested-by: Frank Wunderlich Signed-off-by: Frank Wunderlich Signed-off-by: Oleksandr Rybalko --- drivers/ata/ahci.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index e3135bb75f..716f9c1c7e 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -593,10 +593,15 @@ static int ahci_port_start(struct ahci_uc_priv *uc_priv, u8 port) pp->cmd_tbl_sg = (struct ahci_sg *)(uintptr_t)virt_to_phys((void *)mem); - writel_with_flush((unsigned long)pp->cmd_slot, - port_mmio + PORT_LST_ADDR); + writel_with_flush((u32)pp->cmd_slot, port_mmio + PORT_LST_ADDR); +#ifndef CONFIG_PHYS_64BIT + writel_with_flush(0, port_mmio + PORT_LST_ADDR_HI); +#endif writel_with_flush(pp->rx_fis, port_mmio + PORT_FIS_ADDR); +#ifndef CONFIG_PHYS_64BIT + writel_with_flush(0, port_mmio + PORT_FIS_ADDR_HI); +#endif #ifdef CONFIG_SUNXI_AHCI sunxi_dma_init(port_mmio);