From patchwork Sun Aug 4 17:23:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Wunderlich X-Patchwork-Id: 1141814 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=public-files.de Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="YKGAGYTp"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 461nr26gRwz9sMr for ; Mon, 5 Aug 2019 03:26:26 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 92E62C21BE5; Sun, 4 Aug 2019 17:24:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 20EE8C21D9A; Sun, 4 Aug 2019 17:24:37 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 1A223C21DA1; Sun, 4 Aug 2019 17:24:24 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by lists.denx.de (Postfix) with ESMTPS id D6A9EC21C93 for ; Sun, 4 Aug 2019 17:24:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1564939447; bh=9cW6ABMbNlSfMLUaCwad0MWdqvcLupFFgPZLP/Dt5wo=; h=X-UI-Sender-Class:From:To:Subject:Date:In-Reply-To:References; b=YKGAGYTpP72kpfzGfukU/2RC03UlHoJ4Yc+ZbTsFEi6FfYcg3vpUWcZhGOVM9biEx JB5rWZWzC5jOLFh+huVgEwPdr4IMNk64oLeCoeNucygOJ/HUo11wkyvlU3Iav5t6X3 DVEDXlgyKAWj3ZNFoeNZJMyQObIy+CHP6+o/krg8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([217.61.144.189]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MeQ43-1hhScC2ryJ-00Q9vw; Sun, 04 Aug 2019 19:24:07 +0200 From: Frank Wunderlich To: Albert Aribaud , Christian Gmeiner , Daniel Schwierzeck , Frank Wunderlich , GSS_MTK_Uboot_upstream , Hou Zhiqiang , Jean-Jacques Hiblot , Marek Vasut , Mark Lee , Neil Armstrong , Oleksandr Rybalko , Prabhakar Kushwaha , Ramon Fried , Ryder Lee , Simon Glass , Stefan Roese , Tuomas Tynkkynen , u-boot@lists.denx.de, Weijie Gao Date: Sun, 4 Aug 2019 19:23:42 +0200 Message-Id: <20190804172342.5225-7-frank-w@public-files.de> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190804172342.5225-1-frank-w@public-files.de> References: <20190804172342.5225-1-frank-w@public-files.de> X-Provags-ID: V03:K1:XlIjazcevcVHH+7rZ/vwAu1T+NxsgaajI0mJvBzeKbyKvIXmNR9 ypguZfic5TdYp4T9/duyXhAHfG4ISpfjzcaVNeSdFZ+moZ1zzHaxqPH+iYtRqu87PjbSJ5j l6OeP/SY9uhcahzaOyhYt3NfGFopiNem0joKvjA4lZyEXxtuip9SJeOED3hUGTr9LhBdER1 eKvq75o7XrFlU9CRsi3TQ== X-UI-Out-Filterresults: notjunk:1; V03:K0:r/tQqNZbnCc=:yCb3Px/cUrq4nkb3vA5gRO W2SQXMNXdEB6y78tCpgf0yXVykImVWVHdBybMQftSW0CjdmZhZR1MT2pfMt8nwmhNHT1VVo42 HD9zzczwgvUKJ20Io6bdwf9OdcaMgLJyhAVlHQvhIHaiGCDC+sOGemVBy5+TrJsB8TIbL7nlf O9WJp/Lfaa/dpW75r/T57w4GEy2PHke53jjRBxAptgSv8zytgMqFo67VOOzDK7s63bs8EGsa+ UVten6lgz3DoXnIV0R6pkAyD7iG0AXmpH1Bcmlx4fP9EwCNBfpvTWGqiUqq2ayEzs5pjzy4UV kgDtRXhRToBpIVJU7ELVhAPGtqXNL1dFLYoueSLUS8omLzHTs7vfKz4ocjd4zWEsEEJX28smw 48JzDaFT++HocOeLQUEX3sUcZao8ZGW+1Ia9H8Z7e0L53n805kl/2v8v4HoGkstJm8uYca/KY aVWX4fR1IIGCa8qcJxhQQKbHF3NzndRH41bXnlG6xwuiAvACvTn4cPEa0nAUw0ZmZfduQNP3c gjGINr13xnpW4JZV4wJXSi3oMPNJQH6hz7O7brbKnraWlqnU9jdAMUciFWCCeOrzUcvEFmtvU RqktXa8CPfv1Y45aN0yJY7yoGGmpwrxdl16qGuIZCokmd1ZFfk22m5kC86U3qN/c9iQGfCCmZ Im+6zHTTOGmjbzLdMrjvl0McLETwO+u0Vo5o3aXNOk5HgwKMY+H0z3iDEz2ZIEEmw371KDI7j EaeXnlo+7kDIGQXMcipsOeFpUU/mN/8fzkkrPNafVYE2aM7RV+haeej91RGrv1fyO5UbE5Bee iLsZxylwQvjMUdvwWR2frfUuPpsJ61fBTgcmG76cGWrPX3CsnbinACmt89sPCUI1wAbZwIm6h ARKW+oad+1pJ+qP+n+d6nrGlEyvtdvZbKT5szlMDoyT2/b/v7O7vi2aEj/ZwAaFc8GAUU5kbK vuZ/GeW5/7N0nbt5lIpNL6O3VEOjlvueVWItELVchZwZr9gmyMIkZ0NKD2UiRK7BfbYB7hN4G i/aAN6cqkm/edNLOgzyn+oNxzz8FQLr2IRT8Uo3UAg45XcyC5a+KyJwWJ1AXXOkqWRavpEtzk K8oc5EkZqeaZoHWrfFsVRpfqnsKZm16pPrA8mibLtV2SPoeg3oBr49kOA== Subject: [U-Boot] [PATCH v2 6/6] ata: ahci: Don't forget to clear upper address regs. X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Oleksandr Rybalko In 32bits mode upper bits need to be set to 0, otherwise controller will try to DMA into not existing memory and stops with error. Tested-by: Frank Wunderlich Signed-off-by: Frank Wunderlich Signed-off-by: Oleksandr Rybalko --- drivers/ata/ahci.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index e3135bb75f..716f9c1c7e 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -593,10 +593,15 @@ static int ahci_port_start(struct ahci_uc_priv *uc_priv, u8 port) pp->cmd_tbl_sg = (struct ahci_sg *)(uintptr_t)virt_to_phys((void *)mem); - writel_with_flush((unsigned long)pp->cmd_slot, - port_mmio + PORT_LST_ADDR); + writel_with_flush((u32)pp->cmd_slot, port_mmio + PORT_LST_ADDR); +#ifndef CONFIG_PHYS_64BIT + writel_with_flush(0, port_mmio + PORT_LST_ADDR_HI); +#endif writel_with_flush(pp->rx_fis, port_mmio + PORT_FIS_ADDR); +#ifndef CONFIG_PHYS_64BIT + writel_with_flush(0, port_mmio + PORT_FIS_ADDR_HI); +#endif #ifdef CONFIG_SUNXI_AHCI sunxi_dma_init(port_mmio);