From patchwork Wed Jul 31 11:51:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Wunderlich X-Patchwork-Id: 1139701 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=public-files.de Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="aeF7Flrr"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 45zBdv2yYvz9s00 for ; Wed, 31 Jul 2019 21:53:39 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id E3CA6C21E26; Wed, 31 Jul 2019 11:52:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 096D8C21E34; Wed, 31 Jul 2019 11:52:44 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 9D5AFC21E02; Wed, 31 Jul 2019 11:52:18 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by lists.denx.de (Postfix) with ESMTPS id CCD78C21E1B for ; Wed, 31 Jul 2019 11:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1564573917; bh=9cW6ABMbNlSfMLUaCwad0MWdqvcLupFFgPZLP/Dt5wo=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=aeF7FlrrmWoTWH0t20wnF7xcXM+jY1FMg/YZivwUyuMPrgMx6uyOHPxuHItqFYSN6 azs1eCihGzDo4zkmDc9sUtfDGQdJFVxsJF4eDJVPT5wY9GFL/jIPUsb6igU0bIw5n0 LWKziSUz3vGCX9M6pGOZJxLtoi3pAEbs6+za6Rww= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([217.61.145.165]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MRXVc-1hmItA3Zay-00Scbj; Wed, 31 Jul 2019 13:51:57 +0200 From: Frank Wunderlich To: Albert Aribaud , Bao Xiaowei , Bin Meng , Christian Gmeiner , Hou Zhiqiang , Marek Vasut , Mark Lee , Oleksandr Rybalko , Prabhakar Kushwaha , Ryder Lee , Simon Glass , Stefan Roese , Tuomas Tynkkynen , u-boot@lists.denx.de, Weijie Gao Date: Wed, 31 Jul 2019 13:51:43 +0200 Message-Id: <20190731115145.22095-3-frank-w@public-files.de> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190731115145.22095-1-frank-w@public-files.de> References: <20190731115145.22095-1-frank-w@public-files.de> X-Provags-ID: V03:K1:WLwXme2Y0SI6m7AB3dtHhJofxb+YWraucW3eI0xU96Gtbr9f1Pv aeSdbDruTHqjtSSIgAw0RG3A0FEeCUbDNYRM03QwDXwhrTOTWFsCv7hW6/3e4aVUB4WsTBr 2G+2pZ5Mk15kgGieP9ZOIBBmVqntHQ7NXh14HgGWD/18yDy/puTR1mqZdoJh7Y7zoZa7rUK 77CCYT6xdNvHvUx79CTeQ== X-UI-Out-Filterresults: notjunk:1; V03:K0:znIvqp2CCfk=:qPPWXo9lBJRh1Oaqkgn/hz 29LrOQFNsqh05Re0zjuWq3dl47YAPpaBInk3gR3/FbIZFJOGS4jnHgBEnJsGh5Xe3PZZEvSvu w4sum1Kwah9RQXa+NT9PqQSvMpqOsUNTORuvdSEsch5uNAGPRL4enwONu9wjaQPG4mSKLl78q p6gWDYJGu9LrXlfN4QPlONV63yDQSzH4iYjAAOo2riPj5xCgMimRmrne5Bw0mDRflFQe+liJb 8H5oPhaHQAsGmhq1cR3EAhKycdeaNMlSExNQKJKUweiutQjg9Lcb5/RLWNTUrDELmRQ0MCFKj 2DLiaCi1fs/AHXh1G4ihJmkkbPL2pG4r5K7MLdvuNAWYsCvC3KKj4iKilh/+BH+PL4pGKlhjr AsGYkUH6pPnvO59rLvPJXKqSzbB1g0T+1NUegH6YPP7E2SDsGl6HTfcVIylKBXf5OwUvnASKx 4qgpXq/f5n6u5Qj1Ar30XSsv5tHyizQbb3dWKvJN4ntInsSFRH7IA/a8eWsTkMQZ7oDedMGzG zYb1KLlDQpdF64yeySjyR6atUFrkPmzZLL1ssq+QW6Hs/CxD7eq4E/clPbVdAWIxVaCFRTMQb 2r1d2tSQV8nkMa33f82iZv2yTEdFNzlxjGCz+/Tp1qK4X2VL6/WFOo31qCcS3mUoGp6xoVgcw YUvGN7pbt6YtLh1BVLaoJeugGmit7qmToJ7fAC8vvpLmEQrY0mQyQGlvdqJSZtA5/qgr4lc+U XJJUgb+Ro2mDiCtEQeG4LhL+eMygMn4f1T+NYOShjf1Qlf8te7nfMDZXpbG5Lx8pdrhfDluCF 46bFAlM+N5NI8l4QspeEbyoGAG7g1nvy5YfH7uIwM/GvjG76RV/w/9/mcjv2/tep1T4Pvb1Iz NlX5tx7TD1cSGB36L6eNf0qsGip/u0wAV3VJH72vLJlJrbSar7uYtSr6XRQtskBo5fvlmw5gc TrnSQif3ZW22aL5cDCmIm6Blp06Yxh1dzJxM5rFBMnt26oIHl8l8FUEuTRIi4MSyEyo3O3PMf 2Qpt9J/VtV2FYr3EYBbzbbwOAXqJsFbjmcRl/PEFQlwABC0Wj0yhnesBK4FZGPz6E2Lpke8Ku c4iJGKd8nNGREU= Subject: [U-Boot] [PATCH 2/4] ata: ahci: Don't forget to clear upper address regs. X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Oleksandr Rybalko In 32bits mode upper bits need to be set to 0, otherwise controller will try to DMA into not existing memory and stops with error. Tested-by: Frank Wunderlich Signed-off-by: Frank Wunderlich Signed-off-by: Oleksandr Rybalko --- drivers/ata/ahci.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index e3135bb75f..716f9c1c7e 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -593,10 +593,15 @@ static int ahci_port_start(struct ahci_uc_priv *uc_priv, u8 port) pp->cmd_tbl_sg = (struct ahci_sg *)(uintptr_t)virt_to_phys((void *)mem); - writel_with_flush((unsigned long)pp->cmd_slot, - port_mmio + PORT_LST_ADDR); + writel_with_flush((u32)pp->cmd_slot, port_mmio + PORT_LST_ADDR); +#ifndef CONFIG_PHYS_64BIT + writel_with_flush(0, port_mmio + PORT_LST_ADDR_HI); +#endif writel_with_flush(pp->rx_fis, port_mmio + PORT_FIS_ADDR); +#ifndef CONFIG_PHYS_64BIT + writel_with_flush(0, port_mmio + PORT_FIS_ADDR_HI); +#endif #ifdef CONFIG_SUNXI_AHCI sunxi_dma_init(port_mmio);