From patchwork Wed Jul 24 04:09:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1136029 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="bF3p4nk6"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="TLZM3p3F"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 45thjg4dmvz9s8m for ; Wed, 24 Jul 2019 14:11:19 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 43DC0C21DAF; Wed, 24 Jul 2019 04:10:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 965F0C21D8E; Wed, 24 Jul 2019 04:10:17 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id B6CC8C21DFB; Wed, 24 Jul 2019 04:09:45 +0000 (UTC) Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by lists.denx.de (Postfix) with ESMTPS id E9552C21DAF for ; Wed, 24 Jul 2019 04:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1563941382; x=1595477382; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=K/ncpSfLVpHgWyUBP5DkTqWtr3qnmpo5x4pMQxZLpAA=; b=bF3p4nk64SV2wJUPZQXmGLEdtSjGbPERLDhCm7w+ivxI5mc/CMphdxzW TJx4nM4dxAV4Fi+eavF2MTLBlXM11UjQx3ecbXSYRucH9JPrUP3dp1RzN 96DU/GytBvIpr806tpsh2DaK5rq3LHqxEhkWgGSx2vygqCS5v8tNXohPG sjy97e4gJB+24s8BLWWyuWAvb5tUYydUqLgmQ1DlYmh3kW1kIsg2sd6/U oAS11A4wllgTJthzKuLxg7Y3OfYGO/kqO5DSVOfX7RRqZKtNbL48hKKPr miqZbSwK3hcfyhHf/XaScHmTyYNJQWbW9cFVwHP10JG8qpfN6FMR+nhDB Q==; IronPort-SDR: EoVEvhV9VFqsHH/yFrDSAPUIF3UBd1i4VVs1yVm4qX0HuEkmOhn3z1npIczSTRz1jB+GJcvSba GPF/66y5KJw5u/htn7kWrQIn5QdB8PX1L/UUZC1FIuDVV3grLvShkICaczmeulDG8lS3tnB76r obaBp19s4fw9/BHZ/MDeybHxqsd2HBtCPyUEMwB0/vFqaBdfQNHevWknVyNw8FCmihlu9wrTeb Sp9s0H+w+wNAcPc5MyvyAKLBN7OQ/qRs8YNVJrsxvDZ4ChIas5rh3nRoiFZdfiPog2w5ESsHD3 B8g= X-IronPort-AV: E=Sophos;i="5.64,300,1559491200"; d="scan'208";a="220305715" Received: from mail-co1nam05lp2058.outbound.protection.outlook.com (HELO NAM05-CO1-obe.outbound.protection.outlook.com) ([104.47.48.58]) by ob1.hgst.iphmx.com with ESMTP; 24 Jul 2019 12:09:39 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lpJhrV31lPrzZJz/wFTMMEDjrXBBIuyY0heDjaN9KklBGqLyLkWmP1X4i63UbTq+u92q8uTup4lBIuUSCpZDMeVTy4gRlwWgHmvB8hGe5uPbwH2gjSHD0UQDbQ4l/ANgyJqwAEXGa4W8apxVMGiH2SvKP7QjsdLi2qxMfwXGh0Ygog8Fgj1MTGm5gD4bFqsUQ+80cx9vaCEQcgr2+SO334TAdfm/aPtXF3/W7KbSKEhM31ItJ30xDvMxTVGPGJtbBr5vIn3z4kOUXkIUlMmO04+eX1SMB1jjgT/txQekRAIxoZ9I0YG80s8i15kTtzhY+kGQaSDOUQL3nLman1+H7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ndO4Gd+H8xqzRW4QlidtGadN2zuieSYry+u4m05wY3w=; b=S5SX8e/MpBfXPzx7yxInoR2515Y69DK7zDobvaPFOxBRQT09BJ96vDuklRf8tOL73LKtXyPOOKaWebrIMCl+J/Z0Ne5YJHjvoIlCg3JkZoubdfdwj2KKbmoHr7tktneI1TMZ4pFdhdvK7ODz9ukrCZDnwBEutbz3sFVCHLD9g8agiNayuVvQy0TrZsUVs8LUewrfFvh5DsSqR75QnbGOLLFYEhSyjWC17QdV9rp6wLCzvB3f6llraaLtiAH+14R5OzQlWJ/Wp7I5ULzAUX/j3Sil4Wy/TbKKIrnxNvgL2beolPH6NAyjj7QEJ6mS/YTyvKpNJkmWTcmrbfnTJj/CRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ndO4Gd+H8xqzRW4QlidtGadN2zuieSYry+u4m05wY3w=; b=TLZM3p3FJwBB7NcY9bH9zguRMrUOzLyyXpz3OhF4YoPh42UtXN/XFk2Pd59l/LSZohgoE3iI8DLtoCb87pcOnQhcXHRGIxD8Qkf1/PE15l9uaNDZ11J4LosZHIs1QqjTxkl7920Ow6l/64ag1LA38jQUCnjAVHwZWR0qS/QLKhk= Received: from MN2PR04MB6061.namprd04.prod.outlook.com (20.178.246.15) by MN2PR04MB5582.namprd04.prod.outlook.com (20.178.248.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.17; Wed, 24 Jul 2019 04:09:38 +0000 Received: from MN2PR04MB6061.namprd04.prod.outlook.com ([fe80::a815:e61a:b4aa:60c8]) by MN2PR04MB6061.namprd04.prod.outlook.com ([fe80::a815:e61a:b4aa:60c8%7]) with mapi id 15.20.2094.013; Wed, 24 Jul 2019 04:09:38 +0000 From: Anup Patel To: Joe Hershberger , Rick Chen , Bin Meng , Lukas Auer Thread-Topic: [PATCH v11 2/4] net: macb: Fix check for little-endian system in gmac_configure_dma() Thread-Index: AQHVQdWb6Pguru+FAkyFY34T0GayhA== Date: Wed, 24 Jul 2019 04:09:37 +0000 Message-ID: <20190724040902.9714-3-anup.patel@wdc.com> References: <20190724040902.9714-1-anup.patel@wdc.com> In-Reply-To: <20190724040902.9714-1-anup.patel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MA1PR0101CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:22::13) To MN2PR04MB6061.namprd04.prod.outlook.com (2603:10b6:208:d8::15) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anup.Patel@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [129.253.179.161] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3a4117ed-45b7-4da1-d93c-08d70fecbe51 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:MN2PR04MB5582; x-ms-traffictypediagnostic: MN2PR04MB5582: x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:216; x-forefront-prvs: 0108A997B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(4636009)(376002)(136003)(39860400002)(366004)(396003)(346002)(199004)(189003)(7736002)(81166006)(6116002)(478600001)(6436002)(8676002)(6486002)(99286004)(110136005)(4326008)(52116002)(44832011)(486006)(14454004)(3846002)(86362001)(76176011)(2906002)(54906003)(68736007)(66066001)(316002)(25786009)(6512007)(256004)(53936002)(26005)(305945005)(5660300002)(50226002)(102836004)(1076003)(476003)(64756008)(66476007)(66446008)(66556008)(8936002)(446003)(36756003)(66946007)(386003)(71190400001)(71200400001)(81156014)(186003)(11346002)(6506007)(2616005); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR04MB5582; H:MN2PR04MB6061.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: b1o83Uzyz07fi9FSZ16drhq+c6FMe9gmNcvcqVgOQVwIzZAYmiCr5yy5eVgt/Sc6G70np0WfpiXBhCj4XQkUtBUHjQ4dVPShfTq3XQXhJdtfTvZL6OcMoSwxgoOBMb+j0suNbgjWAR3RQPupev5QfAaeDmVB0Ubm3AnIgtHgUlQ2MQyNa0cqUq6YWJpneLcy5IVDtydgFtFkI+Wrc2CWFoafc+SlLZh2wVCg9k+y6yA9DsZs14T2D/xMsLSe9gj9j2UhsUnBO6mw16WOWAxQdtcYuTTRrlMaCNuC9702R0p5k/WQJ5aRnlWRYxnybOdUUXPG8T5jl4M5Nemt3PM5cEZtI2HQsTU1nX6CTfCyD91pfCUNN8pK2g3Q1rrumad71bnEhI2G4RnmwiKxbRvJ1jxQQgKK94Lzwx7ogyhrL3A= MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a4117ed-45b7-4da1-d93c-08d70fecbe51 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2019 04:09:37.8486 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Anup.Patel@wdc.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5582 Cc: U-Boot Mailing List , Palmer Dabbelt , Alistair Francis Subject: [U-Boot] [PATCH v11 2/4] net: macb: Fix check for little-endian system in gmac_configure_dma() X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Instead of depending on CONFIG_SYS_LITTLE_ENDIAN, we check at runtime whether underlying system is little-endian or big-endian. This way we are not dependent on any U-Boot specific OR compiler specific macro to check system endianness. Signed-off-by: Anup Patel Reviewed-by: Bin Meng Reviewed-by: Ramon Fried Acked-by: Joe Hershberger --- drivers/net/macb.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/macb.c b/drivers/net/macb.c index a2f5b7f813..956e688548 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c @@ -84,6 +84,8 @@ struct macb_dma_desc { struct macb_device { void *regs; + bool is_big_endian; + const struct macb_config *config; unsigned int rx_tail; @@ -743,11 +745,10 @@ static void gmac_configure_dma(struct macb_device *macb) dmacfg |= GEM_BIT(TXPBMS) | GEM_BF(RXBMS, -1L); dmacfg &= ~GEM_BIT(ENDIA_PKT); -#ifdef CONFIG_SYS_LITTLE_ENDIAN - dmacfg &= ~GEM_BIT(ENDIA_DESC); -#else + if (macb->is_big_endian) dmacfg |= GEM_BIT(ENDIA_DESC); /* CPU in big endian */ -#endif + else + dmacfg &= ~GEM_BIT(ENDIA_DESC); dmacfg &= ~GEM_BIT(ADDR64); gem_writel(macb, DMACFG, dmacfg); @@ -1222,6 +1223,8 @@ static int macb_eth_probe(struct udevice *dev) macb->regs = (void *)pdata->iobase; + macb->is_big_endian = (cpu_to_be32(0x12345678) == 0x12345678); + macb->config = (struct macb_config *)dev_get_driver_data(dev); if (!macb->config) macb->config = &default_gem_config;