From patchwork Mon Jul 22 09:05:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Opaniuk X-Patchwork-Id: 1134795 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FrXzzvPR"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 45scD025nDz9s00 for ; Mon, 22 Jul 2019 19:45:20 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id DF29EC21FA5; Mon, 22 Jul 2019 09:45:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 8DAC5C21F89; Mon, 22 Jul 2019 09:22:35 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 5D782C21F84; Mon, 22 Jul 2019 09:22:33 +0000 (UTC) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by lists.denx.de (Postfix) with ESMTPS id 18F12C21FDB for ; Mon, 22 Jul 2019 09:05:15 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id s15so13138321wmj.3 for ; Mon, 22 Jul 2019 02:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=9Bix0amvKkidc2hfo8d3g7LZr3BZh0AKBVfikO8tWYM=; b=FrXzzvPRAlm6aajt9RXKrx7/YT37F1STDEGgSSxwoYn4GjBoWZS4Z8zrRoqUVA+K04 YHdUnjurFaCgQYjJ7GSKrRHvJJCDce2laxUnqEBcdsV1ncxXtY+kR0oFb079Xt1t28uC 5vWFz595Dm5gBudtmSdDC3AR2Ok8PRQy5N7vG2IPQjfRvl3bQO5iB7lJTUOLclKBplGB jC/PuZjPtNXMBZHptooB0zqPEbrKt5N3zXBSBdLs5k0YUI5suiAOZ/LyF5MwNunwMqKS VuhpE1J7av5q5XKRhXR1iLigfKT8VORLvTKR5AS5D3WclgNdV/0jZfQMGvWBwx0D8Bj8 A1tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9Bix0amvKkidc2hfo8d3g7LZr3BZh0AKBVfikO8tWYM=; b=psWXV5zdEynelPHWuZzl+4wn2kgeheRkJytt/uVawTFj49xr5npssIg0qj5j2VbOm0 RJsm2UmFD5xH7w4AgTJUZHvY5n2N5xJI+yvnFc1c4IoL2c5GjmcU94cAFsBHKTdvZqC+ wI1VIrgArEpC4O/UO3tNzMu+/f18haZjpTZ7EwtQqdr9cPv1kd/vHb/0memHqjBiUK45 1H0c7BwxF3T3fIAWKnlJkgiE6Yt1NDOkOjXd83ZNZ9IB5btqwqZUiY9mvR1kyDCHecGX qBwUXsZzgFExNLz5vHW/8a4oGgOJuZJLt3Z9LwJLkb9MZt2I8xzr2SWtSxocRJ//I65I A7dw== X-Gm-Message-State: APjAAAXYkp5YFgbBW2iXuR0Q6JViU3WC11uyliYjwh5GNKqr83pCYEZ4 s6oU1hbTyuA1CWBwt50MuU094F/y X-Google-Smtp-Source: APXvYqyp51ODEluxAklLo7pxv+rnyejFsW/6hJHk76DXG3MB6D9/3OBeyBDo21LgCG8DGRYHN3/Kmw== X-Received: by 2002:a1c:7e90:: with SMTP id z138mr60662057wmc.128.1563786314342; Mon, 22 Jul 2019 02:05:14 -0700 (PDT) Received: from localhost ([194.105.145.90]) by smtp.gmail.com with ESMTPSA id v65sm43816297wme.31.2019.07.22.02.05.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jul 2019 02:05:13 -0700 (PDT) From: Igor Opaniuk To: u-boot@lists.denx.de Date: Mon, 22 Jul 2019 12:05:06 +0300 Message-Id: <20190722090506.28854-1-igor.opaniuk@gmail.com> X-Mailer: git-send-email 2.17.1 Cc: Igor Opaniuk , Stefan Agner , Marcel Ziswiler , Max Krummenacher Subject: [U-Boot] [PATCH v1] colibri_imx7: provide proper node name to pmic_get X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Igor Opaniuk Implementation of pmic_get() uses uclass_find_device_by_name(), which behaviour was changed in 4213609cc7 ("drivers: core: use strcmp when find device by name"). Now we have to supply full node name with unit address. Fixes boot issue: U-Boot 2019.07-00788-g0ef6e69a1e-dirty (Jul 19 2019 - 15:27:02 +0300) CPU: Freescale i.MX7D rev1.3 1000 MHz (running at 792 MHz) CPU: Extended Commercial temperature grade (-20C to 105C) at 41C Reset cause: POR DRAM: 512 MiB initcall sequence 9ffd3a4c failed at call 87803c61 (err=-19) ERROR Please RESET the board Fixes: 4213609cc7("drivers: core: use strcmp when find device by name") Signed-off-by: Igor Opaniuk Reviewed-by: Oleksandr Suvorov --- board/toradex/colibri_imx7/colibri_imx7.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/board/toradex/colibri_imx7/colibri_imx7.c b/board/toradex/colibri_imx7/colibri_imx7.c index 0eb83474c4..c001316591 100644 --- a/board/toradex/colibri_imx7/colibri_imx7.c +++ b/board/toradex/colibri_imx7/colibri_imx7.c @@ -274,7 +274,7 @@ int power_init_board(void) int ret; - ret = pmic_get("rn5t567", &dev); + ret = pmic_get("rn5t567@33", &dev); if (ret) return ret; ver = pmic_reg_read(dev, RN5T567_LSIVER); @@ -308,7 +308,7 @@ void reset_cpu(ulong addr) { struct udevice *dev; - pmic_get("rn5t567", &dev); + pmic_get("rn5t567@33", &dev); /* Use PMIC to reset, set REPWRTIM to 0 and REPWRON to 1 */ pmic_reg_write(dev, RN5T567_REPCNT, 0x1);