From patchwork Mon Jul 22 07:38:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1134753 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="WaRuzTBc"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="L0ptiPCP"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 45sYk16y3Pz9s3l for ; Mon, 22 Jul 2019 17:52:41 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id A46CEC21E88; Mon, 22 Jul 2019 07:52:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id D245AC21D83; Mon, 22 Jul 2019 07:39:13 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 0D529C21C6A; Mon, 22 Jul 2019 07:39:13 +0000 (UTC) Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by lists.denx.de (Postfix) with ESMTPS id EA22BC21BE5 for ; Mon, 22 Jul 2019 07:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1563781099; x=1595317099; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=obSDugqVYUkXbwCBDnFKE6FFOmPUeVW/F6R646qTFlg=; b=WaRuzTBcO6zJgTQuJNuFPdowvzcbb6m3AaVpr4lj3+NU23HsMuJBriP9 jlTzTM/SjBM9Q8Hwgmkg3c6Lr8U9Xa77t/P+G8P87L743rdmyf6i1a5// fYIM/yhIN2gwGUHcG/JSVl7V8X5Nr+1jd7xGJO26R7hfHBEyOtRdDlgbK cJSNi+Gyq89tghN4j3LCLjfMXl6gjgDcdxWHlCE9x9JGwzWQ66qWFGt/a 4rqurBTWgTVYU+O/RJoB+Ux2ReBFtSSGe0b39w+kreS0dE4pMwhIW9B65 T13pWQxq5xLaMLIfxFZTxvQnCtkKrP83gJgzfFVupIgPX+jUuwu2dRtmG A==; IronPort-SDR: gVnKq/U8xLjdfSJfi/+rkYrcIrgv9F6RoJNxZCUj9C1/Gnuw/UFtccOI0HtDEy65t5Qvl5bWhc oic8Qb0IiHmwJZ5615ZI/NU4xH11rsUWRTWWp1aCsUxJAd96StSDhaoL0EPeJL3GJDop/J1e6O EMaEa5F+0re+C2TtOTx5SkGtHIynhPgitwALt9y67VAK6zG1n/p9p4VTf3fhXWw61n8nOAw3Ko Fza8MWxBX6LA9Qr1OOiZOkrLrWY9eoj37rIkqABilHbWj0h/WlLERXc/pUgRC4NlkLO3sbH2TY 5JA= X-IronPort-AV: E=Sophos;i="5.64,294,1559491200"; d="scan'208";a="118406660" Received: from mail-sn1nam01lp2059.outbound.protection.outlook.com (HELO NAM01-SN1-obe.outbound.protection.outlook.com) ([104.47.32.59]) by ob1.hgst.iphmx.com with ESMTP; 22 Jul 2019 15:38:14 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ahELRx2gtNQAhoVtlxyxBIZ4nLMZ9yx9+rdyN9zDw6uz+i4VDRjqXkKVKHlAZar+8ep2h5nEblWTAq2SPuGLq81yuv2vMCz5SJxCQ0zO9qFR82vchtIE4UFqF5ORzLXroEOfEQnSFhcKzn0yNOyAJvXHyfW6wQHzXI2ESg0RZc8mMQFozzA+oXF/ZWAope7unOOvfE5RwGkb5dGibl7vafJaDCRx+0wGgzNeIOm0Kj924NL+g6eGYcXLqBSK7VKSMf7XVgqRwUq0bUsaGZh4dB8xHWAm1dNVWd5x4Gd7TmnPf9e56WKDh+MCThKKsPMbo6EaNKUDVelykkegKNsbQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f9BP+OwSsJOGTwBTvL3OfKn3UlDm9w87z03jSFI1vAs=; b=GrgfriyCW+c1JHDYzRMOMDWNKhvrc7Hk41VIk3vwz7ETnoDgnjgiFhRQOpw4QE/v93zQFgCXvOJ1S2jVdhpOQFI4loHzMgTc/iJp+xYJMAFEUZqVnOlw0mHAhhtu0O1I4QCOnsDy4UDaHfVt7iJ+YeHkfrSfDpohLw9Mexy/zI9AuxBg2Q21wUcbtUxRXsaD6OM5gYAPGQDfBpdHZWzFuG6twJFbZ7mbiRIphNn7Z3auNyRpRTmHBAVkbiJLFgU63NwP+ytXv66IQqisgtRlAF1BHJYxoS2ytxkpKHPYknuA28E+y1e04M1rsdl1QfHjK/9s1vndUfrde2q2KJND1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f9BP+OwSsJOGTwBTvL3OfKn3UlDm9w87z03jSFI1vAs=; b=L0ptiPCPmvch9pNgzqW3ZPwXDDCPKV7jSrWnAQnJl9n4uxBJ7z9WRmfFzEGurEHMT0qtO7CNIh+RV7wAosuQVMS1ODPCCroN9fZpm+WRvmUJpZ+rj6jYV837f+EhbbEjDXIaiXgDe/8W17D8t/SOIPku8rL5FSE/3r9BOJ3izFc= Received: from MN2PR04MB6061.namprd04.prod.outlook.com (20.178.246.15) by MN2PR04MB6768.namprd04.prod.outlook.com (10.186.147.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.16; Mon, 22 Jul 2019 07:38:12 +0000 Received: from MN2PR04MB6061.namprd04.prod.outlook.com ([fe80::a815:e61a:b4aa:60c8]) by MN2PR04MB6061.namprd04.prod.outlook.com ([fe80::a815:e61a:b4aa:60c8%7]) with mapi id 15.20.2094.013; Mon, 22 Jul 2019 07:38:12 +0000 From: Anup Patel To: Joe Hershberger , Rick Chen , Bin Meng , Lukas Auer Thread-Topic: [PATCH v10 2/4] net: macb: Fix check for little-endian system in gmac_configure_dma() Thread-Index: AQHVQGBqsQ/V+0SxBEqGPevyMOkYUA== Date: Mon, 22 Jul 2019 07:38:11 +0000 Message-ID: <20190722073732.2616-3-anup.patel@wdc.com> References: <20190722073732.2616-1-anup.patel@wdc.com> In-Reply-To: <20190722073732.2616-1-anup.patel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: TY2PR02CA0025.apcprd02.prod.outlook.com (2603:1096:404:a6::13) To MN2PR04MB6061.namprd04.prod.outlook.com (2603:10b6:208:d8::15) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anup.Patel@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [129.253.179.161] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ca5738a2-13c6-44b2-fee3-08d70e778c83 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:MN2PR04MB6768; x-ms-traffictypediagnostic: MN2PR04MB6768: x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:216; x-forefront-prvs: 01068D0A20 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(4636009)(396003)(39860400002)(136003)(346002)(376002)(366004)(189003)(199004)(66556008)(81166006)(81156014)(66946007)(5660300002)(66446008)(8676002)(3846002)(8936002)(66476007)(14454004)(4326008)(64756008)(68736007)(6512007)(71190400001)(50226002)(71200400001)(53936002)(86362001)(305945005)(6486002)(76176011)(102836004)(7736002)(2906002)(54906003)(110136005)(66066001)(316002)(36756003)(6436002)(256004)(446003)(1076003)(25786009)(11346002)(6116002)(6506007)(26005)(52116002)(486006)(44832011)(99286004)(478600001)(186003)(386003)(2616005)(476003); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR04MB6768; H:MN2PR04MB6061.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: XtfyLeZ353ZghJZOSteWSrwCIZQHISND1HVmd9BbCJRBzz/l9ZjKg9pm0XmiVmIKRfuZJzBDzm4+IzZN6c3u4E1u7R97dsAwJCfkglBoet5+aaR+QTk/BF8CbUTvD9kOmfYWMhS9PL2DARs6fvmPX/INeHbW5mCLvr6Q4tMqDqmlc7Hkbl41dOWK3xJMO5DzZwU8pv2GSLgvkJJiG8nOHy+2UqJePGMHIx2mcn/YL9coxZq8HUSIIeLeQtod7J072btNo/TVXNcOmZLMRO6zaIaQcJCV6AJXYAoGX91nZUTtlRoyW0gPazqfcy3xV+FqaXw94pNuIlIp6PN+WZpk7Z+DRtaNFP6Sn/wo6Dfhr/PjpsQ+Ehf0ah/WUYmuIgxLlxyrak5Putr6eyl8O4G4zf/LpFD8GCem/GMA4vWBJAM= MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca5738a2-13c6-44b2-fee3-08d70e778c83 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2019 07:38:12.0040 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Anup.Patel@wdc.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6768 Cc: U-Boot Mailing List , Palmer Dabbelt , Alistair Francis Subject: [U-Boot] [PATCH v10 2/4] net: macb: Fix check for little-endian system in gmac_configure_dma() X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Instead of depending on CONFIG_SYS_LITTLE_ENDIAN, we check at runtime whether underlying system is little-endian or big-endian. This way we are not dependent on any U-Boot specific OR compiler specific macro to check system endianness. Signed-off-by: Anup Patel Reviewed-by: Bin Meng Reviewed-by: Ramon Fried --- drivers/net/macb.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 3db5597373..27a6c6db2b 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c @@ -84,6 +84,8 @@ struct macb_dma_desc { struct macb_device { void *regs; + bool is_big_endian; + const struct macb_config *config; unsigned int rx_tail; @@ -743,11 +745,10 @@ static void gmac_configure_dma(struct macb_device *macb) dmacfg |= GEM_BIT(TXPBMS) | GEM_BF(RXBMS, -1L); dmacfg &= ~GEM_BIT(ENDIA_PKT); -#ifdef CONFIG_SYS_LITTLE_ENDIAN - dmacfg &= ~GEM_BIT(ENDIA_DESC); -#else + if (macb->is_big_endian) dmacfg |= GEM_BIT(ENDIA_DESC); /* CPU in big endian */ -#endif + else + dmacfg &= ~GEM_BIT(ENDIA_DESC); dmacfg &= ~GEM_BIT(ADDR64); gem_writel(macb, DMACFG, dmacfg); @@ -1221,6 +1222,9 @@ static int macb_eth_probe(struct udevice *dev) macb->regs = (void *)pdata->iobase; + macb->is_big_endian = (cpu_to_be32(0x12345678) == 0x12345678) ? + true : false; + macb->config = (struct macb_config *)dev_get_driver_data(dev); if (!macb->config) macb->config = &default_gem_config;