From patchwork Wed Jul 17 04:23:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1133090 X-Patchwork-Delegate: jagannadh.teki@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="Ao7tfD3f"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="dL/327dM"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 45pPLT6j9Qz9sLt for ; Wed, 17 Jul 2019 14:24:49 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 7C26CC21E36; Wed, 17 Jul 2019 04:23:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id CB58DC21DED; Wed, 17 Jul 2019 04:23:50 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id F0F30C21D72; Wed, 17 Jul 2019 04:23:45 +0000 (UTC) Received: from esa6.hgst.iphmx.com (esa6.hgst.iphmx.com [216.71.154.45]) by lists.denx.de (Postfix) with ESMTPS id 83E3BC21E13 for ; Wed, 17 Jul 2019 04:23:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1563337422; x=1594873422; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=GFkMURDIWgcUvojanF2yKFx3MgIpNw9atItEoZ42F4U=; b=Ao7tfD3f6P2eGg+etMJ2yEoFBP9rnTNAJCYIkumN5+WrjQAF6I/ePww1 oA/zVEMNJvSbaYO/Nbvs8xo7R8qBqaniA7b448r7569A7rI0Wt1NITJg+ Stogbu8Zuaee9yp15I5pl5y3IGXx8vgeYGoqFMlT1S5ZZWR+YRtsCxw3d WZX4Fq2nAHXQaAawcQNQJ5evQWmiY+9Urm0L0rPhxcEaFzgMG3YdRrLxI Ze1Y8UKe6lXOgegyONfBRdX0PZe+hHrfT+Hvrv8qNN+gYny40n+ThhBpF JtFo2XfUlkCG8kFjRuHE7juvENa4y+MV8jctNoygm9sKPpR9J3cuTAgDH A==; IronPort-SDR: pY5TBYG67oiDSfYQzyUpiZVjoajoJZGYVVirgLUPcj2XuWDtqBOzKgS6csTQGVrzX+8Wy7PLyg u0V9LQUkVXCioEE3yjFAXvnuwyNqLTjACpJ2JUR1ZiMMK59ZTu/+IPY2HtC96Yq9j7qrwNN+2c jz4XWykPgPa6E06jMv4N149f1SLSdQyuSS3pTOzeBeg4eyUjIvWLVy1mlQe6GYtytllTZmi+py e1w1wSSDQFYWDiBkYcfCSuJiIHtzlQULRT65CVjnGEaoM7dhhuJatTQvUAq4TKSpW5k+LvKS6h o5c= X-IronPort-AV: E=Sophos;i="5.64,272,1559491200"; d="scan'208";a="114846259" Received: from mail-co1nam04lp2055.outbound.protection.outlook.com (HELO NAM04-CO1-obe.outbound.protection.outlook.com) ([104.47.45.55]) by ob1.hgst.iphmx.com with ESMTP; 17 Jul 2019 12:23:40 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z3vLSX3L/xZHwifUXLq3G+HCNVq4FOWsExt4oZ9oS7XYgsEr1TD1P21XoMv/OsbpWnwj0rmyS6OBvfezLiet6/P7iJ9rc3/KreIyttd1D7RONRNkLfSBrMtEicbONoEaZ5M0bQm13BITHwH2HbT2J5VWnCLSrHXjviliVynT8yrtvcPfu0CRAdNZI21Qwp0SKsRr7XwMXvgse4GN6rdKLNg4SvcsFDs89LovySoFYsFKvlOL3F8H/8H5dbYJEx0NR3/hp1cuCWf6aqRHul5zsnwhSJnK1FklNsCUjKZSzC+Avq8zsqmJqV5jEP2aZYNrJodlvwQV8PgLczIozfw/5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1dOzvvmOPgz6QlBs5XH75/DBFDEFO7C7r6CAnNOA4gk=; b=i1rMyDO8CkBybg6OFwhscF08XBmxjgdMPoiZTVPIdca7e7Tdb2KoA1qc73hN5qUn06X+RvdqfUgcW3mcKaZoCzZQJjFWdzwkYqZ8FLshccng9zOgRNVF9YhxNTfRetVvU7I+9kzGv3hFbtfNk9AlZRKZpEO2YYCMw/EoD3FxbWvivD4Im+vKzbZG4t92rmrmw1A4T/Kq22TZaekJKAaEQ0xEqKpyiG0sz5p5LPo4Okzv26dOEfOlS0HgYWDIFVu5D2sDaFgdFPPaO2iH26r07aiPJMO0h49yXH+44uCnM0D/a50DTbZzU8JIZ3XRZLv8vxX+xa+MOLhbqJC1b9vWlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1dOzvvmOPgz6QlBs5XH75/DBFDEFO7C7r6CAnNOA4gk=; b=dL/327dMCgwQS0+aDKAnnRK4Wr4WTK/IIfjCfm3gbY2SEdSOfubaaaU0EQqnDsHl3caFLWxk7xfh+ATP6yMjgnWCrDocyi+a7NIr1LPXQf8IbAw9gZxMHCxoyPLp4lLYy6XFpN6fLS0iZ47VrY9zvLyCHgD+T5K9D2xqGZE6imw= Received: from MN2PR04MB6061.namprd04.prod.outlook.com (20.178.246.15) by MN2PR04MB5742.namprd04.prod.outlook.com (20.179.21.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.13; Wed, 17 Jul 2019 04:23:38 +0000 Received: from MN2PR04MB6061.namprd04.prod.outlook.com ([fe80::8814:b9b0:47f5:2633]) by MN2PR04MB6061.namprd04.prod.outlook.com ([fe80::8814:b9b0:47f5:2633%7]) with mapi id 15.20.2073.012; Wed, 17 Jul 2019 04:23:38 +0000 From: Anup Patel To: Rick Chen , Bin Meng , Lukas Auer , Peng Fan , Jagan Teki , Oleksandr Zhadan and Michael Durrant Thread-Topic: [PATCH v6 1/4] mmc: mmc_spi: Use SPI_XFER_BEGIN and SPI_XFER_END flags Thread-Index: AQHVPFdoLxKP3wdLeE2p9w5/ndGRlg== Date: Wed, 17 Jul 2019 04:23:38 +0000 Message-ID: <20190717042312.24524-2-anup.patel@wdc.com> References: <20190717042312.24524-1-anup.patel@wdc.com> In-Reply-To: <20190717042312.24524-1-anup.patel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MAXPR0101CA0017.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:c::27) To MN2PR04MB6061.namprd04.prod.outlook.com (2603:10b6:208:d8::15) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anup.Patel@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [129.253.179.161] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 231cfac7-0f96-491b-092e-08d70a6e8a70 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:MN2PR04MB5742; x-ms-traffictypediagnostic: MN2PR04MB5742: x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:2582; x-forefront-prvs: 01018CB5B3 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(4636009)(396003)(346002)(376002)(39860400002)(136003)(366004)(189003)(199004)(256004)(316002)(486006)(110136005)(4326008)(14444005)(8936002)(68736007)(44832011)(81166006)(66476007)(14454004)(7416002)(81156014)(478600001)(5660300002)(54906003)(66556008)(66446008)(66946007)(64756008)(36756003)(186003)(52116002)(102836004)(7736002)(446003)(386003)(3846002)(6486002)(26005)(1076003)(25786009)(8676002)(99286004)(6506007)(71200400001)(66066001)(2616005)(2906002)(71190400001)(6436002)(6116002)(476003)(50226002)(6512007)(53936002)(305945005)(76176011)(86362001)(11346002); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR04MB5742; H:MN2PR04MB6061.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: TeK9JQcJsDy84G54m3DyDotho2gemPNG84biN0fgAIq9zZtePaYKNE7zfn8U6ODd4jo6fbU19woKcvH6wDmCZdggpCT2r8UgqWTniwgUTdn8a43Ehu/9zDZegYIXAPtEn2FL+FkxuNJ7SbWSJtwBbMTkOasaKy3aZuewY3z28O2CcTp0aLyA9F3lCERconqz4ilcyoj4LwgVCth3mhjU5+24N4OxyS9+EB/LMqBoXyaN+pZa+KPsT/C8sE1PiLgwPLHQG8IQyY1E8+vXZh7Ol9829EeSEiye2UreAKcdqq93ddfma6fxGZk0XXsuY0rFcwG0LIBVFR+VkLmDVQA7C9sEtgWZUHPrNwWOBc2H7RyVJ6THuAGlCbmxv8E6VmR/qHJBt/b3J7m0o8nOjff0gkk8dnbOo1a3aEEnY3Rej48= MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 231cfac7-0f96-491b-092e-08d70a6e8a70 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2019 04:23:38.5250 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Anup.Patel@wdc.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5742 Cc: Palmer Dabbelt , U-Boot Mailing List Subject: [U-Boot] [PATCH v6 1/4] mmc: mmc_spi: Use SPI_XFER_BEGIN and SPI_XFER_END flags X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Most DM based SPI host controller drivers use SPI_XFER_BEGIN and SPI_XFER_END flags to enable/disable slave chip select. This patch extends MMC SPI driver to pass SPI_XFER_BEGIN flag when MMC command is send at start and pass SPI_XFER_END flag using a dummy transfer (of bitlen = 0) at the end of MMC command. Suggested-by: Jagan Teki Signed-off-by: Anup Patel --- drivers/mmc/mmc_spi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/mmc_spi.c b/drivers/mmc/mmc_spi.c index f3d687ae80..350812a04b 100644 --- a/drivers/mmc/mmc_spi.c +++ b/drivers/mmc/mmc_spi.c @@ -84,7 +84,7 @@ static int mmc_spi_sendcmd(struct udevice *dev, cmdo[4] = cmdarg >> 8; cmdo[5] = cmdarg; cmdo[6] = (crc7(0, &cmdo[1], 5) << 1) | 0x01; - ret = dm_spi_xfer(dev, sizeof(cmdo) * 8, cmdo, NULL, 0); + ret = dm_spi_xfer(dev, sizeof(cmdo) * 8, cmdo, NULL, SPI_XFER_BEGIN); if (ret) return ret; @@ -360,6 +360,8 @@ static int dm_mmc_spi_request(struct udevice *dev, struct mmc_cmd *cmd, } done: + dm_spi_xfer(dev, 0, NULL, NULL, SPI_XFER_END); + dm_spi_release_bus(dev); return ret;