From patchwork Tue Jul 16 04:22:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1132430 X-Patchwork-Delegate: van.freenix@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="BsIqLxXU"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="t9yWnMf0"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 45nnLH1Dx3z9sDQ for ; Tue, 16 Jul 2019 14:22:31 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id B630EC21DDC; Tue, 16 Jul 2019 04:22:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id D62CEC21C6A; Tue, 16 Jul 2019 04:22:21 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id BFDD6C21DC1; Tue, 16 Jul 2019 04:22:10 +0000 (UTC) Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124]) by lists.denx.de (Postfix) with ESMTPS id 67FB1C21DED for ; Tue, 16 Jul 2019 04:22:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1563250930; x=1594786930; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=GFkMURDIWgcUvojanF2yKFx3MgIpNw9atItEoZ42F4U=; b=BsIqLxXUFFf1UA3iaZ8lrGikqIsA9GAp/2A8/D0H5wI4s3PdNwBLkU0S lQNA/beJ/zJ0mQOO1AS1vMkgIxzfYQul2uq4tCRTnlNT5JWTYSoVG9m0m D2pIIxs9dgemH06+aQMqlqRMBr49sEbilMDdGV4bV+dmBXsUKv3Hkcn33 lmLMjM9Z8SrhW4jZUgmuLF0IbyD/8S95/kFLPd3e9Bdi2FIwOhYK4h48x Ms9Jb8ytswof1vZP/Px4aHC6NimNBpmYNBV/yMQ7QhZuh2qGDnwkUeVRp OA+Ir/0MIRggMRHz1GVSOYXDb+sWbFUYFcg+PRORACODtRAnLxksjYnCX A==; IronPort-SDR: U9R281IZp16JtewlXDBFHK8ZGCoIZXGvmLkeegWgHAERJ6qctZ5G3mgSxNN0y1vLgsF/UNtq7m bdDWpO00tlrx5NsmhRgRK/aVTkHWJg7e7KIG8TbUYSe3GY5FL2imSG66pnqdB5BMt1KuA6Nysy c9Z8JLO5MulRXMiyBGOl/5aQTyR5UXV2PdIRrY4VG+7HLZKCXZMmm3MCCshiA+R52VVKOImKRc AZEmAw/vBomno0h+T5nQEN03fiiBSsAvLvfhzoVis2Dw7mh9Rgv2V1zbLLL60gKA6XOPm1+Fx2 SuA= X-IronPort-AV: E=Sophos;i="5.63,496,1557158400"; d="scan'208";a="213114094" Received: from mail-co1nam03lp2052.outbound.protection.outlook.com (HELO NAM03-CO1-obe.outbound.protection.outlook.com) ([104.47.40.52]) by ob1.hgst.iphmx.com with ESMTP; 16 Jul 2019 12:22:06 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=key+c2rVD34FuowcrryAhy79+/nzspmew4LMk8TuuGF/83OG+/uSKAh/7CPYMD799hrtNoxV0tl4+RI29bjTC8yyuYCzTT3BCa4SRxJIrDi+akl146jarhTVuOwtFW66QZvWnBCego/cP8uwDglEAshzc9nUNQTC0Q+ansgviuEupwg8uqqc5gwhcaNqc7NSKSoTYjeSyiDxb8508xROdVj5rIXJrJpJ10xQtVa3IYEhvljXRfMXXhRmSkDJ+kwLJJww0klFxfOh0zihjHUZ53IWLYEUR2vLi5DdSje+oC+w5GVuGSsH83ONRBteJ88WgjeQRIjZbGnCzqYUBxXNAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1dOzvvmOPgz6QlBs5XH75/DBFDEFO7C7r6CAnNOA4gk=; b=d6pHfmS2YSnOhSGJo8Cg0Z2tHCikEgQlIZyioSDo10m0vJuNG9EfoxxjPllAX6GTp2BtkZ/0pg7Bl7mF3OmYnvj/j8mBMigj/y3h0X8zcw5UcbElQKHyCJDCepcHQUneyVJYIf69aSiHTsLHeIn+tNLynCzX+Hwkq9IzjUhnMKAwW1c+MTinnz43Fwnmt0lmdywb8DShRTfQAGtJ8hQFHQVW526jGmMOxANL8XOP1AzzoorRdE/wpqM14dYtxy6gPDqvaUhYWXNxfjAR0pUL18kQtybGvFQDp4k+qjFRe5Gp0XI41yT3j8j0Qs2V/slO34Pk2rQrWUZ+RQyQmajxQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1dOzvvmOPgz6QlBs5XH75/DBFDEFO7C7r6CAnNOA4gk=; b=t9yWnMf0fJdCz1ISHDpI4K6Rl2i+onosycRgft/5Cq0usBePZNB6GKm9MxSLDCvLYIgEftLwEkHgf8ZwfZ8s4np8QVPlJsjQHnuK+2q2Jvr99p2xXOZgI4zb8hBrbTXQEj8q+TTfFV2inFgF50k8STJnE+Zc1NlNlPjPHlMpb1Q= Received: from MN2PR04MB6061.namprd04.prod.outlook.com (20.178.246.15) by MN2PR04MB6015.namprd04.prod.outlook.com (20.178.246.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.10; Tue, 16 Jul 2019 04:22:03 +0000 Received: from MN2PR04MB6061.namprd04.prod.outlook.com ([fe80::8814:b9b0:47f5:2633]) by MN2PR04MB6061.namprd04.prod.outlook.com ([fe80::8814:b9b0:47f5:2633%7]) with mapi id 15.20.2073.012; Tue, 16 Jul 2019 04:22:03 +0000 From: Anup Patel To: Rick Chen , Bin Meng , Lukas Auer , Peng Fan , Jagan Teki , Oleksandr Zhadan and Michael Durrant Thread-Topic: [PATCH v4 1/4] mmc: mmc_spi: Use SPI_XFER_BEGIN and SPI_XFER_END flags Thread-Index: AQHVO44FK4hR7WP4R0aQy9Bgec9+aA== Date: Tue, 16 Jul 2019 04:22:03 +0000 Message-ID: <20190716042120.32548-2-anup.patel@wdc.com> References: <20190716042120.32548-1-anup.patel@wdc.com> In-Reply-To: <20190716042120.32548-1-anup.patel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MA1PR01CA0082.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00::22) To MN2PR04MB6061.namprd04.prod.outlook.com (2603:10b6:208:d8::15) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anup.Patel@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [129.253.179.161] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: da9f648b-41b0-4be1-76e1-08d709a5276d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:MN2PR04MB6015; x-ms-traffictypediagnostic: MN2PR04MB6015: x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:2582; x-forefront-prvs: 0100732B76 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(4636009)(136003)(39860400002)(376002)(396003)(366004)(346002)(199004)(189003)(14444005)(386003)(52116002)(6506007)(66946007)(76176011)(26005)(186003)(66066001)(6486002)(86362001)(66556008)(66446008)(3846002)(6116002)(64756008)(2616005)(68736007)(66476007)(478600001)(446003)(11346002)(486006)(256004)(44832011)(476003)(8676002)(2906002)(99286004)(6436002)(7416002)(53936002)(5660300002)(6512007)(305945005)(71190400001)(316002)(14454004)(50226002)(54906003)(36756003)(4326008)(1076003)(71200400001)(7736002)(110136005)(81156014)(102836004)(25786009)(81166006)(8936002); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR04MB6015; H:MN2PR04MB6061.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: MEDz8tWfsHXdzFkk3tlW/zSiUuDqt+kgWSpJnKu7pVPBJzwX5kfRnV8X30KgpKwb2GpnCqgRAO2/cAY/rT+2QNN32rT8PVs5fH1iGHpQXTvnMDsP/2fR8pICcSdpNjtajyzrDdO3qawPFSXrE2oPodDcCIqJrHpUgYe4wsDEHd93AF4gBD1qip6TL89p6+xJqITv/7dRwLCa3N8Qk68eAGQSneoVwbSng36HZI4sO3RXJut2HeaQEUrSnWM8DWVfWQmzSXHCCaVxZCqWIZBGKUcLscpdm0T12R3dwlxjJ0QK4mZKK6kKEmKH7t5jnJjiSNLPMWdhUYQAAS679+qV2zpozvSQLqHXkDbATEgW59MaBBfD5ejSLhelTpovq3dFKuGsV3VZnww3Cw8ybQCM/G7WZGaWSVMWQ8c7NhfIRJk= MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: da9f648b-41b0-4be1-76e1-08d709a5276d X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2019 04:22:03.7340 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Anup.Patel@wdc.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6015 Cc: Palmer Dabbelt , U-Boot Mailing List Subject: [U-Boot] [PATCH v4 1/4] mmc: mmc_spi: Use SPI_XFER_BEGIN and SPI_XFER_END flags X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Most DM based SPI host controller drivers use SPI_XFER_BEGIN and SPI_XFER_END flags to enable/disable slave chip select. This patch extends MMC SPI driver to pass SPI_XFER_BEGIN flag when MMC command is send at start and pass SPI_XFER_END flag using a dummy transfer (of bitlen = 0) at the end of MMC command. Suggested-by: Jagan Teki Signed-off-by: Anup Patel --- drivers/mmc/mmc_spi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/mmc_spi.c b/drivers/mmc/mmc_spi.c index f3d687ae80..350812a04b 100644 --- a/drivers/mmc/mmc_spi.c +++ b/drivers/mmc/mmc_spi.c @@ -84,7 +84,7 @@ static int mmc_spi_sendcmd(struct udevice *dev, cmdo[4] = cmdarg >> 8; cmdo[5] = cmdarg; cmdo[6] = (crc7(0, &cmdo[1], 5) << 1) | 0x01; - ret = dm_spi_xfer(dev, sizeof(cmdo) * 8, cmdo, NULL, 0); + ret = dm_spi_xfer(dev, sizeof(cmdo) * 8, cmdo, NULL, SPI_XFER_BEGIN); if (ret) return ret; @@ -360,6 +360,8 @@ static int dm_mmc_spi_request(struct udevice *dev, struct mmc_cmd *cmd, } done: + dm_spi_xfer(dev, 0, NULL, NULL, SPI_XFER_END); + dm_spi_release_bus(dev); return ret;