diff mbox series

[U-Boot,v2,3/3] configs: arndale: Use appropriate driverfor Asix AX88760

Message ID 20190511112433.31367-3-krzk@kernel.org
State Accepted
Delegated to: Minkyu Kang
Headers show
Series [U-Boot,v2,1/3] arm: exynos: arndale: Remove unusedCONFIG_POWER and CONFIG_POWER_I2C | expand

Commit Message

Krzysztof Kozlowski May 11, 2019, 11:24 a.m. UTC
Arndale board has an Asix AX88760 USB 2.0 Hub and Fast Ethernet combo.
The appropriate driver for it is USB_ETHER_ASIX.

The mistake probably came from misinterpretation of commit e9954b867ce0
("usb: eth: add ASIX AX88179 DRIVER") which was tested on RECS5250 COM
module.  This module indeed has Exynos5250 and some similarities with
Arndale 5250 board but the USB/Ethernet chip used there is apparently
different.

Fixes: f58ad98a621c ("usb: net: migrate USB Ethernet adapters to Kconfig")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Lukasz Majewski <lukma@denx.de>

---

Not tested.

Changes since v1:
1. Add Lukasz's tag.
---
 configs/arndale_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Minkyu Kang May 16, 2019, 7:33 a.m. UTC | #1
Hi,

On 11/05/2019 20:24, Krzysztof Kozlowski wrote:
> Arndale board has an Asix AX88760 USB 2.0 Hub and Fast Ethernet combo.
> The appropriate driver for it is USB_ETHER_ASIX.
> 
> The mistake probably came from misinterpretation of commit e9954b867ce0
> ("usb: eth: add ASIX AX88179 DRIVER") which was tested on RECS5250 COM
> module.  This module indeed has Exynos5250 and some similarities with
> Arndale 5250 board but the USB/Ethernet chip used there is apparently
> different.
> 
> Fixes: f58ad98a621c ("usb: net: migrate USB Ethernet adapters to Kconfig")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Lukasz Majewski <lukma@denx.de>
> 
> ---
> 
> Not tested.
> 
> Changes since v1:
> 1. Add Lukasz's tag.
> ---
>  configs/arndale_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configs/arndale_defconfig b/configs/arndale_defconfig
> index e90d670f6813..37ad6accc396 100644
> --- a/configs/arndale_defconfig
> +++ b/configs/arndale_defconfig
> @@ -42,4 +42,4 @@ CONFIG_USB_XHCI_HCD=y
>  CONFIG_USB_XHCI_DWC3=y
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_USB_HOST_ETHER=y
> -CONFIG_USB_ETHER_ASIX88179=y
> +CONFIG_USB_ETHER_ASIX=y
> 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.
diff mbox series

Patch

diff --git a/configs/arndale_defconfig b/configs/arndale_defconfig
index e90d670f6813..37ad6accc396 100644
--- a/configs/arndale_defconfig
+++ b/configs/arndale_defconfig
@@ -42,4 +42,4 @@  CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_HOST_ETHER=y
-CONFIG_USB_ETHER_ASIX88179=y
+CONFIG_USB_ETHER_ASIX=y