Message ID | 20190511112433.31367-2-krzk@kernel.org |
---|---|
State | Accepted |
Commit | bc85f7c87af1aafac7032db85c815ab3927304bf |
Delegated to: | Minkyu Kang |
Headers | show |
Series | [U-Boot,v2,1/3] arm: exynos: arndale: Remove unusedCONFIG_POWER and CONFIG_POWER_I2C | expand |
Hi, On 11/05/2019 20:24, Krzysztof Kozlowski wrote: > The CONFIG_DM_I2C_COMPAT was introduced in > include/configs/exynos5-common.h in commit 189d80166b31 ("exynos5: > enable dm i2c") and then it propagated up to configs/arndale_defconfig. > However since beginning the Arndale board (Exynos5250) was not using > I2C. > > In fact, the Arndale board is not configuring its PMIC (S5M8767) which > uses I2C bus. This setting can be thus safely removed to fix build > warning: > > This board uses CONFIG_DM_I2C_COMPAT. Please remove > (possibly in a subsequent patch in your series) > before sending patches to the mailing list. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > Reviewed-by: Simon Glass <sjg@chromium.org> > > --- > > Not tested on Arndale board. Testing is welcomed. > > Changes since v1: > 1. Add Simon's tag. > 2. Reorder patches - first remove CONFIG_POWER_I2C, then > CONFIG_DM_I2C_COMPAT. > --- > configs/arndale_defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configs/arndale_defconfig b/configs/arndale_defconfig > index 9727d28c1241..e90d670f6813 100644 > --- a/configs/arndale_defconfig > +++ b/configs/arndale_defconfig > @@ -25,7 +25,6 @@ CONFIG_CMD_SOUND=y > CONFIG_CMD_EXT4_WRITE=y > CONFIG_DEFAULT_DEVICE_TREE="exynos5250-arndale" > CONFIG_ENV_IS_IN_MMC=y > -CONFIG_DM_I2C_COMPAT=y > CONFIG_SUPPORT_EMMC_BOOT=y > CONFIG_MMC_DW=y > CONFIG_MMC_SDHCI=y > applied to u-boot-samsung. Thanks, Minkyu Kang.
diff --git a/configs/arndale_defconfig b/configs/arndale_defconfig index 9727d28c1241..e90d670f6813 100644 --- a/configs/arndale_defconfig +++ b/configs/arndale_defconfig @@ -25,7 +25,6 @@ CONFIG_CMD_SOUND=y CONFIG_CMD_EXT4_WRITE=y CONFIG_DEFAULT_DEVICE_TREE="exynos5250-arndale" CONFIG_ENV_IS_IN_MMC=y -CONFIG_DM_I2C_COMPAT=y CONFIG_SUPPORT_EMMC_BOOT=y CONFIG_MMC_DW=y CONFIG_MMC_SDHCI=y