From patchwork Sun Mar 31 02:08:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugeniu Rosca X-Patchwork-Id: 1071588 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="t6ZlO9qb"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 44XCgl4qSfz9sQt for ; Sun, 31 Mar 2019 22:20:19 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 61D44C21E2C; Sun, 31 Mar 2019 11:19:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, KHOP_BIG_TO_CC, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 18220C21DD9; Sun, 31 Mar 2019 11:19:02 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 697EAC21C2C; Sun, 31 Mar 2019 02:09:51 +0000 (UTC) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by lists.denx.de (Postfix) with ESMTPS id 1D43BC21C27 for ; Sun, 31 Mar 2019 02:09:51 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id k17so7273938wrx.10 for ; Sat, 30 Mar 2019 19:09:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=luZCoBcB/k1M3LhkpryYV54EXgECmkQhxg/q1G97MUc=; b=t6ZlO9qbD0nWTHnBoU6xOHEGIu51qrHJpedmO+ZAE3+ShXa10WSQFpk5yUqALpXD6a 01x1Ul+XCRrucYEaLdyzpxs0/EOXBw8BmjR7HCZJg/cDoo37x3JKeV2KUD9vCHqDFIBN 3gJLr6JxB8y7xxYo5v8/X4pYaXJfLzw2txM9K48lmORLhs/CSzBSrOsAXJCd6uHZuZfl p6Nc75AgPuumPFc+Qt9fFMtq9YhAgBS6XfuP+T+XFf5kM1aQso2/gnf61jHIYK90sPU7 kkR1C9upG47EEnFpwY/vkWAcqNVTeFgcc31J15Tfh4AQ2bBix0VFu9Sn7hdPFN90Culv 3Xiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=luZCoBcB/k1M3LhkpryYV54EXgECmkQhxg/q1G97MUc=; b=gZOt3tfMXCR57EsaO10fQFmRE1PfOgBqF0wcyMdYA0iC1l69Sx9ZHBZmfDPPVDrPl6 HtWaD7siiZg6V/2E/MGP0Ra1bbjFCTFTjY5R4hlcHkvTKvUE7SWCqJOPiOFcwQXj667Z EpMHeWRh5l+saao4LURzJwgXIvH+MmKyGrr7u14IO+c57MnOTzgmNzfu0/raty5gztHY Zv20KQThVTQNahq4MOzmw/Yggd4h79J4eEZxT4FKsGA/b8ZYt+7Rus8UPARhyT+bNBe/ 2ExYJIA8E1HHdRJZ9DF0XsRbhqmzm/tpD83fsrWigGXlSrWD/nV5TcEZzWy3z0wSmjuE 7oNA== X-Gm-Message-State: APjAAAWvkBLqlrI3gWK/U0W6s8LKVJNQz0WyvrcBHnxTTcC7Uxk6Aeo+ h09eDinJAVKAU4HVAY4eesY= X-Google-Smtp-Source: APXvYqwJWeL/FIgQ1RSBaTQyjL9e1psPy2zuSWRcBsmolC0L4x39wrkexnckwdtp8qfUzEEiT6HYYQ== X-Received: by 2002:adf:ea43:: with SMTP id j3mr34397327wrn.210.1553998190782; Sat, 30 Mar 2019 19:09:50 -0700 (PDT) Received: from localhost.localdomain (ipb218f541.dynamic.kabel-deutschland.de. [178.24.245.65]) by smtp.gmail.com with ESMTPSA id e193sm10228733wmg.18.2019.03.30.19.09.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 30 Mar 2019 19:09:50 -0700 (PDT) From: Eugeniu Rosca X-Google-Original-From: Eugeniu Rosca To: Simon Glass , Tom Rini , Masahiro Yamada , Stefan Roese , Sam Protsenko , Simon Goldschmidt , Marek Vasut , George McCollister , Alexey Brodkin , Alexander Graf , York Sun , Tuomas Tynkkynen , Thomas Petazzoni , Shawn Guo , Paul Kocialkowski , Pantelis Antoniou , Michal Simek , Max Krummenacher , Marcel Ziswiler , Joe Hershberger , Joakim Tjernlund , Heiko Schocher , Hannes Schmelzer , Hannes Schmelzer , Daniel Schwierzeck , Bin Meng , u-boot@lists.denx.de Date: Sun, 31 Mar 2019 04:08:35 +0200 Message-Id: <20190331020838.26683-3-erosca@de.adit-jv.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190331020838.26683-1-erosca@de.adit-jv.com> References: <20190331020838.26683-1-erosca@de.adit-jv.com> MIME-Version: 1.0 X-Mailman-Approved-At: Sun, 31 Mar 2019 11:19:00 +0000 Cc: Eugeniu Rosca , Eugeniu Rosca Subject: [U-Boot] [PATCH 3/6] fdt: boot_get_fdt: simplify no_fdt handling (non-functional) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Increase the readability of boot_get_fdt(). No change in behavior is expected. Signed-off-by: Eugeniu Rosca --- common/image-fdt.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/common/image-fdt.c b/common/image-fdt.c index c335e7e2f220..68bcab85baf4 100644 --- a/common/image-fdt.c +++ b/common/image-fdt.c @@ -279,7 +279,6 @@ int boot_get_fdt(int flag, int argc, char * const argv[], uint8_t arch, int fdt_noffset; #endif const char *select = NULL; - int ok_no_fdt = 0; *of_flat_tree = NULL; *of_size = 0; @@ -487,12 +486,9 @@ int boot_get_fdt(int flag, int argc, char * const argv[], uint8_t arch, return 0; no_fdt: - ok_no_fdt = 1; + debug("Continuing to boot without FDT\n"); + return 0; error: - if (ok_no_fdt) { - debug("Continuing to boot without FDT\n"); - return 0; - } return 1; }