| Message ID | 20190318073334.17216-1-judge.packham@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Stefan Roese |
| Headers | show |
| Series | [U-Boot] ARM: kirkwood: disable dcache for Kirkwood boards | expand |
Hi Chris, On 18.03.19 08:33, Chris Packham wrote: > Prior to commit 93b283d49f93 ("ARM: CPU: arm926ejs: Consolidate cache > routines to common file") the kirkwood boards didn't have and dcache > support. The network and usb drivers rely on this. Set > CONFIG_SYS_DCACHE_OFF in the Kirkwood specific config.h. > > Reported-by: Leigh Brown <leigh@solinno.co.uk> > Signed-off-by: Chris Packham <judge.packham@gmail.com> > --- > > arch/arm/mach-kirkwood/include/mach/config.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-kirkwood/include/mach/config.h b/arch/arm/mach-kirkwood/include/mach/config.h > index fcd903887bff..3a4014e308b3 100644 > --- a/arch/arm/mach-kirkwood/include/mach/config.h > +++ b/arch/arm/mach-kirkwood/include/mach/config.h > @@ -26,6 +26,7 @@ > #define CONFIG_KIRKWOOD_EGIGA_INIT /* Enable GbePort0/1 for kernel */ > #define CONFIG_KIRKWOOD_RGMII_PAD_1V8 /* Set RGMII Pad voltage to 1.8V */ > #define CONFIG_KIRKWOOD_PCIE_INIT /* Enable PCIE Port0 for kernel */ > +#define CONFIG_SYS_DCACHE_OFF /* Disable data cache */ Thanks for taking care of this. I agree, that such a generic approach to disable the d-cache (for now) is better than a board specific one. But could you please add a short comment to the header to describe the background, similar to this commit message here? Perhaps also with a note that some drivers need updating / fixing before this "workaround" can be removed again? Thanks, Stefan
diff --git a/arch/arm/mach-kirkwood/include/mach/config.h b/arch/arm/mach-kirkwood/include/mach/config.h index fcd903887bff..3a4014e308b3 100644 --- a/arch/arm/mach-kirkwood/include/mach/config.h +++ b/arch/arm/mach-kirkwood/include/mach/config.h @@ -26,6 +26,7 @@ #define CONFIG_KIRKWOOD_EGIGA_INIT /* Enable GbePort0/1 for kernel */ #define CONFIG_KIRKWOOD_RGMII_PAD_1V8 /* Set RGMII Pad voltage to 1.8V */ #define CONFIG_KIRKWOOD_PCIE_INIT /* Enable PCIE Port0 for kernel */ +#define CONFIG_SYS_DCACHE_OFF /* Disable data cache */ /* * By default kwbimage.cfg from board specific folder is used
Prior to commit 93b283d49f93 ("ARM: CPU: arm926ejs: Consolidate cache routines to common file") the kirkwood boards didn't have and dcache support. The network and usb drivers rely on this. Set CONFIG_SYS_DCACHE_OFF in the Kirkwood specific config.h. Reported-by: Leigh Brown <leigh@solinno.co.uk> Signed-off-by: Chris Packham <judge.packham@gmail.com> --- arch/arm/mach-kirkwood/include/mach/config.h | 1 + 1 file changed, 1 insertion(+)