From patchwork Thu Feb 21 04:31:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1045749 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="aQFDPlUP"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="Y4oI8YAm"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 444hcD5tZYz9s5c for ; Thu, 21 Feb 2019 15:40:44 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 7ABA9C21DA2; Thu, 21 Feb 2019 04:38:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAD_ENC_HEADER, KHOP_BIG_TO_CC, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 08B74C21FF5; Thu, 21 Feb 2019 04:32:06 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id E61B1C21FC6; Thu, 21 Feb 2019 04:31:46 +0000 (UTC) Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by lists.denx.de (Postfix) with ESMTPS id 6C191C21FAD for ; Thu, 21 Feb 2019 04:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1550723503; x=1582259503; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AGopGUiXazjgN5ZuY1nzw0BAbdwpOrkv1RV7FfRgwcQ=; b=aQFDPlUPjdzI5GMYnJSROwsec4deHBMPLbEqPxBfrkZp3EfaZ7cEOA1b LcXv7R6x7QyrpJwcyHaBQA8ttHmwDBlyrou7uCK7o9WpL1TORlrD8nmMl SAdzq/Vg2PAbamShGpzgKUaiCI6Q/m/PWphlcgZXHEv5yKsfcMClKyuMd BjWF0CK3zeUqBRZQu4+v5Oe0YzCzVQ4c3KffwAhbyP2k3L+Y5KkGuepzV qUzc2uLgdUu7mDHaDL30OjV4SUPswqaHc0QSUH2On8wnttxghZA680XAz jcV7W/Jn8Xq5QVYmnuG+R/Ql1kl5SiGRxU7AHQMPRSCnq+tzGwpv2HTGX g==; X-IronPort-AV: E=Sophos;i="5.58,393,1544457600"; d="scan'208";a="106774588" Received: from mail-by2nam03lp2057.outbound.protection.outlook.com (HELO NAM03-BY2-obe.outbound.protection.outlook.com) ([104.47.42.57]) by ob1.hgst.iphmx.com with ESMTP; 21 Feb 2019 12:31:39 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u0pk+m+saWEBpumb8AcuizP7KdgAEiXUxCJ16WAWEek=; b=Y4oI8YAmB8HbnajZBrzmXFHetMGlhgjBAu2Ol5T6rng2sPz1QBPKiWUPiUvsZWFci2wdLUvEUBn/XwMSF7TJBp7e9fCc/7GyoIJlBtXMjlgEkXW8ofnKVm+2Q3YSjFImBHvu+WP1RVm/UOrfjahzQ85u/Bvpf7NbxMOOdBEvyUc= Received: from BN8PR04MB6050.namprd04.prod.outlook.com (20.178.214.224) by BN8PR04MB5620.namprd04.prod.outlook.com (20.179.72.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1622.16; Thu, 21 Feb 2019 04:31:18 +0000 Received: from BN8PR04MB6050.namprd04.prod.outlook.com ([fe80::f87a:cb97:e3a:b8e7]) by BN8PR04MB6050.namprd04.prod.outlook.com ([fe80::f87a:cb97:e3a:b8e7%4]) with mapi id 15.20.1622.020; Thu, 21 Feb 2019 04:31:18 +0000 From: Anup Patel To: Rick Chen , Bin Meng , Joe Hershberger , Michal Simek , Michal Simek , Lukas Auer , Masahiro Yamada , Simon Glass Thread-Topic: [PATCH v9 11/15] drivers: serial_sifive: Skip baudrate config if no input clock Thread-Index: AQHUyZ5KnpWj/pWq6k2XQAWPxpwKgA== Date: Thu, 21 Feb 2019 04:31:18 +0000 Message-ID: <20190221042936.13441-12-anup.patel@wdc.com> References: <20190221042936.13441-1-anup.patel@wdc.com> In-Reply-To: <20190221042936.13441-1-anup.patel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MAXPR0101CA0070.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:e::32) To BN8PR04MB6050.namprd04.prod.outlook.com (2603:10b6:408:53::32) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anup.Patel@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [106.51.20.29] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5443ae09-60dc-4dab-6491-08d697b56c70 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600110)(711020)(4605104)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:BN8PR04MB5620; x-ms-traffictypediagnostic: BN8PR04MB5620: wdcipoutbound: EOP-TRUE x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; BN8PR04MB5620; 23:JRgN2rhTQwlWSW9CyYOumQHBFbJPnJ9CqBARrow?= =?iso-8859-1?q?TElRhXM5xbOOUzhGxil5nYdFH?= =?iso-8859-1?q?kVPBMR0c1xx2xOogWsHwKOrc+YtwQG5c+1txUZrrAw/C05e7VgR?= =?iso-8859-1?q?AyMVZEEhF2n8FKO3AWvYDrsPg4yZByfVMn3N7SjvU9m+Vgkr/LK?= =?iso-8859-1?q?ZBMF4v6PfTpxxj87n/DrITDW3HPU8oByxGFbpTaPa9iDv/ZSPlY?= =?iso-8859-1?q?r02jwmD/iF0y39nT1zvIBShKFjSeF07NRU/6qwe7IUol4xWJz1+?= =?iso-8859-1?q?FFozluvs+YlprQGsCdFW9F6DvhGvS9ggCGIY6KAKL6ImglIFlPL?= =?iso-8859-1?q?DEOxAbP7rVM80l8g68AToydpyj3D/KJhM0nerMEgQEscZw/qxbx?= =?iso-8859-1?q?Df0A8L9D26qjE3+SK06FpU3vG9jBNh9kbFIi5ukiUfbknft3PN9?= =?iso-8859-1?q?rWIvhFyc0+dK6+KVJv3v6Wp4+7BU/eQvBdlIi3yi+SBN4NltW6X?= =?iso-8859-1?q?XZvftc+CndSdJ6XPGgiXwjA5S4fPCQtoAi7KntN18Sz4Clt1cqu?= =?iso-8859-1?q?Zyz8g0D3n6dkmtRJrvnXoBTb7qZQCPgNr/YRLLbwZyN9rqqYyce?= =?iso-8859-1?q?juNL1+ITKOoeFcgXf6c+S809l/FD0eoDQJozHdgencsQjgNKh2D?= =?iso-8859-1?q?kiu9WwRUJamvjIrqCFBTEneS/9WZQAL/Op8UaQibH/aFxih9zh0?= =?iso-8859-1?q?iOTvodys8EuS+RJep6XTGdrLT569OHM1UPwg6/twJobcPI1ldw6?= =?iso-8859-1?q?7glb297FxdIRxnOOoq+VT/phkE+TmrSPh64DO5wY+hw1fyJxNbk?= =?iso-8859-1?q?ROB6DL4WrkKAazi+JPYcwx5cGSN9wzJGAguyBKtkYNWSMqJRvDM?= =?iso-8859-1?q?k9LvP6xUenXDIIsk5eeoHfxmhWInOgFsKeALIOh10E4RJOvtQxP?= =?iso-8859-1?q?cOMYaEwDAAf6D7QNGR2C6Sx6dqjaYK6SfQKg2k26LhnJxg34QoA?= =?iso-8859-1?q?KfG+lpQCgINjsBWzsAHyN2lD6fCj04vWG/9EeuZ14IMkdnKzr1m?= =?iso-8859-1?q?DJlvp2HuoQLTfKLVVvp3ibzuj41J5oGqJC0FmrvJflSL4B/cmge?= =?iso-8859-1?q?d/g3EsV9zeZ6JE6oJTgbxcoUHw6ThX91IIZ4mKVhbCNXqMxoT2r?= =?iso-8859-1?q?P2WHavw08An20TUgYXHGSreJ889ORc4enIHbgxFPcnFjTuvJAsZ?= =?iso-8859-1?q?QW3l8jhYZnX4cNWKimWXT8zp2nn03Tio0dC8ZlEprsGEwWRkW4P?= =?iso-8859-1?q?C6X+QmUGtmA8nENmf4SAANwQCODFle4DQ2IpR5O/jr8i92rc8yH?= =?iso-8859-1?q?ut4wKarA3xpiMXXCuZGRLOGGBvmkELmuGuB6IXTKqxdWy8VUFu0?= =?iso-8859-1?q?JmEwC3pEvivpycwQMQVj+NHVOXHDQ1rZ21CffV/y1adFs/8myY4?= =?iso-8859-1?q?oU8zy?= x-microsoft-antispam-prvs: x-forefront-prvs: 09555FB1AD x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(39860400002)(366004)(346002)(396003)(136003)(199004)(189003)(14454004)(8936002)(81166006)(71200400001)(26005)(71190400001)(1076003)(8676002)(81156014)(478600001)(99286004)(55236004)(66066001)(3846002)(256004)(97736004)(86362001)(105586002)(5660300002)(2906002)(72206003)(78486014)(486006)(25786009)(476003)(6486002)(446003)(7416002)(36756003)(2616005)(44832011)(9456002)(68736007)(50226002)(102836004)(6512007)(106356001)(305945005)(54906003)(110136005)(6506007)(53936002)(386003)(52116002)(7736002)(186003)(76176011)(11346002)(6436002)(6116002)(316002)(4326008); DIR:OUT; SFP:1102; SCL:1; SRVR:BN8PR04MB5620; H:BN8PR04MB6050.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: EIUZtVaxmhCQ2qPxaO/3iKxa20xV54n9YZKKHrmxwd9RDj5L1Z99doNKiULxwouxUBUZ0wgQlghqj1VIFFlUS4ID8BEVlPllRlw1h6nFlcE+TD6129Lj35YzQxGH9xBrEiSnrTfcUjcN0dxxtjYedK37dXBA3hmWiUoG5pK7Izbc68BeSfkYEvzTDdYhaL6tikbANB6Br1tP6Ej1cBqq4xfxhMiCXZEhe84t2wmEbn2zLjt1IS7pSnq7uR0n9G8ie2NdTgDfmCNyiAUqPEPXx16GJnwS5hbc0iIf9wUKB6KpQtvYIICOXvZf2N3foyIUvWzS2/6YRlZ0kIc9/rv49DYlYC4z7vmaAzdwoNwapwnTzpHgOVByAwxShD4uv78Qx9mUYrzTprf4kXJQhskkZ7HRzRIXmHCI3iiZlxwmGyE= MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5443ae09-60dc-4dab-6491-08d697b56c70 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2019 04:31:14.2915 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR04MB5620 Cc: Palmer Dabbelt , Alexander Graf , U-Boot Mailing List Subject: [U-Boot] [PATCH v9 11/15] drivers: serial_sifive: Skip baudrate config if no input clock X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Atish Patra It is possible that input clock is not available because clk device was not available and 'clock-frequency' DT property is also not available. In this case, instead of failing we should just skip baudrate config by returning zero. Signed-off-by: Atish Patra Signed-off-by: Anup Patel Reviewed-by: Alexander Graf --- drivers/serial/serial_sifive.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/serial/serial_sifive.c b/drivers/serial/serial_sifive.c index ea4d35d48c..537bc7a975 100644 --- a/drivers/serial/serial_sifive.c +++ b/drivers/serial/serial_sifive.c @@ -99,27 +99,27 @@ static int _sifive_serial_getc(struct uart_sifive *regs) static int sifive_serial_setbrg(struct udevice *dev, int baudrate) { - int err; + int ret; struct clk clk; struct sifive_uart_platdata *platdata = dev_get_platdata(dev); + u32 clock = 0; - err = clk_get_by_index(dev, 0, &clk); - if (!err) { - err = clk_get_rate(&clk); - if (!IS_ERR_VALUE(err)) - platdata->clock = err; - } else if (err != -ENOENT && err != -ENODEV && err != -ENOSYS) { + ret = clk_get_by_index(dev, 0, &clk); + if (IS_ERR_VALUE(ret)) { debug("SiFive UART failed to get clock\n"); - return err; - } - - if (!platdata->clock) - platdata->clock = dev_read_u32_default(dev, "clock-frequency", 0); - if (!platdata->clock) { - debug("SiFive UART clock not defined\n"); - return -EINVAL; + ret = dev_read_u32(dev, "clock-frequency", &clock); + if (IS_ERR_VALUE(ret)) { + debug("SiFive UART clock not defined\n"); + return 0; + } + } else { + clock = clk_get_rate(&clk); + if (IS_ERR_VALUE(clock)) { + debug("SiFive UART clock get rate failed\n"); + return 0; + } } - + platdata->clock = clock; _sifive_serial_setbrg(platdata->regs, platdata->clock, baudrate); return 0;