From patchwork Thu Feb 21 04:31:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1045744 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="Cvl3GHOB"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="MnOmW5bk"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 444hYK3qhcz9s7h for ; Thu, 21 Feb 2019 15:38:13 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 36AD7C21E31; Thu, 21 Feb 2019 04:36:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAD_ENC_HEADER, KHOP_BIG_TO_CC, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id D5471C21DFD; Thu, 21 Feb 2019 04:31:43 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 6A338C21E0D; Thu, 21 Feb 2019 04:31:37 +0000 (UTC) Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by lists.denx.de (Postfix) with ESMTPS id CC422C21DCA for ; Thu, 21 Feb 2019 04:31:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1550723488; x=1582259488; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jki6yc4Dgywc+/2UFctRcM6KIGbue7NLrZzh+PGks1I=; b=Cvl3GHOBAdnW0ahmsjtucntbUSQQ2G1AOVdb58HjuuthHAsMB1DrQBNL HtRPCZR25BTPAehI3Q2iSSOWiC+xSawG6c0chmZPWAqEHYQe1758yqdGH aGOjLtzbuFqd1VTGKkYGetld7o51l3wLWveAtV9K18qCTdEx0ptbZtxth aGz0kGMWYkWxkxGtJOHFOTlhQR8T6CjSXKeDsDE2lGKKHQIG8lPQe5VYL dc7Z+F4TmsMdY10jdfYFGUefY/xq8kR3MOV3Ahtryq8nANBgQiCkw89gy k4ytbYSrkpJ9BdXGYRJ38vOWm6caRIASdcqE5Hp51uRSPRRAN8BRHdZd3 A==; X-IronPort-AV: E=Sophos;i="5.58,393,1544457600"; d="scan'208";a="106774550" Received: from mail-by2nam03lp2051.outbound.protection.outlook.com (HELO NAM03-BY2-obe.outbound.protection.outlook.com) ([104.47.42.51]) by ob1.hgst.iphmx.com with ESMTP; 21 Feb 2019 12:31:14 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FqeSzEs6ykL19UgS2gTj9tz1EZqeYicmQtYCOl+rl+Y=; b=MnOmW5bk9ONIMRFVSpEjSC6034OSoFeo4ED+6+x7R/1cpwIggpmwuOOQhXx4qR5w572RhJNBWkBlsLO/SAvS/D/3XQ5RDAYLL5wakcZIHi2w2Af5N6uZc25R8lzUVitj9RlPZ++g53wFLP13VAUQXLQVs7FBVC1xHI1YeRor5hU= Received: from BN8PR04MB6050.namprd04.prod.outlook.com (20.178.214.224) by BN8PR04MB5620.namprd04.prod.outlook.com (20.179.72.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1622.16; Thu, 21 Feb 2019 04:31:12 +0000 Received: from BN8PR04MB6050.namprd04.prod.outlook.com ([fe80::f87a:cb97:e3a:b8e7]) by BN8PR04MB6050.namprd04.prod.outlook.com ([fe80::f87a:cb97:e3a:b8e7%4]) with mapi id 15.20.1622.020; Thu, 21 Feb 2019 04:31:12 +0000 From: Anup Patel To: Rick Chen , Bin Meng , Joe Hershberger , Michal Simek , Michal Simek , Lukas Auer , Masahiro Yamada , Simon Glass Thread-Topic: [PATCH v9 10/15] drivers: serial_sifive: Fix baud rate calculation Thread-Index: AQHUyZ5GniGa4jYZS0m3Y1jzqrjYAg== Date: Thu, 21 Feb 2019 04:31:12 +0000 Message-ID: <20190221042936.13441-11-anup.patel@wdc.com> References: <20190221042936.13441-1-anup.patel@wdc.com> In-Reply-To: <20190221042936.13441-1-anup.patel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MAXPR0101CA0070.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:e::32) To BN8PR04MB6050.namprd04.prod.outlook.com (2603:10b6:408:53::32) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anup.Patel@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [106.51.20.29] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b3a70d33-b5b4-42d6-5d98-08d697b56908 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600110)(711020)(4605104)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:BN8PR04MB5620; x-ms-traffictypediagnostic: BN8PR04MB5620: wdcipoutbound: EOP-TRUE x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; BN8PR04MB5620; 23:933wtGbeFhwKfL88FGI+P4XjF77q4GY+goWjCoX?= =?iso-8859-1?q?/lU2QPNuSx4RD4Ofg7c0NBW2T?= =?iso-8859-1?q?JQaADKC1z7PeHhDeEZis53O8jXX8vTGL8q2iP6Iir69Obk3ivzv?= =?iso-8859-1?q?xXZswzHerWigBIWFvhQXWA39p+QJ5SQDTHSG3CLFe1z6tYH/Hg7?= =?iso-8859-1?q?B5U8UwD4+b2mXW8qSRSuSffGXnBpMGvygVpPbGGou6vJboFLaC1?= =?iso-8859-1?q?41jsHpWnxRKFkfgHNMjtS0AxF7ZSpFsP7cy1VyAo6SpI30mRIDr?= =?iso-8859-1?q?BWXcfkhwRpLD69nJ0r8/GObEu+QZ6Su4Mb5TLOzzrCY9I14bxFB?= =?iso-8859-1?q?htfNxKINGbP7tEWv+ocBd+d45o5vhBKC3JTjchf0Z1A8hcIxvJ3?= =?iso-8859-1?q?LLKkJdSaannhElAdkPVQhJw4AIXaZ7h5QrXjuPf9MD7FD9CD6Bd?= =?iso-8859-1?q?PUBX4BmhrabiDpH0zE9Ls0j3kZmjATL7ukfjqkJcjtpb8+dZEIC?= =?iso-8859-1?q?bOI+aZhm1aUmgMSKzLw4JMzU2uMgJMzz0hGBQGp+5vfqPcMnrni?= =?iso-8859-1?q?IsaSLc3TwW4+5SORvkn2H29cu5Pc0KdW8HIPiBCONkMPpk9qJn9?= =?iso-8859-1?q?Vwkj0NqP4d7tPqwPswirS8Nds6ujHsLhByc1srY3S64PjfuyUOf?= =?iso-8859-1?q?73hElx0RPqF3FWohqA02D7zYcsieSAR6iUlnWyWvWuePzD/PLVN?= =?iso-8859-1?q?zNgpG5TpB6ujNiI3ul+n39JTmJt/MHjAuKl9xKN2cSQD3gaeMwv?= =?iso-8859-1?q?QMdOoQkAlAVBwUEoMdgOV3sNGwKBvbz0erYM0tT9uEJEnWxHHle?= =?iso-8859-1?q?winZke6Y/JUPysPw/STVJg/c0Ul1NTs4FdCcNb+RE2x/gfCZkjU?= =?iso-8859-1?q?D83kCoK+r7ikVqMxdpED16oERpAkCIFxXHOvtmMsf0NBMDdmiSP?= =?iso-8859-1?q?FfB2Vhb+8MWnhbRi+FiHKZ9qFfRG8usNhjQVRSvndwTsJHWi76n?= =?iso-8859-1?q?z3wWb0pBfmSpl5/orcVM/eHO6qswoUkflgueGWgvkx8Utj9gsmW?= =?iso-8859-1?q?Aa0apwt5vL4JIBkXimSvEHn0Qt9H5uFDCBy0aWLW872Sxioej3K?= =?iso-8859-1?q?86j3EMmwf4SkhhuEE1rL/l5Xg485vhIy3ujP08mHkx1B2FIt5J2?= =?iso-8859-1?q?7lEsNX+HVaFtZZhCjPiYX0zhMWjuBoOgxKz+PydGDm6Ikri8fZs?= =?iso-8859-1?q?S50rQEYrCNd7pkKHC7PLQaXfw8dsKMYXBKLmQvb71o4tJllbjOI?= =?iso-8859-1?q?IFgYNPykCINr2vglLL9EVHx3pT4zfnOtrKe+GKD38VicLFzT3Z1?= =?iso-8859-1?q?y+kdqLkslNg0a2j6gTICt46XnauWIPB3oGyTEn2VxO1kftOytSk?= =?iso-8859-1?q?SuxmjaeTz/ZW004hnDMbOwPvPE6w7G2PlVMOjUs2Dr1JXd8sntc?= =?iso-8859-1?q?4kdwsKx0hwdtxO1H9kq+x3mJV1g=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09555FB1AD x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(39860400002)(366004)(346002)(396003)(136003)(199004)(189003)(14454004)(8936002)(81166006)(71200400001)(26005)(14444005)(71190400001)(1076003)(8676002)(81156014)(478600001)(99286004)(55236004)(66066001)(3846002)(256004)(97736004)(86362001)(105586002)(5660300002)(2906002)(72206003)(78486014)(486006)(25786009)(476003)(6486002)(446003)(7416002)(36756003)(2616005)(44832011)(9456002)(68736007)(50226002)(102836004)(6512007)(106356001)(305945005)(54906003)(110136005)(6506007)(53936002)(386003)(52116002)(7736002)(186003)(76176011)(11346002)(6436002)(6116002)(316002)(4326008); DIR:OUT; SFP:1102; SCL:1; SRVR:BN8PR04MB5620; H:BN8PR04MB6050.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: YhIzE4QxzYpHUL0CkgADyS2tCNke8p9wg8fYzcT48efUimYajJXA5y5RB0Ch4dafRRLMEAxbsfyv4NrwtcQAkBeGFiEDBUCJw6+rN1IGGGmf3cfaW5v0juMoLQkNyMzoJfW5vXT5iyqUxyz+ej1qcAGNLTcANbF8NrpNhsy106+xQUS/rUUIx2kyCJ4NesS+hQN5QVMcVhcSUlW22EcND4StsoyLow2WfzQRNwZhgPH5ME78TzuVitd8rrANMGvLuK+aH0HDitSBtF9Unf77VLbk6XocJ7jDstF61L4HS0wEThTlKsp2JI4vcg8YsrLlNvhX//OkSpXfAHLVEI8YA2SEOb8ofBtsxrjWrB0ZyoEculkHT4ZjH2zDSiJhspD8iDsDpLKimz9I+6ldrkdfTk/2GIlr07Bir28NvtHLP9U= MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3a70d33-b5b4-42d6-5d98-08d697b56908 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2019 04:31:08.5866 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR04MB5620 Cc: Palmer Dabbelt , Alexander Graf , U-Boot Mailing List Subject: [U-Boot] [PATCH v9 10/15] drivers: serial_sifive: Fix baud rate calculation X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Atish Patra Compute the baud rate multipler with more precision. Signed-off-by: Atish Patra Signed-off-by: Anup Patel Reviewed-by: Alexander Graf Reviewed-by: Lukas Auer --- drivers/serial/serial_sifive.c | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/serial/serial_sifive.c b/drivers/serial/serial_sifive.c index 341728a690..ea4d35d48c 100644 --- a/drivers/serial/serial_sifive.c +++ b/drivers/serial/serial_sifive.c @@ -33,16 +33,40 @@ struct uart_sifive { }; struct sifive_uart_platdata { - unsigned int clock; + unsigned long clock; int saved_input_char; struct uart_sifive *regs; }; +/** + * Find minimum divisor divides in_freq to max_target_hz; + * Based on uart driver n SiFive FSBL. + * + * f_baud = f_in / (div + 1) => div = (f_in / f_baud) - 1 + * The nearest integer solution requires rounding up as to not exceed + * max_target_hz. + * div = ceil(f_in / f_baud) - 1 + * = floor((f_in - 1 + f_baud) / f_baud) - 1 + * This should not overflow as long as (f_in - 1 + f_baud) does not exceed + * 2^32 - 1, which is unlikely since we represent frequencies in kHz. + */ +static inline unsigned int uart_min_clk_divisor(unsigned long in_freq, + unsigned long max_target_hz) +{ + unsigned long quotient = + (in_freq + max_target_hz - 1) / (max_target_hz); + /* Avoid underflow */ + if (quotient == 0) + return 0; + else + return quotient - 1; +} + /* Set up the baud rate in gd struct */ static void _sifive_serial_setbrg(struct uart_sifive *regs, unsigned long clock, unsigned long baud) { - writel((u32)((clock / baud) - 1), ®s->div); + writel((uart_min_clk_divisor(clock, baud)), ®s->div); } static void _sifive_serial_init(struct uart_sifive *regs)