From patchwork Wed Feb 20 05:47:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1045098 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="lA2Dp8bM"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="ChWvOdSu"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 4446BJ246Tz9s1l for ; Wed, 20 Feb 2019 16:49:44 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id C67FAC2204A; Wed, 20 Feb 2019 05:48:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAD_ENC_HEADER, KHOP_BIG_TO_CC, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 4C6DAC22026; Wed, 20 Feb 2019 05:48:29 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id A9F14C22005; Wed, 20 Feb 2019 05:47:40 +0000 (UTC) Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by lists.denx.de (Postfix) with ESMTPS id B8FAFC22014 for ; Wed, 20 Feb 2019 05:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1550641657; x=1582177657; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AGopGUiXazjgN5ZuY1nzw0BAbdwpOrkv1RV7FfRgwcQ=; b=lA2Dp8bMAr4JXMckUCKjn3WPeAf173iLdcIDARaunKBzQVS7gQ2ZdI6v +L5VCM5ranRhddmEw2z4U1eOOBIc2N1fDGTKxBldUDQ/ZAJq2sAhy2Quw hH2XnoO1JVRchE1oRebvQuJALUO5Q2xLA59ywyJmiT9qtqZn4EMuE5bq0 2C9oXryOMAWv2Iz5BOjw18PHpt6+Ncye8QEPSvuiXAuulpTIvhz2kYMC7 sIkOurgHxYm97PoXY84qU2VWj592w7687O81Ig6ahxwxKNfoWzopKnmPm kxP/QIS1rigoSCAgEuyOe28M2ruZ6sD49WZ+Kzerp3spOKd/XizbvavHC A==; X-IronPort-AV: E=Sophos;i="5.58,388,1544457600"; d="scan'208";a="106671766" Received: from mail-bn3nam01lp2050.outbound.protection.outlook.com (HELO NAM01-BN3-obe.outbound.protection.outlook.com) ([104.47.33.50]) by ob1.hgst.iphmx.com with ESMTP; 20 Feb 2019 13:47:34 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u0pk+m+saWEBpumb8AcuizP7KdgAEiXUxCJ16WAWEek=; b=ChWvOdSuJOTuEha8Ze0Us+L+ZC1mvizkDqPITFdr8nqFO+ty+Ih3V34WLw3uxs48T+2a/IUk9U/4LnYQt+aTq7YpDwZJatJlrXwtL4Pnme5I0KGjaoXRpSzgz2fmxV3FfShZSzAlG3IAtOaecQG2zK7NV5E0bMikaTR6+0+JwrI= Received: from DM6PR04MB6059.namprd04.prod.outlook.com (20.178.226.89) by DM6PR04MB5513.namprd04.prod.outlook.com (20.178.224.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.14; Wed, 20 Feb 2019 05:47:32 +0000 Received: from DM6PR04MB6059.namprd04.prod.outlook.com ([fe80::d006:5be7:c3f:ba6c]) by DM6PR04MB6059.namprd04.prod.outlook.com ([fe80::d006:5be7:c3f:ba6c%2]) with mapi id 15.20.1622.018; Wed, 20 Feb 2019 05:47:32 +0000 From: Anup Patel To: Rick Chen , Bin Meng , Joe Hershberger , Michal Simek , Michal Simek , Lukas Auer , Masahiro Yamada , Simon Glass Thread-Topic: [PATCH v8 11/15] drivers: serial_sifive: Skip baudrate config if no input clock Thread-Index: AQHUyN/F4XbhQZb0DEWijp7fwvZ5Lg== Date: Wed, 20 Feb 2019 05:47:32 +0000 Message-ID: <20190220054531.5345-12-anup.patel@wdc.com> References: <20190220054531.5345-1-anup.patel@wdc.com> In-Reply-To: <20190220054531.5345-1-anup.patel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR03CA0014.namprd03.prod.outlook.com (2603:10b6:a02:a8::27) To DM6PR04MB6059.namprd04.prod.outlook.com (2603:10b6:5:129::25) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anup.Patel@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [129.253.179.161] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 20f64a1e-9c67-4432-4c87-08d696f6e7fd x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:DM6PR04MB5513; x-ms-traffictypediagnostic: DM6PR04MB5513: wdcipoutbound: EOP-TRUE x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; DM6PR04MB5513; 23:o1o13CoiFJ2M3EQInnYWV2qeSkQ2GbsaEXCP00k?= =?iso-8859-1?q?c86SXnvAfxkQc1rBttZDZX6tR?= =?iso-8859-1?q?ak+dYcD74vYEsKe6wG/kpC2o8jBjt3g7w+MWkxkaHz534ot7SM/?= =?iso-8859-1?q?IxYbhhFxQGftJhCHEwnsAILTzHX74J3SFoPF9D67DPK0uIddus3?= =?iso-8859-1?q?JWgqhJ3zqXV451PvKkqhlipHHCtDXCB/Xg/BbS5NdrSW82iuFF4?= =?iso-8859-1?q?pEnVRYH4fxrOpCBnLd3NnnSb+fYzI6c0KLA7DEcPJEXhozoRuTx?= =?iso-8859-1?q?v2Hj9i/DI4HmBOfBih4LJcbO08HuF8R7kmuOZwq+rcPOVgvWtbK?= =?iso-8859-1?q?u71TWUfR2nge7QrbiEVGUopJ1+wcQjZ6emicv0bYUmp9SBRaRc0?= =?iso-8859-1?q?xHP2TcAPLiQEOUbJ5piUEdDBD7+n2C5YLikE7FAYpIbrYZjokl/?= =?iso-8859-1?q?C3zfkrpsXJujdxL3fs73eXiqZY1V3oyZgkTBWyWzY4DD57Hm1BO?= =?iso-8859-1?q?LAf22bqQPVN1VHz5ikqxquNuq/59OOKYVv+Yg4TLl/uI8aH3vSv?= =?iso-8859-1?q?xgcftrYBfNhADoGr5w3Gu+5/oOQlsoS1GJNm/u7oJ5uqskOFV4p?= =?iso-8859-1?q?q60wscQPIXCZVaKEboZV9YUaLc7xtztz4wO2QZnSpXr0aOZTD8H?= =?iso-8859-1?q?bq4h9TB38ZOz7GU8zu1HSZK9vxyWrFaLRIM65aL70A1QJq3G93a?= =?iso-8859-1?q?AfkzAnN8B5CtbM2bXm5Z1kRHQ2p968b2H8P/60er+E34aPhzxZn?= =?iso-8859-1?q?ESQt5lAvCBYuc8GcHEgU2lK+E7XBziYmnMlw/+o4LIhzp7R34FS?= =?iso-8859-1?q?ZwxGWzvYu4Is64bLXiPfeXRBe05Vabc9FT/petFVIoDih5riD5z?= =?iso-8859-1?q?xzPmc+gK84k+smBaPgJ0MXUNtVG+hiNEpfIqukRo86pqrohJ17w?= =?iso-8859-1?q?uO0NbAKBUzPUdumq6bpeEyAY0k0fPR5Bojy7EsiZetIItnZwMmJ?= =?iso-8859-1?q?6Y5NUj/4euGXHCgAZsL7MQtZl15z/jj6dAys9qA104lY7CHLoAA?= =?iso-8859-1?q?v0pY7gnh97Ebj2lztO9nZ3AXNQF/zDW7AerMvW2TCC/gFjMTN9m?= =?iso-8859-1?q?lQVWWgb5BjHePUuG+UnlxWGqlMZEhj1eFcfEw1rLaCtfapNUTWS?= =?iso-8859-1?q?ZnEyn9oohcMukJL8CGMmKZFRYAG92b0edEl8IpRgnOZffyxb+Qr?= =?iso-8859-1?q?TyMm+RYNMpD2mxpIC6oU4zXIamkknOgOQ79MNtpS4/TXpeE38lJ?= =?iso-8859-1?q?jm/f6+mo0X+ClTkRNMs0wJzIBuETQQjx4Oo8mR6xXhxEBUJnoyj?= =?iso-8859-1?q?uPSOZzMNU6LHBSp6JPkm8NDyuLsu8D/7YJrgRoPAgWD?= x-microsoft-antispam-prvs: x-forefront-prvs: 0954EE4910 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(136003)(376002)(396003)(366004)(346002)(199004)(189003)(81166006)(81156014)(386003)(486006)(11346002)(6506007)(26005)(8936002)(6116002)(3846002)(102836004)(68736007)(7736002)(71200400001)(71190400001)(99286004)(97736004)(52116002)(305945005)(5660300002)(106356001)(476003)(446003)(2616005)(36756003)(186003)(76176011)(1076003)(4326008)(8676002)(44832011)(105586002)(54906003)(86362001)(25786009)(6436002)(6512007)(66066001)(256004)(50226002)(6486002)(7416002)(53936002)(14454004)(2906002)(72206003)(316002)(110136005)(478600001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR04MB5513; H:DM6PR04MB6059.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 06f4X8NY/Xac+n4a70sbGO6IZhuHWPA3TA1R3+4g0Gjo/HuTfN2aGCJYuHXOz+B2SEDy9AtH3+U3La5Fywr9W8qsvcDCpw741Ad+ro+yHxyyAJwdQ5ttRgRbqXTkZ1mCM/EFyQuzY+/L1VVTMOkJ98et6blknr63kMHmL6FTItOgaGuSotKFtK0QLUon+yVuzzRX2gT0E41aGCCKSJ7AwWPNkX43i7IP4KLgV5mHEiBkGqsls9kaO0Z5DXZjdHkw+AFa2t61ldOlQ6yxZS1hWHwojME4egYBq0cxitSEhkemo+i2iW5bb4eulxUrSHERiVPK7YrPj0GF3m0Kt8WEf+zdZEwINmLp4+2O/zdnNim/GvJL8sDyw4mDNNm37BkzWAVX7E5jRHISSvmOxgpEKLqo6JG1/ivderSp1RX1zy8= MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20f64a1e-9c67-4432-4c87-08d696f6e7fd X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2019 05:47:27.3280 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB5513 Cc: Palmer Dabbelt , Alexander Graf , U-Boot Mailing List Subject: [U-Boot] [PATCH v8 11/15] drivers: serial_sifive: Skip baudrate config if no input clock X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Atish Patra It is possible that input clock is not available because clk device was not available and 'clock-frequency' DT property is also not available. In this case, instead of failing we should just skip baudrate config by returning zero. Signed-off-by: Atish Patra Signed-off-by: Anup Patel Reviewed-by: Alexander Graf --- drivers/serial/serial_sifive.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/serial/serial_sifive.c b/drivers/serial/serial_sifive.c index ea4d35d48c..537bc7a975 100644 --- a/drivers/serial/serial_sifive.c +++ b/drivers/serial/serial_sifive.c @@ -99,27 +99,27 @@ static int _sifive_serial_getc(struct uart_sifive *regs) static int sifive_serial_setbrg(struct udevice *dev, int baudrate) { - int err; + int ret; struct clk clk; struct sifive_uart_platdata *platdata = dev_get_platdata(dev); + u32 clock = 0; - err = clk_get_by_index(dev, 0, &clk); - if (!err) { - err = clk_get_rate(&clk); - if (!IS_ERR_VALUE(err)) - platdata->clock = err; - } else if (err != -ENOENT && err != -ENODEV && err != -ENOSYS) { + ret = clk_get_by_index(dev, 0, &clk); + if (IS_ERR_VALUE(ret)) { debug("SiFive UART failed to get clock\n"); - return err; - } - - if (!platdata->clock) - platdata->clock = dev_read_u32_default(dev, "clock-frequency", 0); - if (!platdata->clock) { - debug("SiFive UART clock not defined\n"); - return -EINVAL; + ret = dev_read_u32(dev, "clock-frequency", &clock); + if (IS_ERR_VALUE(ret)) { + debug("SiFive UART clock not defined\n"); + return 0; + } + } else { + clock = clk_get_rate(&clk); + if (IS_ERR_VALUE(clock)) { + debug("SiFive UART clock get rate failed\n"); + return 0; + } } - + platdata->clock = clock; _sifive_serial_setbrg(platdata->regs, platdata->clock, baudrate); return 0;