From patchwork Wed Feb 20 05:47:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1045105 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="PddjGxkl"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="PLGCSz2l"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 4446Fc17XQz9s3l for ; Wed, 20 Feb 2019 16:52:36 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id C659AC21FDD; Wed, 20 Feb 2019 05:49:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAD_ENC_HEADER, KHOP_BIG_TO_CC, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id B70C2C2203E; Wed, 20 Feb 2019 05:48:49 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id BBB5FC22014; Wed, 20 Feb 2019 05:47:30 +0000 (UTC) Received: from esa6.hgst.iphmx.com (esa6.hgst.iphmx.com [216.71.154.45]) by lists.denx.de (Postfix) with ESMTPS id 4B8C2C2203A for ; Wed, 20 Feb 2019 05:47:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1550641647; x=1582177647; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jki6yc4Dgywc+/2UFctRcM6KIGbue7NLrZzh+PGks1I=; b=PddjGxklhAuwAYwwbNlZaqf9iY84DjB3gkjdCOxrPYMui67m2odwC/fW ku03CTr8j0hlN0kKqJKG1+sdxtsbDtbaacSc6MwzDMbkqI5mf6H6uBoiA SnJjX2xVjWgUN7aPJzHEKR4ZvgncMZHHuliSijAypcBAygqb8v50bNQsJ IDFTY50lJkQR+6Z7fAJFRgJvRc554P6OAQe2bPvhynOrIf7I9RQlDHvad AJNBiiSOk6xZLLyGYFDVPyU0qKvSwNY17OdXv1JO180QwjZwZbJ/LnGol HV8QsU14PdA7gzAad0/TyoGyyAia/dxiZW9cPhRwkseZfE7/aA6rUV3sZ Q==; X-IronPort-AV: E=Sophos;i="5.58,388,1544457600"; d="scan'208";a="103454804" Received: from mail-bn3nam01lp2051.outbound.protection.outlook.com (HELO NAM01-BN3-obe.outbound.protection.outlook.com) ([104.47.33.51]) by ob1.hgst.iphmx.com with ESMTP; 20 Feb 2019 13:47:23 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FqeSzEs6ykL19UgS2gTj9tz1EZqeYicmQtYCOl+rl+Y=; b=PLGCSz2l7KkkqpBeC0kT3pfELRvspBAWpYbyRBAG1dF2cplpzVa8xkaJPjQMg2cGxcHZwfEnI+urrsIkx+WRNxRFY6a2abfGOP1gDka7L3irwxmMnNFhhB/i0o2S75MLbcm2+PMRBhlZbz+EBuoWOkEUHuihiBMkfZz2fx6+fXI= Received: from DM6PR04MB6059.namprd04.prod.outlook.com (20.178.226.89) by DM6PR04MB5513.namprd04.prod.outlook.com (20.178.224.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.14; Wed, 20 Feb 2019 05:47:21 +0000 Received: from DM6PR04MB6059.namprd04.prod.outlook.com ([fe80::d006:5be7:c3f:ba6c]) by DM6PR04MB6059.namprd04.prod.outlook.com ([fe80::d006:5be7:c3f:ba6c%2]) with mapi id 15.20.1622.018; Wed, 20 Feb 2019 05:47:21 +0000 From: Anup Patel To: Rick Chen , Bin Meng , Joe Hershberger , Michal Simek , Michal Simek , Lukas Auer , Masahiro Yamada , Simon Glass Thread-Topic: [PATCH v8 10/15] drivers: serial_sifive: Fix baud rate calculation Thread-Index: AQHUyN+/rzIM1uAaVEaiudgQVNSI1g== Date: Wed, 20 Feb 2019 05:47:21 +0000 Message-ID: <20190220054531.5345-11-anup.patel@wdc.com> References: <20190220054531.5345-1-anup.patel@wdc.com> In-Reply-To: <20190220054531.5345-1-anup.patel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR03CA0014.namprd03.prod.outlook.com (2603:10b6:a02:a8::27) To DM6PR04MB6059.namprd04.prod.outlook.com (2603:10b6:5:129::25) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anup.Patel@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [129.253.179.161] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0514ba9b-a11e-4825-bc8f-08d696f6e14b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:DM6PR04MB5513; x-ms-traffictypediagnostic: DM6PR04MB5513: wdcipoutbound: EOP-TRUE x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; DM6PR04MB5513; 23:kGSJB0KfYNic4XffdqYHuPPhnjbIG3sjkUeXhrm?= =?iso-8859-1?q?2hMPJ2q3aYJHot44O8jq0wXu+?= =?iso-8859-1?q?zQQ9bGHVkMxS+yNu5Ke+hfo8eq2CHEVhY3SP5nZiA5BsqJzeZOi?= =?iso-8859-1?q?lURP/40w14p9ByMk+AQoMrZPF40P/PG1pQxEYK/0ImPGolhCgq3?= =?iso-8859-1?q?+aFMwPmH1v80oOGN0U+H56eLiLfDIIUmfOiTcbQFidSr86uYvj1?= =?iso-8859-1?q?BFsUzqFHXdI/C0zW2Fcp0/mR+TD7vgINheiT+D7FbkNbvEeo5DP?= =?iso-8859-1?q?Qn9Fl/ISWKuAIaCoWdW+iuF/77YL4+dfpW0gpbEhghXC3I3PFUe?= =?iso-8859-1?q?EDbGu+GYjhf1lnge6f+TK6lgwjeW0eSfGv18QU3nrGiyM9s075g?= =?iso-8859-1?q?ClvbBEkCROOgaLfrGsqI5WgQPbzeM6KcNufFPDrm5s6WMyt/T3+?= =?iso-8859-1?q?qJlLR0eYR7uxmzM0C/MdXBD8+a8LUSbdP0EcUUh28zgu1Qi8fUi?= =?iso-8859-1?q?mRT6YNDkBNn9aoQ1gkCKjnUveFZyYSJXgXvxW9Q3pxQuRBcYgmJ?= =?iso-8859-1?q?Xu03X5jnISSX0GgusL57r4QifBqlzZrAvYT+zBPpUbL2X2EjWIS?= =?iso-8859-1?q?S6mZw66zsFWVKUYDhxD8guSRbYn9QQ3lsNAwwOKSgADJQMZsjC4?= =?iso-8859-1?q?yBFPZxYcU7ZJf17qp0W9Cqq0ENi0hiFFkFkxboBfF7D5qRQtm6I?= =?iso-8859-1?q?9YsEgJZl3Y3jJgOj82MRY9zICjqthpPBYTvvBc/SCPzm5nkiT5T?= =?iso-8859-1?q?Z3OhjucwkBI0Kpiy+1Gx7B2lJjNJ13idGkTh9MrcAkgW/wVWiLp?= =?iso-8859-1?q?YyTJkredXzW1MvjRryCajsejLwRqGB7nMb8kykwUejZKfpJnS39?= =?iso-8859-1?q?Bc8pKnYg/qpVm9wysJnnjBcsh7rzipPBDrG3dvGWurgqIc+JE2Q?= =?iso-8859-1?q?ppQX4tnyiXOsK/n1PPeFSxxdqBaFw4EYX2fW1g+2NyywYuevEW1?= =?iso-8859-1?q?e9scAVPgXXiUH0zPP+CkxTV3RjZqLtUYyszvFZn1QGQ2tyx5G2I?= =?iso-8859-1?q?fJGz0jXjuhZj2UQ9xs16vodEzR1l4FqJdpAlc1o8CGFQ3xZNHZs?= =?iso-8859-1?q?yVOZyBOeDY0mB2qXXxxvcvVbYZNqK9vs3Q/DskS/490qZLkkj2W?= =?iso-8859-1?q?emndOQHF1wLjoLHEBAm/uk9hLFeeLdMnSD5VCRkzA6wleQEK9AF?= =?iso-8859-1?q?6TihenM2ohJ47dheJHgxLc/OtSs70V3ozMRS0zVhiYk3oGdz08s?= =?iso-8859-1?q?1ifZzX3aw/ccRyyp/JQXijckT6EGktOLK/t8Rpk4fxHTGyGzdPE?= =?iso-8859-1?q?e2Zq+PSJKfMkOmm15xUnbhqVRZ8jQrnioIJoWlXuEpW/u2j18oz?= =?iso-8859-1?q?rvsQ8/+wzsNnkg=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0954EE4910 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(136003)(376002)(396003)(366004)(346002)(199004)(189003)(81166006)(81156014)(386003)(486006)(11346002)(6506007)(26005)(8936002)(6116002)(3846002)(102836004)(68736007)(7736002)(71200400001)(71190400001)(99286004)(97736004)(52116002)(305945005)(5660300002)(106356001)(476003)(446003)(2616005)(36756003)(186003)(76176011)(1076003)(4326008)(8676002)(44832011)(105586002)(54906003)(86362001)(25786009)(6436002)(6512007)(66066001)(256004)(50226002)(6486002)(14444005)(7416002)(53936002)(14454004)(2906002)(72206003)(316002)(110136005)(478600001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR04MB5513; H:DM6PR04MB6059.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: jvgxhIbDSoe3dK/xum0LQXrL42VkJDFfqrf2o8upR/epDsCO3j6Pck5IBpCpDWGHEAIya3I7QZgxQv2b1CK6BGw09yx89Gb5xj5ZvgBI5N0Sh4Ab8jPCDPvVb4V8Fs54Jj2ICtd/tknoCTAiFztcDDMxfcVerZMDIintDEXia/UicnBISoQClkaK/yBbG4ax55ZJqB7s41EY4PhWy/hrDoADrfHs3gIEmeoOHL/Zx3nkuRg8bGUr8qFEb4xg+DJfP24W3J+EdDyxu3neIqLWn2mPlPPJ9cbvc8lOmOW3o7yPfkR+q2/e7Ot8yx9FfENgzOwya+/qGFYBYrtUtlA0rElk1b62Lb79BqI04V8Zrg9nzYOP2xmumoFlPHycrDipGB9lwhCNMAFiVzcxVaOUJTZzbfuL3cDfd+7NcKjkNcw= MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0514ba9b-a11e-4825-bc8f-08d696f6e14b X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2019 05:47:16.0800 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB5513 Cc: Palmer Dabbelt , Alexander Graf , U-Boot Mailing List Subject: [U-Boot] [PATCH v8 10/15] drivers: serial_sifive: Fix baud rate calculation X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Atish Patra Compute the baud rate multipler with more precision. Signed-off-by: Atish Patra Signed-off-by: Anup Patel Reviewed-by: Alexander Graf Reviewed-by: Lukas Auer --- drivers/serial/serial_sifive.c | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/serial/serial_sifive.c b/drivers/serial/serial_sifive.c index 341728a690..ea4d35d48c 100644 --- a/drivers/serial/serial_sifive.c +++ b/drivers/serial/serial_sifive.c @@ -33,16 +33,40 @@ struct uart_sifive { }; struct sifive_uart_platdata { - unsigned int clock; + unsigned long clock; int saved_input_char; struct uart_sifive *regs; }; +/** + * Find minimum divisor divides in_freq to max_target_hz; + * Based on uart driver n SiFive FSBL. + * + * f_baud = f_in / (div + 1) => div = (f_in / f_baud) - 1 + * The nearest integer solution requires rounding up as to not exceed + * max_target_hz. + * div = ceil(f_in / f_baud) - 1 + * = floor((f_in - 1 + f_baud) / f_baud) - 1 + * This should not overflow as long as (f_in - 1 + f_baud) does not exceed + * 2^32 - 1, which is unlikely since we represent frequencies in kHz. + */ +static inline unsigned int uart_min_clk_divisor(unsigned long in_freq, + unsigned long max_target_hz) +{ + unsigned long quotient = + (in_freq + max_target_hz - 1) / (max_target_hz); + /* Avoid underflow */ + if (quotient == 0) + return 0; + else + return quotient - 1; +} + /* Set up the baud rate in gd struct */ static void _sifive_serial_setbrg(struct uart_sifive *regs, unsigned long clock, unsigned long baud) { - writel((u32)((clock / baud) - 1), ®s->div); + writel((uart_min_clk_divisor(clock, baud)), ®s->div); } static void _sifive_serial_init(struct uart_sifive *regs)