diff mbox series

[U-Boot,v2,4/9] arm: exynos: odroid-xu3: Display info late to have proper type

Message ID 20190213164648.26579-5-krzk@kernel.org
State Changes Requested
Delegated to: Minkyu Kang
Headers show
Series arm: exynos: Fix reboot on Odroid HC1 | expand

Commit Message

Krzysztof Kozlowski Feb. 13, 2019, 4:46 p.m. UTC 
From: Krzysztof Kozlowski <krzysztof.kozlowski@proceq.com>

Printing the "Type" of board requires proper detection of revision which
can happen only late because regulators are needed.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@proceq.com>
---
 board/samsung/common/board.c | 2 +-
 configs/odroid-xu3_defconfig | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Feb. 14, 2019, 7:37 a.m. UTC | #1 
On Wed, 13 Feb 2019 at 17:49, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> From: Krzysztof Kozlowski <krzysztof.kozlowski@proceq.com>
>
> Printing the "Type" of board requires proper detection of revision which
> can happen only late because regulators are needed.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@proceq.com>

I should sent it from my @kernel.org account. I'll fix it in v3 but
let me wait for some more comments/review.

Best regards,
Krzysztof

> ---
>  board/samsung/common/board.c | 2 +-
>  configs/odroid-xu3_defconfig | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/board/samsung/common/board.c b/board/samsung/common/board.c
> index 52a2764a1919..632732288e73 100644
> --- a/board/samsung/common/board.c
> +++ b/board/samsung/common/board.c
> @@ -249,7 +249,7 @@ int board_eth_init(bd_t *bis)
>         return 0;
>  }
>
> -#ifdef CONFIG_DISPLAY_BOARDINFO
> +#if defined(CONFIG_DISPLAY_BOARDINFO) || defined(CONFIG_DISPLAY_BOARDINFO_LATE)
>  int checkboard(void)
>  {
>         if (IS_ENABLED(CONFIG_BOARD_TYPES)) {
> diff --git a/configs/odroid-xu3_defconfig b/configs/odroid-xu3_defconfig
> index f6f05b294833..57aca5e015fc 100644
> --- a/configs/odroid-xu3_defconfig
> +++ b/configs/odroid-xu3_defconfig
> @@ -11,6 +11,8 @@ CONFIG_FIT=y
>  CONFIG_FIT_BEST_MATCH=y
>  CONFIG_SILENT_CONSOLE=y
>  CONFIG_CONSOLE_MUX=y
> +# CONFIG_DISPLAY_BOARDINFO is not set
> +CONFIG_DISPLAY_BOARDINFO_LATE=y
>  CONFIG_MISC_INIT_R=y
>  CONFIG_SYS_PROMPT="ODROID-XU3 # "
>  CONFIG_CMD_THOR_DOWNLOAD=y
> --
> 2.17.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
diff mbox series

Patch

diff --git a/board/samsung/common/board.c b/board/samsung/common/board.c
index 52a2764a1919..632732288e73 100644
--- a/board/samsung/common/board.c
+++ b/board/samsung/common/board.c
@@ -249,7 +249,7 @@  int board_eth_init(bd_t *bis)
 	return 0;
 }
 
-#ifdef CONFIG_DISPLAY_BOARDINFO
+#if defined(CONFIG_DISPLAY_BOARDINFO) || defined(CONFIG_DISPLAY_BOARDINFO_LATE)
 int checkboard(void)
 {
 	if (IS_ENABLED(CONFIG_BOARD_TYPES)) {
diff --git a/configs/odroid-xu3_defconfig b/configs/odroid-xu3_defconfig
index f6f05b294833..57aca5e015fc 100644
--- a/configs/odroid-xu3_defconfig
+++ b/configs/odroid-xu3_defconfig
@@ -11,6 +11,8 @@  CONFIG_FIT=y
 CONFIG_FIT_BEST_MATCH=y
 CONFIG_SILENT_CONSOLE=y
 CONFIG_CONSOLE_MUX=y
+# CONFIG_DISPLAY_BOARDINFO is not set
+CONFIG_DISPLAY_BOARDINFO_LATE=y
 CONFIG_MISC_INIT_R=y
 CONFIG_SYS_PROMPT="ODROID-XU3 # "
 CONFIG_CMD_THOR_DOWNLOAD=y