Message ID | 20190213164648.26579-2-krzk@kernel.org |
---|---|
State | Changes Requested |
Delegated to: | Minkyu Kang |
Headers | show |
Series | arm: exynos: Fix reboot on Odroid HC1 | expand |
On Wed, 13 Feb 2019 17:46:40 +0100 Krzysztof Kozlowski <krzk@kernel.org> wrote: > When stopping the ADC_V2_CON1_STC_EN should be cleared. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > drivers/adc/exynos-adc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/adc/exynos-adc.c b/drivers/adc/exynos-adc.c > index d33e3d632afc..12c49fc8cefb 100644 > --- a/drivers/adc/exynos-adc.c > +++ b/drivers/adc/exynos-adc.c > @@ -62,7 +62,7 @@ int exynos_adc_stop(struct udevice *dev) > > /* Stop conversion */ > cfg = readl(®s->con1); > - cfg |= ~ADC_V2_CON1_STC_EN; > + cfg &= ~ADC_V2_CON1_STC_EN; > > writel(cfg, ®s->con1); > Reviewed-by: Lukasz Majewski <lukma@denx.de> Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
diff --git a/drivers/adc/exynos-adc.c b/drivers/adc/exynos-adc.c index d33e3d632afc..12c49fc8cefb 100644 --- a/drivers/adc/exynos-adc.c +++ b/drivers/adc/exynos-adc.c @@ -62,7 +62,7 @@ int exynos_adc_stop(struct udevice *dev) /* Stop conversion */ cfg = readl(®s->con1); - cfg |= ~ADC_V2_CON1_STC_EN; + cfg &= ~ADC_V2_CON1_STC_EN; writel(cfg, ®s->con1);
When stopping the ADC_V2_CON1_STC_EN should be cleared. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/adc/exynos-adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)