From patchwork Sat Feb 9 06:33:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1039134 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="L6O5tA15"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="ZQfKXPmV"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43xMmZ3Mpyz9sMp for ; Sat, 9 Feb 2019 17:37:34 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 1CD39C21FBA; Sat, 9 Feb 2019 06:36:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 08E91C21FFA; Sat, 9 Feb 2019 06:34:28 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 73C69C21E4E; Sat, 9 Feb 2019 06:33:18 +0000 (UTC) Received: from esa6.hgst.iphmx.com (esa6.hgst.iphmx.com [216.71.154.45]) by lists.denx.de (Postfix) with ESMTPS id 167D9C21EE3 for ; Sat, 9 Feb 2019 06:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1549693995; x=1581229995; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AGopGUiXazjgN5ZuY1nzw0BAbdwpOrkv1RV7FfRgwcQ=; b=L6O5tA15lPtK7tBtO/9STNktb9pYU4rlVrIIltSG1aTuv3C+IwIwsdP5 h/Erebzr7bOQlCWKmnqyRH4Q9qUx7KuahTI27Uy32HxVMYTih11P24e98 N4BNIzcHzmDq+WK1Gj3utCqRbCjPnYNYV9nBLvicZ+HSF9WcwIACVOB6s R6nYJ3n9A6AiHw0E3jsyalmalr4InDABULtGdUxOrpKZICDJUgTbTHeyu DeISRgBrSmX73bJFs4pefKSuGYLlnl7GzRaplCeP/G7a2r5PDXROYX34I oDBBpwLFURPTGl6jaJsDRki30hz2JtfRY2oGhwZPslhpC+aufdiYPGDda A==; X-IronPort-AV: E=Sophos;i="5.58,350,1544457600"; d="scan'208";a="102612002" Received: from mail-bn3nam04lp2056.outbound.protection.outlook.com (HELO NAM04-BN3-obe.outbound.protection.outlook.com) ([104.47.46.56]) by ob1.hgst.iphmx.com with ESMTP; 09 Feb 2019 14:33:12 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u0pk+m+saWEBpumb8AcuizP7KdgAEiXUxCJ16WAWEek=; b=ZQfKXPmVXIl2aWHSDGw0SrSz3r+j9yGsUG0UDdDTN2KMH+3tGwe2pAyoqI0Xyo1rsRgLglQ5xRyGPZJJ4bblotDbh+qDT2xbYfCkUB3FqyuVx77VVaTogQUNbI+Bl1omuP+FyBpB2IfLOZgV0PVs66enqARc8HhJW40fEk1pD50= Received: from MN2PR04MB6061.namprd04.prod.outlook.com (20.178.247.148) by MN2SPR01MB0008.namprd04.prod.outlook.com (20.179.144.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.17; Sat, 9 Feb 2019 06:33:09 +0000 Received: from MN2PR04MB6061.namprd04.prod.outlook.com ([fe80::2cdb:c465:af57:8be1]) by MN2PR04MB6061.namprd04.prod.outlook.com ([fe80::2cdb:c465:af57:8be1%7]) with mapi id 15.20.1601.016; Sat, 9 Feb 2019 06:33:09 +0000 From: Anup Patel To: Rick Chen , Bin Meng , Joe Hershberger , Michal Simek , Michal Simek , Lukas Auer , Masahiro Yamada , Simon Glass Thread-Topic: [PATCH v6 12/16] drivers: serial_sifive: Skip baudrate config if no input clock Thread-Index: AQHUwEFSmq5+ihyQL0CpdOV/biHWcg== Date: Sat, 9 Feb 2019 06:33:09 +0000 Message-ID: <20190209063052.29092-13-anup.patel@wdc.com> References: <20190209063052.29092-1-anup.patel@wdc.com> In-Reply-To: <20190209063052.29092-1-anup.patel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MA1PR0101CA0047.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:22::33) To MN2PR04MB6061.namprd04.prod.outlook.com (2603:10b6:208:de::20) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anup.Patel@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [49.207.49.10] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; MN2SPR01MB0008; 6:pZXzTDqbJrAq53md1zZkx5oRhiDprBlk4vlyIUnu767ooWiSeQ5WDOhMkp5Kem04/wHu6De/8b0h4DuRBDQsRgBrg3hUM/5+EBx8n3X0Y/tMDswZCPjqqDmsljlLgx8a9qBiWXxfsPF5lLNy6PeOUgOl1QpmUivZqgH2tPSEeXFPvdoWRoxCAQyYQiYmi5G8LlEOIC9XIhFsyijW4mZotbx0r46J4wWWoxcl1EDMw+FiiYLiT6bOuOY6/7zE8kOB3Xj/Ic/RtPuvt6SAOsMAyILP/E/r2wLFf2L6fGtJKv7eqI9xv/E+IyryLgKxlljBcBI/wwFlJ1tL7YiNMwboS5xk+9ni2RxuQHlIMxpBu9rpRnBHvzEIXMSslMGypzYX8nayodUjgh60lA0lxzN/3+b85F/9zF59L0YnGsvKkhdUTT9sMWFqoqkcNW13Iq3QIFZYPY5beHRcKc1g1WJWew==; 5:9TrCZfC3XNGedBGe/SygE/Ip+I0G/gGd+9OgpXH8lhsw+u05JTeFm51oHKctwrGhd1tnc5yepriRAFI1qAOma6Ay41HdwybZ/j5N8amzVZmMrnAFsp90YKGuTjIyHsQnPHXJvWdlMikD0njU4l5opbJY/r6ORXUKoqLi0+5R6rqm0iEmMu2f6pL0VD1BXoHruPrLqkDyT+RQJUU5NlWxrQ==; 7:k6lolzNR+kxNXZ7TvLCUR0ASdgHic3XudvAxq0l/CjZWWMvuphuGkB6Mbwe1osCCNKB6qU4iiyVLOevCiTBGjuYLrTfkQwsI/lhkB7ZiOSE/EzjjIAbXV/OExMZ9sKOe0OreqqFYY6m6f5M9ck2bww== x-ms-office365-filtering-correlation-id: 0147df0d-15fa-40d6-606b-08d68e58751e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020); SRVR:MN2SPR01MB0008; x-ms-traffictypediagnostic: MN2SPR01MB0008: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-forefront-prvs: 09435FCA72 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(366004)(396003)(346002)(39860400002)(136003)(189003)(199004)(99286004)(1076003)(76176011)(55236004)(186003)(102836004)(52116002)(6436002)(72206003)(6506007)(71190400001)(71200400001)(478600001)(26005)(6512007)(68736007)(53936002)(386003)(97736004)(256004)(6116002)(3846002)(105586002)(305945005)(86362001)(2616005)(81156014)(8676002)(50226002)(25786009)(446003)(7736002)(106356001)(476003)(11346002)(2906002)(66066001)(14454004)(6486002)(44832011)(486006)(7416002)(36756003)(316002)(54906003)(4326008)(110136005)(8936002)(81166006); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2SPR01MB0008; H:MN2PR04MB6061.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: aoLYzKWIC+JE7Dsoh1rPVFWk5Q4SwjP+W39eFOx/m5J76OMeU+G4cf9EDoqZKThk6CUUoTLDUVSu74AqFqM1r38PGpplYFc6xa7D3qVZHmIyXInvZd8aHsKIAAuMN7JfWDl602YI8D7OdS2KJf5zERz123fURu482dIwTHst/jDZMzYB/tLnbl+ekqvZ5lqcmezVkZgKOU5fQCfv/sy31B/rq/DvL/7s12LnM4r7+H2+YZbj1mkM0JFbgteQOTd9wJLjauwxOiXyJK93wMbYRmMg6dAw4zZSjBhe51zlLlOd2c5LwOTPfnXN+NjbwGMsCeb5jyeJD2zA+x6hV1zwjqJ4BDglLQ0kcZdbbektNioujZfaxo/hMP5zQynqkl3iY6NpJXv/78w+4fwyiX3wckYW97f5y45kpyW7om/tRUo= MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0147df0d-15fa-40d6-606b-08d68e58751e X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2019 06:33:05.2946 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2SPR01MB0008 Cc: Palmer Dabbelt , Alexander Graf , U-Boot Mailing List Subject: [U-Boot] [PATCH v6 12/16] drivers: serial_sifive: Skip baudrate config if no input clock X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Atish Patra It is possible that input clock is not available because clk device was not available and 'clock-frequency' DT property is also not available. In this case, instead of failing we should just skip baudrate config by returning zero. Signed-off-by: Atish Patra Signed-off-by: Anup Patel Reviewed-by: Alexander Graf --- drivers/serial/serial_sifive.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/serial/serial_sifive.c b/drivers/serial/serial_sifive.c index ea4d35d48c..537bc7a975 100644 --- a/drivers/serial/serial_sifive.c +++ b/drivers/serial/serial_sifive.c @@ -99,27 +99,27 @@ static int _sifive_serial_getc(struct uart_sifive *regs) static int sifive_serial_setbrg(struct udevice *dev, int baudrate) { - int err; + int ret; struct clk clk; struct sifive_uart_platdata *platdata = dev_get_platdata(dev); + u32 clock = 0; - err = clk_get_by_index(dev, 0, &clk); - if (!err) { - err = clk_get_rate(&clk); - if (!IS_ERR_VALUE(err)) - platdata->clock = err; - } else if (err != -ENOENT && err != -ENODEV && err != -ENOSYS) { + ret = clk_get_by_index(dev, 0, &clk); + if (IS_ERR_VALUE(ret)) { debug("SiFive UART failed to get clock\n"); - return err; - } - - if (!platdata->clock) - platdata->clock = dev_read_u32_default(dev, "clock-frequency", 0); - if (!platdata->clock) { - debug("SiFive UART clock not defined\n"); - return -EINVAL; + ret = dev_read_u32(dev, "clock-frequency", &clock); + if (IS_ERR_VALUE(ret)) { + debug("SiFive UART clock not defined\n"); + return 0; + } + } else { + clock = clk_get_rate(&clk); + if (IS_ERR_VALUE(clock)) { + debug("SiFive UART clock get rate failed\n"); + return 0; + } } - + platdata->clock = clock; _sifive_serial_setbrg(platdata->regs, platdata->clock, baudrate); return 0;