From patchwork Tue Feb 5 13:05:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1036730 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="h9HHZFXZ"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="AZyFQyKN"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43v4c30hY6z9s4V for ; Wed, 6 Feb 2019 00:07:14 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 8A65CC21F1A; Tue, 5 Feb 2019 13:06:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=KHOP_BIG_TO_CC, RCVD_IN_SORBS_WEB, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id D1597C21F05; Tue, 5 Feb 2019 13:06:12 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 9A276C21F4D; Tue, 5 Feb 2019 13:05:42 +0000 (UTC) Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by lists.denx.de (Postfix) with ESMTPS id AEA50C21F6D for ; Tue, 5 Feb 2019 13:05:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1549371938; x=1580907938; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AGopGUiXazjgN5ZuY1nzw0BAbdwpOrkv1RV7FfRgwcQ=; b=h9HHZFXZrON8CniRtqVoIzkL6W5HGWrrjFRQ7XupynXEfciX59axIKBU cn5VJW0stBou7WrAxyF3hX2xYyNzm1t1P+yb+L1sXHwS4dwFMgk4XxSd8 cflU91TWWZhcChpEsLlHKkN6P8+5RP+wkQ9n64D9Wy5PBPJ8NMx+EsSAJ +UoivsTltgc5QSw5wQnErfjcRSHkO5YrwquQabaOWk34xH4HF0Zxx3v5w PyiUJLLR+anTSy4+Dq6a8G1MiLrWdHemruDY+vNgqvdS4dwHu9BBmNiIo +uF/Rjb672AJcco+QTJ695ZtDLRhpPTrmGMkW+0mjXTlC7zfdlN+q2xjf Q==; X-IronPort-AV: E=Sophos;i="5.56,564,1539619200"; d="scan'208";a="205632266" Received: from mail-by2nam03lp2054.outbound.protection.outlook.com (HELO NAM03-BY2-obe.outbound.protection.outlook.com) ([104.47.42.54]) by ob1.hgst.iphmx.com with ESMTP; 05 Feb 2019 21:05:37 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u0pk+m+saWEBpumb8AcuizP7KdgAEiXUxCJ16WAWEek=; b=AZyFQyKN4BoTyHR1RBxjngXH1hC9Lxf3+TI6vQMKIqrZxb6j0e5Xfag1R6B/+uW9aJa3kiMl3kzUvmBQBdlH5fLs7dS+kyjQSR7Rg7MNJnhVVFUW2X7KXyQG72QW3+XYgtDMRED6JrOHv+ju66gOtGpQEvLXQpjxFc+SxBVM538= Received: from BYAPR04MB5303.namprd04.prod.outlook.com (20.178.49.148) by BYAPR04MB6229.namprd04.prod.outlook.com (20.178.235.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.17; Tue, 5 Feb 2019 13:05:35 +0000 Received: from BYAPR04MB5303.namprd04.prod.outlook.com ([fe80::add1:92cc:65d7:5d94]) by BYAPR04MB5303.namprd04.prod.outlook.com ([fe80::add1:92cc:65d7:5d94%2]) with mapi id 15.20.1580.019; Tue, 5 Feb 2019 13:05:35 +0000 From: Anup Patel To: Rick Chen , Bin Meng , Joe Hershberger , Michal Simek , Michal Simek , Lukas Auer , Masahiro Yamada , Simon Glass Thread-Topic: [PATCH v5 12/15] drivers: serial_sifive: Skip baudrate config if no input clock Thread-Index: AQHUvVN75V5CdgDqhEmXQR2xk+sa0g== Date: Tue, 5 Feb 2019 13:05:35 +0000 Message-ID: <20190205130346.77175-13-anup.patel@wdc.com> References: <20190205130346.77175-1-anup.patel@wdc.com> In-Reply-To: <20190205130346.77175-1-anup.patel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MAXPR0101CA0071.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:e::33) To BYAPR04MB5303.namprd04.prod.outlook.com (2603:10b6:a03:c8::20) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anup.Patel@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [49.207.55.104] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR04MB6229; 6:KTzC6XMNRmrBpzsTVAKy0vDfwyMoP9PTiyrL+EVpwTtRhBBhVqOYApxpsyYsoG/P7+GMEMOfhf71WR4A7/wzRBYZBYogT03TTv6qEINZ+GxZRrUp6F7HALBN/Hesa/arrXzUhGG4UKlkI/vIydeS6IGNIYnV+n09FsPD8mfOJ+BnFZJ/4fSRAdU+VfZUVM86Y6YuhAJhXPRclB6lVTBiuWnrAZFF0St7pDHLar3tx+RoxUTK0Ky0a3yFVPjxBODWeRdbc7NsdiYgxaLbcw1JzhnzehYuc3YMknP8hEj+pmuzT/rfWFn/4Nh+gLkpXVsKl2BU54VLOjzjP5VmYL78SQEgaK0XZlLX6M2q2goLyYXgfIUJ2G5CUcB45bzCsn2f0JEWaTEW4W5DXCtrGTfJYsBlRg513nZSpRaZqPlHF6WsSBlP70oth4JVLcPpDV8gNzxznCwYGu2jAc1bWqB9yQ==; 5:0McB140/T8Oofe5MAPQ77dQs7KLL5ZBZwN4sH007hj94mINCARdFwzfLlL+oa21vxjXDbsjfwygdZ7M3gCVy3Gc3/gQP5luKPsST3OxH681btf1+cBFu9S5VrYNS+aEC/7ERoqEq3uTxT58SmU89LX6zJNW4uPGSZIgYZxqRiIJjaMsYoXURayG3X53lP9hEB5+uxmQ4o+KEF+Z50IU5zg==; 7:T36gXFUebdwf9hbrTE5yZ1RVxJDKMBSzeJnC0nMiI2qi9lbTarbhBF9FlkIjrWUg+KA1ue1M8loYEPBuClXUdRmT0d04KM3IA0U9i4wkszY4LdcCqeRZoOz1eQEZw9SOj3GAbQQl9Znpx17LQrIFEQ== x-ms-office365-filtering-correlation-id: b81b5257-f01f-424d-4fb3-08d68b6a9dc3 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020); SRVR:BYAPR04MB6229; x-ms-traffictypediagnostic: BYAPR04MB6229: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-forefront-prvs: 0939529DE2 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(366004)(39860400002)(376002)(346002)(136003)(189003)(199004)(4326008)(72206003)(6512007)(54906003)(110136005)(53936002)(68736007)(7416002)(25786009)(316002)(14454004)(305945005)(36756003)(478600001)(66066001)(7736002)(1076003)(6486002)(71200400001)(71190400001)(476003)(81156014)(86362001)(81166006)(106356001)(2616005)(44832011)(256004)(486006)(8936002)(8676002)(386003)(6506007)(6116002)(3846002)(2906002)(52116002)(99286004)(55236004)(446003)(97736004)(6436002)(105586002)(186003)(102836004)(50226002)(76176011)(11346002)(26005); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR04MB6229; H:BYAPR04MB5303.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: HRgXzlzNS70uKDOWTvyORgAM9MilnhuqqMGn7PvdHLNSFpkP8DJMiTcywzSRbG7v3tQ6qgSPD/qqBcY54J+qIhcRdWhWfo1urp0yZQfkPZtC6SnoO2pFagq2SjYoAAAC4eJ9/OSNbQH7Q4Y0fJH7p8hFjmwjolI4sa+5kjEaExgbjSjDSk6E8YuAdDZ8IMhz5qY+nSb2OhYrHkKp8U+IwhaCPP0TuzykLo06vB2k8DIYskI0wS7Aovgzgwi0k5O2rrWIZzCl35DSVLu7F8rUuvANE5fekGAkMD/Y2vT1g3rfi2iJ0B331RtEAw7MDJeRMh7YO3GySqcwPtFkn4n1BhJNsLpaHxCPYVcylMeHSibeFUxotD++WUTXNYd53L7HVZHqyIEyYKMfEghzAjBX5rEIf7/zCbZ14sJNGgbUFUI= MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: b81b5257-f01f-424d-4fb3-08d68b6a9dc3 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2019 13:05:31.1694 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB6229 Cc: Palmer Dabbelt , U-Boot Mailing List , Alexander Graf , Christoph Hellwig Subject: [U-Boot] [PATCH v5 12/15] drivers: serial_sifive: Skip baudrate config if no input clock X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Atish Patra It is possible that input clock is not available because clk device was not available and 'clock-frequency' DT property is also not available. In this case, instead of failing we should just skip baudrate config by returning zero. Signed-off-by: Atish Patra Signed-off-by: Anup Patel Reviewed-by: Alexander Graf --- drivers/serial/serial_sifive.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/serial/serial_sifive.c b/drivers/serial/serial_sifive.c index ea4d35d48c..537bc7a975 100644 --- a/drivers/serial/serial_sifive.c +++ b/drivers/serial/serial_sifive.c @@ -99,27 +99,27 @@ static int _sifive_serial_getc(struct uart_sifive *regs) static int sifive_serial_setbrg(struct udevice *dev, int baudrate) { - int err; + int ret; struct clk clk; struct sifive_uart_platdata *platdata = dev_get_platdata(dev); + u32 clock = 0; - err = clk_get_by_index(dev, 0, &clk); - if (!err) { - err = clk_get_rate(&clk); - if (!IS_ERR_VALUE(err)) - platdata->clock = err; - } else if (err != -ENOENT && err != -ENODEV && err != -ENOSYS) { + ret = clk_get_by_index(dev, 0, &clk); + if (IS_ERR_VALUE(ret)) { debug("SiFive UART failed to get clock\n"); - return err; - } - - if (!platdata->clock) - platdata->clock = dev_read_u32_default(dev, "clock-frequency", 0); - if (!platdata->clock) { - debug("SiFive UART clock not defined\n"); - return -EINVAL; + ret = dev_read_u32(dev, "clock-frequency", &clock); + if (IS_ERR_VALUE(ret)) { + debug("SiFive UART clock not defined\n"); + return 0; + } + } else { + clock = clk_get_rate(&clk); + if (IS_ERR_VALUE(clock)) { + debug("SiFive UART clock get rate failed\n"); + return 0; + } } - + platdata->clock = clock; _sifive_serial_setbrg(platdata->regs, platdata->clock, baudrate); return 0;