| Message ID | 20190126023154.19749-5-martyn.welch@collabora.com |
|---|---|
| State | Accepted |
| Commit | e3b4fc9598388f47632a8c802aaa68b1154526f2 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,1/5] tools: dumpimage: Provide more feedback on error | expand |
On Sat, Jan 26, 2019 at 02:31:54AM +0000, Martyn Welch wrote: > Help message isn't clear over the use of the "-T" option (it's to declare > the type of image that the tool is operating on), which also is optional > as it defaults to the default image type. It's also missing a description > of the "-o" option, so add it. > > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> Applied to u-boot/master, thanks!
diff --git a/tools/dumpimage.c b/tools/dumpimage.c index 5c9ad36322..ee3d41dda4 100644 --- a/tools/dumpimage.c +++ b/tools/dumpimage.c @@ -196,9 +196,10 @@ static void usage(void) " -l ==> list image header information\n", params.cmdname); fprintf(stderr, - " %s -T type [-p position] [-o outfile] image\n" - " -T ==> set image type to 'type'\n" - " -p ==> 'position' (starting at 0) of the component to extract from image\n", + " %s [-T type] [-p position] [-o outfile] image\n" + " -T ==> declare image type as 'type'\n" + " -p ==> 'position' (starting at 0) of the component to extract from image\n" + " -o ==> extract component to file 'outfile'\n", params.cmdname); fprintf(stderr, " %s -h ==> print usage information and exit\n",
Help message isn't clear over the use of the "-T" option (it's to declare the type of image that the tool is operating on), which also is optional as it defaults to the default image type. It's also missing a description of the "-o" option, so add it. Signed-off-by: Martyn Welch <martyn.welch@collabora.com> --- tools/dumpimage.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)