From patchwork Wed Jan 23 16:49:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1030057 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="bjOGLd5r"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="CRkU5g0z"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43lB9v6bSPz9s3l for ; Thu, 24 Jan 2019 03:50:43 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 8E7C9C21D72; Wed, 23 Jan 2019 16:49:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC, RCVD_IN_DNSWL_BLOCKED, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 868F2C21CB1; Wed, 23 Jan 2019 16:49:40 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 26400C21D72; Wed, 23 Jan 2019 16:49:19 +0000 (UTC) Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by lists.denx.de (Postfix) with ESMTPS id 4FDE7C21D56 for ; Wed, 23 Jan 2019 16:49:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1548262156; x=1579798156; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AmwHm6MLugXWJNntqplRcTB+sRQRl608VcWm5AALqZM=; b=bjOGLd5r9youh8eDdkfD6heZkzv9N/J4hcfK3MYy1pqUOlDOGfCmbPHY 0IHc7/qJe4J3xAMDgnv+snfkWrHufqKEse/Oy+et9eI4sJLoUqbW8P0RU UQUWr5xr5OSs8N3DWGmurxVer1zej0+l3FEcqTsZsQyMnQrK+OZ5O7VMW dMHgHSDRhOhFCFZuUTmkiNXoKrhZERGnI14G7cJgJ5VmEebPy9HsSFCvm r9rBhYvoOiucv5JUti877CjS+P6gCZPgknh69Iv2gSds6MDDIgNNtRDf8 naEInZbzaYsQYc90qyvY2Ak0c8XqVzinsvkHB1KTt5YbaeHMEbYmb5gQD w==; X-IronPort-AV: E=Sophos;i="5.56,512,1539619200"; d="scan'208";a="104534132" Received: from mail-sn1nam04lp2058.outbound.protection.outlook.com (HELO NAM04-SN1-obe.outbound.protection.outlook.com) ([104.47.44.58]) by ob1.hgst.iphmx.com with ESMTP; 24 Jan 2019 00:49:14 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3aTNfY0lQkSqxLcqBZUihCW7zErFNQCbjMgV2rgvR98=; b=CRkU5g0znOEtTokjJxCwfG/WS045aUb7HDZoDiUlM5GvbtIYkkLGFsLDjHNMGZAZQZGvm53P6+c5Q5UzT/Jv1u5RUuBIRFbfETXCbeuafASdiJugPFlMbM5DN9ba0t1Ircg6mPmkp9MEQdPZm0ft0LFnKnw9sxcH7wLs5Si9Ztk= Received: from BYAPR04MB5303.namprd04.prod.outlook.com (20.178.49.148) by BYAPR04MB4405.namprd04.prod.outlook.com (20.176.252.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.16; Wed, 23 Jan 2019 16:49:12 +0000 Received: from BYAPR04MB5303.namprd04.prod.outlook.com ([fe80::add1:92cc:65d7:5d94]) by BYAPR04MB5303.namprd04.prod.outlook.com ([fe80::add1:92cc:65d7:5d94%2]) with mapi id 15.20.1537.031; Wed, 23 Jan 2019 16:49:12 +0000 From: Anup Patel To: Rick Chen , Bin Meng , Joe Hershberger , Michal Simek , Michal Simek , Lukas Auer , Masahiro Yamada , Simon Glass Thread-Topic: [PATCH v4 06/15] riscv: generic: Ensure that U-Boot runs within 4GB for 64bit systems Thread-Index: AQHUszuRY3OOV8V5pE2Vw2VfNI/eMw== Date: Wed, 23 Jan 2019 16:49:12 +0000 Message-ID: <20190123164808.128994-7-anup.patel@wdc.com> References: <20190123164808.128994-1-anup.patel@wdc.com> In-Reply-To: <20190123164808.128994-1-anup.patel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MA1PR01CA0077.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00::17) To BYAPR04MB5303.namprd04.prod.outlook.com (2603:10b6:a03:c8::20) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anup.Patel@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [49.207.49.227] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR04MB4405; 6:L/2Miq0BuXhcRO/e7z/okch6d3wSH6koWz9Hv1XzhKgiG8A45lc1FLebAvM8Q5wpPfHt8qUzJRsOnHhNbG0wJxBlVBTjhBFigskIfrI764XAODlXsamRfCeJD4V9gR3a9oq0iKxattu42dFUTMd4aAPztp4lr/guYSI9vRYMvSkCx4WYI5EXsE0g3019oky4H13NuSfdDMQTpK7C4pTCrXkmW3eSZVYcrN7VI2X1CnBTJUmFscUhqTPJujza2Du28MjmuxwkmwwQASiIZ5oWMHiUhMNkmhtO7BPEqJRYU8Vv06TfddOJcfStvRuW+STYajmM1fREVxdjLfZCaHiDNZImNc1AdIGTTUdw1APdC68g4zcWzPWPHVWY+gHZVDueJHS7TxZhEmfEjzuQFfBv5Yr6/VHjuv4oKLddfLH3cwwPzylCz38yYyFT4IbIT5T8JXcsbLK6jDze0O2gEW7uqA==; 5:7mX1il65vhen9iRudtGqcAuQjCNuARXCBEDb+30IBJ4ODFgu1zQ4qRC33nykgEWzeAtWhmbbIxZXkG0SbxvTAbVao4ff2pxhh0EIcisVTw7Bh8s3D8XLwDKfchX/ckziugIWOpz3y6CkZkvwI8OLQ2UntATD98El+xaxb9/MhP7WEkVz7CFWf1cYzaGuJhJCD7xsdoR/LN/g7V8REnYCPg==; 7:GaJnl44ioiBrjLfE8XGqsXaO+mmeSm9H29lG5nOqexv91SXi03U0RoyeCSV7nk3EJJgotvf4PBMjwS32hFJsKTswFHlKlOaM2FCVELGb8/Of5f/H7i2GPuT2WwpicJhHq0WZACEExQVbCPsdF3/LwQ== x-ms-office365-filtering-correlation-id: 112690dc-3a9e-4c0f-ad3a-08d68152b392 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600110)(711020)(4605077)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:BYAPR04MB4405; x-ms-traffictypediagnostic: BYAPR04MB4405: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-forefront-prvs: 0926B0E013 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(376002)(39860400002)(136003)(396003)(366004)(199004)(189003)(72206003)(8936002)(478600001)(97736004)(50226002)(14454004)(186003)(2906002)(105586002)(256004)(81166006)(81156014)(7736002)(305945005)(106356001)(11346002)(8676002)(2616005)(476003)(110136005)(54906003)(66066001)(36756003)(446003)(316002)(68736007)(71200400001)(99286004)(6436002)(52116002)(76176011)(6116002)(3846002)(486006)(44832011)(25786009)(55236004)(6506007)(7416002)(86362001)(1076003)(6486002)(386003)(26005)(102836004)(4326008)(53936002)(39060400002)(6512007)(71190400001)(41533002); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR04MB4405; H:BYAPR04MB5303.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: D+JnIrWLUueCu6xiRktjmWp9FxhtWohADzeOyxHljUQFq2v8474ddTzUXKuspHlVJrxTLZJ0+9JjMAVWBfXfUlu7xUQqy8ZGi40VHKFIbVftxuAQne1RVL768MNe405L3MpsKKWhY0poOHE6+8TW2g1pGviXw6v9z1zy8vbMFXr+IcaefFRj7uLD6NYRqoovhGLBATo104GSrKMrlMC2aT/BS9UgzZy3Otu0cCHAsONYTp2DzGLuW6Y90iYjb9P1ziVch1AYg5ad1EKU8Ejqn4AbZKZxTazHsqItuwsZiuWL6rQ3Ota7AV3KaudOdP70s6FEA0pgQl8I7uRkfGc/sStt+GkGPZRjoI4sB1lkkDGXqudaiKtoPSG5WymoVO5cqBVF/wk5p+90kpuozhHjd4XRJ+dGv7ztbRR+rdNKJzY= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 112690dc-3a9e-4c0f-ad3a-08d68152b392 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2019 16:49:08.1570 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4405 Cc: Palmer Dabbelt , U-Boot Mailing List , Alexander Graf , Christoph Hellwig , Paul Walmsley Subject: [U-Boot] [PATCH v4 06/15] riscv: generic: Ensure that U-Boot runs within 4GB for 64bit systems X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" On 64bit systems, the DRAM top can be easily beyond 4GB and U-Boot DMA mapping APIs will generate DMA addresses beyond 4GB. This breaks DMA programming in 32bit DMA capable devices (such as Cadence MACB ethernet). For example, If DRAM is more then 2GB on QEMU sifive_u machine then Cadence MACB ethernet stops working for U-Boot because it is a 32bit DMA capable device. To handle 32bit DMA capable devices on 64bit systems, we provide custom implementation of board_get_usable_ram_top() which ensures that usable ram top is not more then 4GB. This in-turn ensures that U-Boot always runs within 4GB hence DMA addresses generated by DMA mapping APIs will be within 4GB too. Signed-off-by: Atish Patra Signed-off-by: Anup Patel Reviewed-by: Alexander Graf Reviewed-by: Lukas Auer Reviewed-by: Bin Meng --- arch/riscv/cpu/generic/dram.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/arch/riscv/cpu/generic/dram.c b/arch/riscv/cpu/generic/dram.c index 84d87d2a7f..b7b1207235 100644 --- a/arch/riscv/cpu/generic/dram.c +++ b/arch/riscv/cpu/generic/dram.c @@ -5,6 +5,9 @@ #include #include +#include + +DECLARE_GLOBAL_DATA_PTR; int dram_init(void) { @@ -15,3 +18,20 @@ int dram_init_banksize(void) { return fdtdec_setup_memory_banksize(); } + +ulong board_get_usable_ram_top(ulong total_size) +{ +#ifdef CONFIG_64BIT + /* + * Ensure that we run from first 4GB so that all + * addresses used by U-Boot are 32bit addresses. + * + * This in-turn ensures that 32bit DMA capable + * devices work fine because DMA mapping APIs will + * provide 32bit DMA addresses only. + */ + if (gd->ram_top > SZ_4G) + return SZ_4G; +#endif + return gd->ram_top; +}