From patchwork Wed Jan 23 16:49:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1030065 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="P1uwBfZN"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="hmBxYrgs"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43lBGw1CTSz9s3l for ; Thu, 24 Jan 2019 03:55:04 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id D35B1C21CB1; Wed, 23 Jan 2019 16:54:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC, RCVD_IN_DNSWL_BLOCKED, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id F274BC21D65; Wed, 23 Jan 2019 16:51:31 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 40250C21D8E; Wed, 23 Jan 2019 16:50:04 +0000 (UTC) Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by lists.denx.de (Postfix) with ESMTPS id A7E9EC21DFD for ; Wed, 23 Jan 2019 16:50:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1548262201; x=1579798201; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AGopGUiXazjgN5ZuY1nzw0BAbdwpOrkv1RV7FfRgwcQ=; b=P1uwBfZNzR//BBYE1qF+3o27pYFxKK3EtGTc3mNhgL4WPzdlGZSKowLr qPpuS8o4Q7BvyiUX7kb4Kt/qfEU9SoUfNVIqOwdLI5/Rdod/S981hcPjM b/imtcM17cG1wR8ZLlU+PzWjdct8n6o7qfRFVLJQwdKtfvyQBYU4o7dMb Y8FtnKFOLlF56lBpXi8SmjpkUUuZOGk7UmGb+hE2UN9swzrZGPG/lXCEq iVYiXar/LevWovlGS8wqFwYvvciZZWL0m2RnsaC+iBCRCXx4Shai7z2ig Fl0oi7cguTqjrg6NHrd20qDjGxNBDgSrK664IPnJJwjF9ZQIcVEuKohT0 A==; X-IronPort-AV: E=Sophos;i="5.56,512,1539619200"; d="scan'208";a="104534192" Received: from mail-bn3nam04lp2053.outbound.protection.outlook.com (HELO NAM04-BN3-obe.outbound.protection.outlook.com) ([104.47.46.53]) by ob1.hgst.iphmx.com with ESMTP; 24 Jan 2019 00:49:58 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u0pk+m+saWEBpumb8AcuizP7KdgAEiXUxCJ16WAWEek=; b=hmBxYrgsL6OidOcsIgXEWfWWhj5pWMfHacvbDF+d5bQaJCd5qgBoP05v0Z85+qVbGzG45I8ZP369YMGhKpS/YJiNC+2GQGnypod1LeVj0yo9MK3VWci1xo5U9IYDYyOf+AwGnqjQaKOSoKu/YNvMvV6kpZANFIUL5zVgr6NwS9w= Received: from BYAPR04MB5303.namprd04.prod.outlook.com (20.178.49.148) by BYAPR04MB5110.namprd04.prod.outlook.com (52.135.235.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.16; Wed, 23 Jan 2019 16:49:56 +0000 Received: from BYAPR04MB5303.namprd04.prod.outlook.com ([fe80::add1:92cc:65d7:5d94]) by BYAPR04MB5303.namprd04.prod.outlook.com ([fe80::add1:92cc:65d7:5d94%2]) with mapi id 15.20.1537.031; Wed, 23 Jan 2019 16:49:56 +0000 From: Anup Patel To: Rick Chen , Bin Meng , Joe Hershberger , Michal Simek , Michal Simek , Lukas Auer , Masahiro Yamada , Simon Glass Thread-Topic: [PATCH v4 12/15] drivers: serial_sifive: Skip baudrate config if no input clock Thread-Index: AQHUszursJphKQ1MjUiYeOByVm284w== Date: Wed, 23 Jan 2019 16:49:56 +0000 Message-ID: <20190123164808.128994-13-anup.patel@wdc.com> References: <20190123164808.128994-1-anup.patel@wdc.com> In-Reply-To: <20190123164808.128994-1-anup.patel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MA1PR01CA0077.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00::17) To BYAPR04MB5303.namprd04.prod.outlook.com (2603:10b6:a03:c8::20) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anup.Patel@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [49.207.49.227] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR04MB5110; 6:PVflR0JMBBaOCSLTpG1qrh5fNlULqEajsJdcT2aejT5VbRvCZCpMHayvhK4a+bM2CATFMe9DmjoiHQDwJFhA2IIEYeReemcrpRcJfx56KtouiNP59DjUjUa8aE69lewUYt/51/xLMyiSnK6ZGo7c7UguVsTf5I5C6ofYxBZGUGnzaDEgYdGu0Xe7JHWdp8ukBUiW0pEQXRPC+YfZAy7GMnJK8fjoEltHzGH7B9vdi7bD8saZm3j6yqj0UfMjrdsFzUCZYU//lh0N+PGvdvYM620/2ElG/Oh84oPWevzQu63x0/s1/in50PkbBJ1j23/OAanc+LU7ji19R4jVJVm5vXaCtf4Np86CU2LR/TDRf/mvLCnDFcoxJynplnW1YSm67G2suJfCeA3EGD6Pu5dwaxbMs3NyxwtEyJ5FfupLqDCwbe7jFtsBS+Bwihdvq2eyXyMqzGj/+uQQoO5oglBM4w==; 5:Jch25gQYKhOy+33iG/xXfMBj5Yt9UgOQwDoDkSgIbEZdxwCc7mGwS/zQzyI3ZjCXzisn3uGsXzVyQ5+st8YJDS9jJpm5yuKt9XiQXSKkAr0tSF8m2WPp4ziu2TXBDveX9j9UDLzfJRUgTRqE9bMZSXhmkjuPiFKyb5UO/NSgsf48LsZoLCfYW00Co0g0L/MoLPOnP+9cQlUzTefBYH5Xkg==; 7:PeU2UopUpjgXR/d1oNuVttjrEnk7u3St37G6HchJFO5AA0TshwmAkLzkmaOKXK9TijA7n4xfCM48/WjZbmNQUUBbwQQFhKqorVFfWExBcc0skv7QvMWYhBGwj/m1trPkSVyJRe4BUyvQ+/3GkRymxA== x-ms-office365-filtering-correlation-id: 9e1d35af-1821-4009-a4f2-08d68152cddc x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600110)(711020)(4605077)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:BYAPR04MB5110; x-ms-traffictypediagnostic: BYAPR04MB5110: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-forefront-prvs: 0926B0E013 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(346002)(39860400002)(136003)(376002)(396003)(189003)(199004)(99286004)(2906002)(110136005)(7416002)(486006)(50226002)(54906003)(316002)(52116002)(6512007)(76176011)(53936002)(36756003)(97736004)(71200400001)(71190400001)(476003)(86362001)(8936002)(14454004)(1076003)(68736007)(2616005)(102836004)(386003)(6506007)(25786009)(11346002)(66066001)(3846002)(106356001)(6116002)(55236004)(72206003)(44832011)(81166006)(81156014)(6486002)(478600001)(39060400002)(256004)(26005)(4326008)(7736002)(6436002)(305945005)(186003)(105586002)(446003)(8676002); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR04MB5110; H:BYAPR04MB5303.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: plHgnrk2LDGL0mgkkntymIUIban+zs+1hZN1eY+TXb+h9Tx4g2e4Jeqlk+Fnw8C5oWfmdW79D+Eea75KN0vnl844D2mHblWahJtkx7yfQNTWe3TQwxyiG8rzxVxbyK61xdzNex18M0huIrVQ2C8bjAXgcllQ0F+Bjj46ghesAGIDei/fGjCMknf/ENSzUJcE7TgAj5EPdml+K2DjBawrB7RErq51ngNAx7+qlb3n1FuoLhOlILEtr/3dsQFSOhEjdiv8zQLDdBfvo1zFiylHfGoy7IJTnXw/ePfsKV+CJhr4d1tuFAkLC6oXcOfFZBaCPGGLef1WIpUCiAWQidoW8jIxFjoJuS5UZR8SZjJUpLSXKDBP1FYCuVPpIzSC4B3x43ANxlI8EjphZ96znQTh5YFZnI0tDJFrluQjsdMuds4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e1d35af-1821-4009-a4f2-08d68152cddc X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2019 16:49:52.1288 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB5110 Cc: Palmer Dabbelt , U-Boot Mailing List , Alexander Graf , Christoph Hellwig , Paul Walmsley Subject: [U-Boot] [PATCH v4 12/15] drivers: serial_sifive: Skip baudrate config if no input clock X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Atish Patra It is possible that input clock is not available because clk device was not available and 'clock-frequency' DT property is also not available. In this case, instead of failing we should just skip baudrate config by returning zero. Signed-off-by: Atish Patra Signed-off-by: Anup Patel Reviewed-by: Alexander Graf --- drivers/serial/serial_sifive.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/serial/serial_sifive.c b/drivers/serial/serial_sifive.c index ea4d35d48c..537bc7a975 100644 --- a/drivers/serial/serial_sifive.c +++ b/drivers/serial/serial_sifive.c @@ -99,27 +99,27 @@ static int _sifive_serial_getc(struct uart_sifive *regs) static int sifive_serial_setbrg(struct udevice *dev, int baudrate) { - int err; + int ret; struct clk clk; struct sifive_uart_platdata *platdata = dev_get_platdata(dev); + u32 clock = 0; - err = clk_get_by_index(dev, 0, &clk); - if (!err) { - err = clk_get_rate(&clk); - if (!IS_ERR_VALUE(err)) - platdata->clock = err; - } else if (err != -ENOENT && err != -ENODEV && err != -ENOSYS) { + ret = clk_get_by_index(dev, 0, &clk); + if (IS_ERR_VALUE(ret)) { debug("SiFive UART failed to get clock\n"); - return err; - } - - if (!platdata->clock) - platdata->clock = dev_read_u32_default(dev, "clock-frequency", 0); - if (!platdata->clock) { - debug("SiFive UART clock not defined\n"); - return -EINVAL; + ret = dev_read_u32(dev, "clock-frequency", &clock); + if (IS_ERR_VALUE(ret)) { + debug("SiFive UART clock not defined\n"); + return 0; + } + } else { + clock = clk_get_rate(&clk); + if (IS_ERR_VALUE(clock)) { + debug("SiFive UART clock get rate failed\n"); + return 0; + } } - + platdata->clock = clock; _sifive_serial_setbrg(platdata->regs, platdata->clock, baudrate); return 0;